mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-30 08:40:07 +00:00
84c426b85d
Doing all-ABIs compile testing produces a compiler warning in
stdlib/bug-getcontext.c on nios2 and tilepro (with GCC 5 branch):
bug-getcontext.c: In function 'do_test':
bug-getcontext.c:53:6: error: 'except_mask' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (mask != except_mask)
^
This warning appears nonsensical; except_mask is initialized where
it's declared. I think what must be happening here is that the
compiler is confused by the returns-twice nature of getcontext: if
there were a call to setcontext, local variables could indeed have
lost their values on the second return from getcontext. This patch
duly uses the DIAG_* macros to disable the warning here.
Tested for nios2 and tilepro (compilation only; after this patch all
the tests compile, though there are other failures) and x86_64 (full
testsuite run).
* stdlib/bug-getcontext.c: Include <libc-internal.h>.
(do_test): Disable -Wmaybe-uninitialized around uses of
except_mask.
77 lines
1.7 KiB
C
77 lines
1.7 KiB
C
/* BZ 12420 */
|
|
|
|
#include <errno.h>
|
|
#include <fenv.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <ucontext.h>
|
|
#include <libc-internal.h>
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
if (FE_ALL_EXCEPT == 0)
|
|
{
|
|
printf("Skipping test; no support for FP exceptions.\n");
|
|
return 0;
|
|
}
|
|
|
|
int except_mask = 0;
|
|
#ifdef FE_DIVBYZERO
|
|
except_mask |= FE_DIVBYZERO;
|
|
#endif
|
|
#ifdef FE_INVALID
|
|
except_mask |= FE_INVALID;
|
|
#endif
|
|
#ifdef FE_OVERFLOW
|
|
except_mask |= FE_OVERFLOW;
|
|
#endif
|
|
#ifdef FE_UNDERFLOW
|
|
except_mask |= FE_UNDERFLOW;
|
|
#endif
|
|
int status = feenableexcept (except_mask);
|
|
|
|
except_mask = fegetexcept ();
|
|
if (except_mask == -1)
|
|
{
|
|
printf("\nBefore getcontext(): fegetexcept returned: %d\n",
|
|
except_mask);
|
|
return 1;
|
|
}
|
|
|
|
ucontext_t ctx;
|
|
status = getcontext(&ctx);
|
|
if (status)
|
|
{
|
|
printf("\ngetcontext failed, errno: %d.\n", errno);
|
|
return 1;
|
|
}
|
|
|
|
printf ("\nDone with getcontext()!\n");
|
|
fflush (NULL);
|
|
|
|
/* On nios2 and tilepro, GCC 5 warns that except_mask may be used
|
|
uninitialized. Because it is always initialized and nothing in
|
|
this test ever calls setcontext (a setcontext call could result
|
|
in local variables being clobbered on the second return from
|
|
getcontext), in fact an uninitialized use is not possible. */
|
|
DIAG_PUSH_NEEDS_COMMENT;
|
|
DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
|
|
int mask = fegetexcept ();
|
|
if (mask != except_mask)
|
|
{
|
|
printf("\nAfter getcontext(): fegetexcept returned: %d, expected: %d.\n",
|
|
mask, except_mask);
|
|
return 1;
|
|
}
|
|
|
|
printf("\nAt end fegetexcept() returned %d, expected: %d.\n",
|
|
mask, except_mask);
|
|
DIAG_POP_NEEDS_COMMENT;
|
|
|
|
return 0;
|
|
}
|
|
|
|
#define TEST_FUNCTION do_test ()
|
|
#include "../test-skeleton.c"
|