mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-30 08:40:07 +00:00
c3d466cba1
Remove the slow paths from pow. Like several other double precision math functions, pow is exactly rounded. This is not required from math functions and causes major overheads as it requires multiple fallbacks using higher precision arithmetic if a result is close to 0.5ULP. Ridiculous slowdowns of up to 100000x have been reported when the highest precision path triggers. All GLIBC math tests pass on AArch64 and x64 (with ULP of pow set to 1). The worst case error is ~0.506ULP. A simple test over a few hundred million values shows pow is 10% faster on average. This fixes BZ #13932. [BZ #13932] * sysdeps/ieee754/dbl-64/uexp.h (err_1): Remove. * benchtests/pow-inputs: Update comment for slow path cases. * manual/probes.texi (slowpow_p10): Delete removed probe. (slowpow_p10): Likewise. * math/Makefile: Remove halfulp.c and slowpow.c. * sysdeps/aarch64/libm-test-ulps: Set ULP of pow to 1. * sysdeps/generic/math_private.h (__exp1): Remove error argument. (__halfulp): Remove. (__slowpow): Remove. * sysdeps/i386/fpu/halfulp.c: Delete file. * sysdeps/i386/fpu/slowpow.c: Likewise. * sysdeps/ia64/fpu/halfulp.c: Likewise. * sysdeps/ia64/fpu/slowpow.c: Likewise. * sysdeps/ieee754/dbl-64/e_exp.c (__exp1): Remove error argument, improve comments and add error analysis. * sysdeps/ieee754/dbl-64/e_pow.c (__ieee754_pow): Add error analysis. (power1): Remove function: (log1): Remove error argument, add error analysis. (my_log2): Remove function. * sysdeps/ieee754/dbl-64/halfulp.c: Delete file. * sysdeps/ieee754/dbl-64/slowpow.c: Likewise. * sysdeps/m68k/m680x0/fpu/halfulp.c: Likewise. * sysdeps/m68k/m680x0/fpu/slowpow.c: Likewise. * sysdeps/powerpc/power4/fpu/Makefile: Remove CPPFLAGS-slowpow.c. * sysdeps/x86_64/fpu/libm-test-ulps: Set ULP of pow to 1. * sysdeps/x86_64/fpu/multiarch/Makefile: Remove slowpow-fma.c, slowpow-fma4.c, halfulp-fma.c, halfulp-fma4.c. * sysdeps/x86_64/fpu/multiarch/e_pow-fma.c (__slowpow): Remove define. * sysdeps/x86_64/fpu/multiarch/e_pow-fma4.c (__slowpow): Likewise. * sysdeps/x86_64/fpu/multiarch/halfulp-fma.c: Delete file. * sysdeps/x86_64/fpu/multiarch/halfulp-fma4.c: Likewise. * sysdeps/x86_64/fpu/multiarch/slowpow-fma.c: Likewise. * sysdeps/x86_64/fpu/multiarch/slowpow-fma4.c: Likewise. |
||
---|---|---|
.. | ||
scripts | ||
strcoll-inputs | ||
acos-inputs | ||
acosh-inputs | ||
asin-inputs | ||
asinh-inputs | ||
atan-inputs | ||
atanh-inputs | ||
bench-bcopy.c | ||
bench-bzero.c | ||
bench-malloc-thread.c | ||
bench-math-inlines.c | ||
bench-memccpy.c | ||
bench-memchr.c | ||
bench-memcmp.c | ||
bench-memcpy-large.c | ||
bench-memcpy-random.c | ||
bench-memcpy-walk.c | ||
bench-memcpy.c | ||
bench-memmem.c | ||
bench-memmove-large.c | ||
bench-memmove-walk.c | ||
bench-memmove.c | ||
bench-mempcpy.c | ||
bench-memrchr.c | ||
bench-memset-large.c | ||
bench-memset-walk.c | ||
bench-memset.c | ||
bench-rawmemchr.c | ||
bench-skeleton.c | ||
bench-stpcpy_chk.c | ||
bench-stpcpy.c | ||
bench-stpncpy.c | ||
bench-strcasecmp.c | ||
bench-strcasestr.c | ||
bench-strcat.c | ||
bench-strchr.c | ||
bench-strchrnul.c | ||
bench-strcmp.c | ||
bench-strcoll.c | ||
bench-strcpy_chk.c | ||
bench-strcpy.c | ||
bench-strcspn.c | ||
bench-string.h | ||
bench-strlen.c | ||
bench-strncasecmp.c | ||
bench-strncat.c | ||
bench-strncmp.c | ||
bench-strncpy.c | ||
bench-strnlen.c | ||
bench-strpbrk.c | ||
bench-strrchr.c | ||
bench-strsep.c | ||
bench-strspn.c | ||
bench-strstr.c | ||
bench-strtod.c | ||
bench-strtok.c | ||
bench-timing-type.c | ||
bench-timing.h | ||
bench-util.c | ||
bench-util.h | ||
bench-wcpcpy.c | ||
bench-wcpncpy.c | ||
bench-wcscat.c | ||
bench-wcschr.c | ||
bench-wcschrnul.c | ||
bench-wcscmp.c | ||
bench-wcscpy.c | ||
bench-wcscspn.c | ||
bench-wcslen.c | ||
bench-wcsncat.c | ||
bench-wcsncmp.c | ||
bench-wcsncpy.c | ||
bench-wcsnlen.c | ||
bench-wcspbrk.c | ||
bench-wcsrchr.c | ||
bench-wcsspn.c | ||
bench-wmemchr.c | ||
bench-wmemcmp.c | ||
bench-wmemset.c | ||
cos-inputs | ||
cosf-inputs | ||
cosh-inputs | ||
exp2-inputs | ||
exp2f-inputs | ||
exp-inputs | ||
expf-inputs | ||
ffs-inputs | ||
ffsll-inputs | ||
fmax-inputs | ||
fmaxf-inputs | ||
fmin-inputs | ||
fminf-inputs | ||
json-lib.c | ||
json-lib.h | ||
log2-inputs | ||
log2f-inputs | ||
log-inputs | ||
logf-inputs | ||
Makefile | ||
modf-inputs | ||
pow-inputs | ||
powf-inputs | ||
pthread_once-inputs | ||
pthread_once-source.c | ||
README | ||
rint-inputs | ||
sin-inputs | ||
sincos-inputs | ||
sincosf-inputs | ||
sinf-inputs | ||
sinh-inputs | ||
sprintf-inputs | ||
sprintf-source.c | ||
sqrt-inputs | ||
tan-inputs | ||
tanh-inputs | ||
thread_create-inputs | ||
thread_create-source.c | ||
trunc-inputs | ||
truncf-inputs |
Using the glibc microbenchmark suite ==================================== The glibc microbenchmark suite automatically generates code for specified functions, builds and calls them repeatedly for given inputs to give some basic performance properties of the function. Running the benchmark: ===================== The benchmark needs python 2.7 or later in addition to the dependencies required to build the GNU C Library. One may run the benchmark by invoking make as follows: $ make bench This runs each function for 10 seconds and appends its output to benchtests/bench.out. To ensure that the tests are rebuilt, one could run: $ make bench-clean The duration of each test can be configured setting the BENCH_DURATION variable in the call to make. One should run `make bench-clean' before changing BENCH_DURATION. $ make BENCH_DURATION=1 bench The benchmark suite does function call measurements using architecture-specific high precision timing instructions whenever available. When such support is not available, it uses clock_gettime (CLOCK_PROCESS_CPUTIME_ID). One can force the benchmark to use clock_gettime by invoking make as follows: $ make USE_CLOCK_GETTIME=1 bench Again, one must run `make bench-clean' before changing the measurement method. Running benchmarks on another target: ==================================== If the target where you want to run benchmarks is not capable of building the code or you're cross-building, you could build and execute the benchmark in separate steps. On the build system run: $ make bench-build and then copy the source and build directories to the target and run the benchmarks from the build directory as usual: $ make bench make sure the copy preserves timestamps by using either rsync or scp -p otherwise the above command may try to build the benchmark again. Benchmarks that require generated code to be executed during the build are skipped when cross-building. Running subsets of benchmarks: ============================== To run only a subset of benchmarks, one may invoke make as follows $ make bench BENCHSET="bench-pthread bench-math malloc-thread" where BENCHSET may be a space-separated list of the following values: bench-math bench-pthread bench-string string-benchset wcsmbs-benchset stdlib-benchset stdio-common-benchset math-benchset malloc-thread Adding a function to benchtests: =============================== If the name of the function is `foo', then the following procedure should allow one to add `foo' to the bench tests: - Append the function name to the bench variable in the Makefile. - Make a file called `foo-inputs` to provide the definition and input for the function. The file should have some directives telling the parser script about the function and then one input per line. Directives are lines that have a special meaning for the parser and they begin with two hashes '##'. The following directives are recognized: - args: This should be assigned a colon separated list of types of the input arguments. This directive may be skipped if the function does not take any inputs. One may identify output arguments by nesting them in <>. The generator will create variables to get outputs from the calling function. - ret: This should be assigned the type that the function returns. This directive may be skipped if the function does not return a value. - includes: This should be assigned a comma-separated list of headers that need to be included to provide declarations for the function and types it may need (specifically, this includes using "#include <header>"). - include-sources: This should be assigned a comma-separated list of source files that need to be included to provide definitions of global variables and functions (specifically, this includes using "#include "source"). See pthread_once-inputs and pthreads_once-source.c for an example of how to use this to benchmark a function that needs state across several calls. - init: Name of an initializer function to call to initialize the benchtest. - name: See following section for instructions on how to use this directive. Lines beginning with a single hash '#' are treated as comments. See pow-inputs for an example of an input file. Multiple execution units per function: ===================================== Some functions have distinct performance characteristics for different input domains and it may be necessary to measure those separately. For example, some math functions perform computations at different levels of precision (64-bit vs 240-bit vs 768-bit) and mixing them does not give a very useful picture of the performance of these functions. One could separate inputs for these domains in the same file by using the `name' directive that looks something like this: ##name: 240bit See the pow-inputs file for an example of what such a partitioned input file would look like. It is also possible to measure throughput of a (partial) trace extracted from a real workload. In this case the whole trace is iterated over multiple times rather than repeating every input multiple times. This can be done via: ##name: workload-<name> Benchmark Sets: ============== In addition to standard benchmarking of functions, one may also generate custom outputs for a set of functions. This is currently used by string function benchmarks where the aim is to compare performance between implementations at various alignments and for various sizes. To add a benchset for `foo': - Add `foo' to the benchset variable. - Write your bench-foo.c that prints out the measurements to stdout. - On execution, a bench-foo.out is created in $(objpfx) with the contents of stdout. Reading String Benchmark Results: ================================ Some of the string benchmark results are now in JSON to make it easier to read in scripts. Use the benchtests/compare_strings.py script to show the results in a tabular format, generate graphs and more. Run benchtests/scripts/compare_strings.py -h for usage information.