glibc/sysdeps/generic
Chung-Lin Tang 15a0c5730d elf: Fix slow DSO sorting behavior in dynamic loader (BZ #17645)
This second patch contains the actual implementation of a new sorting algorithm
for shared objects in the dynamic loader, which solves the slow behavior that
the current "old" algorithm falls into when the DSO set contains circular
dependencies.

The new algorithm implemented here is simply depth-first search (DFS) to obtain
the Reverse-Post Order (RPO) sequence, a topological sort. A new l_visited:1
bitfield is added to struct link_map to more elegantly facilitate such a search.

The DFS algorithm is applied to the input maps[nmap-1] backwards towards
maps[0]. This has the effect of a more "shallow" recursion depth in general
since the input is in BFS. Also, when combined with the natural order of
processing l_initfini[] at each node, this creates a resulting output sorting
closer to the intuitive "left-to-right" order in most cases.

Another notable implementation adjustment related to this _dl_sort_maps change
is the removing of two char arrays 'used' and 'done' in _dl_close_worker to
represent two per-map attributes. This has been changed to simply use two new
bit-fields l_map_used:1, l_map_done:1 added to struct link_map. This also allows
discarding the clunky 'used' array sorting that _dl_sort_maps had to sometimes
do along the way.

Tunable support for switching between different sorting algorithms at runtime is
also added. A new tunable 'glibc.rtld.dynamic_sort' with current valid values 1
(old algorithm) and 2 (new DFS algorithm) has been added. At time of commit
of this patch, the default setting is 1 (old algorithm).

Signed-off-by: Chung-Lin Tang  <cltang@codesourcery.com>
Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
2021-10-21 11:23:53 -03:00
..
net Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
netinet Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
nfs Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
sys Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
_G_config.h
_itoa.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
a.out.h
abort-instr.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
adaptive_spin_count.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
aio_misc.h Linux: Cleanups after librt move 2021-06-28 09:51:01 +02:00
allocalim.h
arch-fd_to_filename.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
asm-syntax.h
atomic-machine.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
c++-types.data
confstr.h
crti.S Introduce <elf-initfini.h> and ELF_INITFINI for all architectures 2020-02-18 15:12:25 +01:00
crtn.S Introduce <elf-initfini.h> and ELF_INITFINI for all architectures 2020-02-18 15:12:25 +01:00
device-nrs.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dirstream.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-auxv.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-cache.h ldconfig/x86: Store ISA level in cache and aux cache 2021-01-13 05:51:17 -08:00
dl-dtprocnum.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-dtv.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-fcntl.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-fileid.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-fptr.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-hash.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-hwcap-check.h elf: Add hook for checking HWCAP bits after auxiliary vector parsing 2021-05-19 11:09:57 +02:00
dl-irel.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-isa-level.h ldconfig/x86: Store ISA level in cache and aux cache 2021-01-13 05:51:17 -08:00
dl-librecon.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
dl-lookupcfg.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-machine-rel.h elf: Fix dynamic-link.h usage on rtld.c 2021-10-14 14:52:07 -03:00
dl-machine.h elf: Fix dynamic-link.h usage on rtld.c 2021-10-14 14:52:07 -03:00
dl-mman.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-osinfo.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-procinfo.c
dl-procinfo.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
dl-procruntime.c
dl-prop.h Initial support for GNU_PROPERTY_1_NEEDED 2021-10-07 10:26:08 -07:00
dl-protected.h Add run-time check for indirect external access 2021-10-07 10:26:48 -07:00
dl-relocate-ld.h ld.so: Initialize bootstrap_map.l_ld_readonly [BZ #28340] 2021-10-19 06:40:38 -07:00
dl-sysdep.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-tls.h
dl-unistd.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-vdso-setup.c elf: Move vDSO setup to rtld (BZ#24967) 2020-01-03 11:22:07 -03:00
dl-vdso-setup.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-vdso.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dwarf2.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
elf_machine_sym_no_match.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
elf-initfini.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
elf-read-prop.h ldconfig/x86: Store ISA level in cache and aux cache 2021-01-13 05:51:17 -08:00
elide.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
eloop-threshold.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
entry.h
errqueue.h
fd_to_filename.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
features-time64.h y2038: Add support for 64-bit time on legacy ABIs 2021-06-15 10:42:11 -03:00
fenv_private.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
fips-private.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
fix-fp-int-compare-invalid.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
fix-fp-int-convert-overflow.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
fix-int-fp-convert-zero.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
float128-abi.h
fork.h posix: Consolidate fork implementation 2021-06-24 10:02:06 -03:00
fpu_control.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
framestate.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
gcc-compat.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
gccframe.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
get-rounding-mode.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
gmp-mparam.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
hp-timing-common.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
hp-timing.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
ifreq.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
ifunc-init.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
ifunc-sel.h
internal-signals.h nptl: Remove __libc_allocate_rtsig, __libc_current_sigrtmax, and __libc_current_sigrtmin 2021-03-26 13:37:18 -03:00
intr-msg.h
ld.abilist
ldbl-classify-compat.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
ldconfig.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
ldsodefs.h elf: Fix slow DSO sorting behavior in dynamic loader (BZ #17645) 2021-10-21 11:23:53 -03:00
libanl.abilist
libBrokenLocale.abilist
libc_malloc_debug.abilist Move malloc hooks into a compat DSO 2021-07-22 18:37:59 +05:30
libc_start_call_main.h csu: Move calling main out of __libc_start_main_impl 2021-04-21 19:49:50 +02:00
libc-lock.h Remove pthread_key_create-related internals from libc-lock.h 2021-04-21 19:49:51 +02:00
libc-mmap.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
libc-mtag.h malloc: Only support zeroing and not arbitrary memset with mtag 2021-03-26 11:03:06 +00:00
libc-start.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
libc-symver.h Support for multiple versions in versioned_symbol, compat_symbol 2021-03-25 12:33:02 +01:00
libc-tsd.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
libc.abilist Make sysdeps/generic/libc.abilist empty 2021-05-13 21:28:17 +00:00
libcrypt.abilist
libdl.abilist
libm-alias-double.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
libm-alias-float128.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
libm-alias-float.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
libm-alias-ldouble.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
libm-test-ulps
libm-test-ulps-name
libm.abilist
libnsl.abilist
libnss_compat.abilist
libnss_db.abilist
libnss_dns.abilist
libnss_files.abilist
libnss_hesiod.abilist
libnss_nis.abilist
libnss_nisplus.abilist
libpthread.abilist
libresolv.abilist
librt.abilist
libutil.abilist
link_map.h Initial support for GNU_PROPERTY_1_NEEDED 2021-10-07 10:26:08 -07:00
linkmap.h
local-setxid.h
localplt.data mtrace: Wean away from malloc hooks 2021-07-22 18:38:06 +05:30
machine-gmon.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
machine-lock.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
machine-sp.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Makefile Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
malloc-alignment.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
malloc-machine.h Add a generic malloc test for MALLOC_ALIGNMENT 2021-07-09 06:39:30 -07:00
malloc-size.h Add a generic malloc test for MALLOC_ALIGNMENT 2021-07-09 06:39:30 -07:00
malloc-sysdep.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math_ldbl_opt.h
math_ldbl.h
math_private_calls.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math_private.h math: Remove mpa files [BZ #15267] 2021-03-11 14:26:36 +00:00
math-barriers.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-nan-payload-double.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-nan-payload-float.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-narrow-alias-float128.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-narrow-alias.h Add narrowing square root functions 2021-09-10 20:56:22 +00:00
math-tests-arch.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-tests-exceptions.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-tests-rounding.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-tests-snan-cast.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-tests-snan-payload.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-tests-snan.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-tests-trap-force.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-tests-trap.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-tests.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
math-type-macros-double.h Add narrowing square root functions 2021-09-10 20:56:22 +00:00
math-type-macros-float128.h Add narrowing square root functions 2021-09-10 20:56:22 +00:00
math-type-macros-float.h Add narrowing square root functions 2021-09-10 20:56:22 +00:00
math-type-macros-ldouble.h Add narrowing square root functions 2021-09-10 20:56:22 +00:00
math-type-macros.h Add narrowing square root functions 2021-09-10 20:56:22 +00:00
math-use-builtins-ceil.h math: Decompose math-use-builtins.h 2020-06-22 11:09:45 -03:00
math-use-builtins-copysign.h math: Decompose math-use-builtins.h 2020-06-22 11:09:45 -03:00
math-use-builtins-floor.h math: Decompose math-use-builtins.h 2020-06-22 11:09:45 -03:00
math-use-builtins-fma.h math: Decompose math-use-builtins.h 2020-06-22 11:09:45 -03:00
math-use-builtins-nearbyint.h math: Decompose math-use-builtins.h 2020-06-22 11:09:45 -03:00
math-use-builtins-rint.h math: Decompose math-use-builtins.h 2020-06-22 11:09:45 -03:00
math-use-builtins-round.h math: Decompose math-use-builtins.h 2020-06-22 11:09:45 -03:00
math-use-builtins-roundeven.h Use GCC builtins for roundeven functions if desired. 2021-06-27 07:56:57 -07:00
math-use-builtins-sqrt.h math: Decompose math-use-builtins.h 2020-06-22 11:09:45 -03:00
math-use-builtins-trunc.h math: Decompose math-use-builtins.h 2020-06-22 11:09:45 -03:00
math-use-builtins.h Use GCC builtins for roundeven functions if desired. 2021-06-27 07:56:57 -07:00
memcopy.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
memusage.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
mmap_info.h posix: Fix large mmap64 offset for mips64n32 (BZ#24699) 2019-07-10 16:52:50 -03:00
nan-high-order-bit.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
not-cancel.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
not-errno.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
nscd-types.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
pagecopy.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
paths.h
profil-counter.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
pty-private.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
register-dump.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
rtld_static_init.h elf: Partially initialize ld.so after static dlopen (bug 20802) 2021-05-17 10:06:57 +02:00
rtld-lowlevel.h
safe-fatal.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
setjmpP.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
sigcontextinfo.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
siglist-compat.c signal: Move sys_siglist to a compat symbol 2020-07-07 14:10:58 -03:00
siglist-compat.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
siglist.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
sigset-cvt-mask.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
sigsetops.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
single-thread.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
spawn_int_def.h posix: Add posix_spawn_file_actions_addclosefrom_np 2021-07-08 14:08:15 -03:00
stackguard-macros.h
stackinfo.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
stap-probe-machine.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
startup.h Use <startup.h> in __libc_init_secure 2021-01-19 09:55:47 -08:00
stdio-lock.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
string_private.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
struct_stat_time64.h linux: Add {f}stat{at} y2038 support 2020-10-09 17:02:07 -03:00
symbol-hacks.h Disable symbol hack in libc_nonshared.a 2021-09-27 07:46:25 -07:00
sysdep-cancel.h
sysdep.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
thread_state.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
time64-compat.h y2038: Add support for 64-bit time on legacy ABIs 2021-06-15 10:42:11 -03:00
time-clockid.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tininess.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tls-internal-struct.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tls-internal.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tls-internal.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tls-setup.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tls.h elf: Remove THREAD_GSCOPE_IN_TCB 2021-09-16 01:04:20 +02:00
tst-audit.h
tst-stack-align.h Properly check stack alignment [BZ #27901] 2021-05-24 07:42:12 -07:00
unsecvars.h
unwind-arch.h Implement <unwind-link.h> for dynamically loading the libgcc_s unwinder 2021-03-01 15:58:01 +01:00
unwind-dw2-fde-glibc.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
unwind-dw2-fde.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
unwind-dw2-fde.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
unwind-dw2.c Legacy unwinder: Remove definition of _Unwind_GetCFA 2021-03-16 15:33:09 +01:00
unwind-link.h Implement <unwind-link.h> for dynamically loading the libgcc_s unwinder 2021-03-01 15:58:01 +01:00
unwind-pe.c
unwind-pe.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
unwind-resume.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
unwind-resume.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
unwind.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
utmp-equal.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
xstatver.h Remove mknod wrapper functions, move them to symbols 2020-10-09 17:02:06 -03:00