mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-03 10:21:05 +00:00
c4d17461e0
I get some math test-failures on s390 for float/double/ldouble for various lrint/lround functions like: lrint (0x1p64): Exception "Inexact" set lrint (-0x1p64): Exception "Inexact" set lround (0x1p64): Exception "Inexact" set lround (-0x1p64): Exception "Inexact" set ... GCC emits "convert to fixed" instructions for casting floating point values to integer values. These instructions raise invalid and inexact exceptions if the floating point value exceeds the integer type ranges. This patch enables the various FIX_DBL_LONG_CONVERT_OVERFLOW macros in order to avoid a cast from floating point to integer type and raise the invalid exception with feraiseexcept. The ldbl-128 rint/round functions are now using the same logic. ChangeLog: [BZ #19486] * sysdeps/s390/fix-fp-int-convert-overflow.h: New File. * sysdeps/generic/fix-fp-int-convert-overflow.h (FIX_LDBL_LONG_CONVERT_OVERFLOW, FIX_LDBL_LLONG_CONVERT_OVERFLOW): New define. * sysdeps/arm/fix-fp-int-convert-overflow.h: Likewise. * sysdeps/mips/mips32/fpu/fix-fp-int-convert-overflow.h: Likewise. * sysdeps/ieee754/ldbl-128/s_lrintl.c (__lrintl): Avoid conversions to long int where inexact exceptions could be raised. * sysdeps/ieee754/ldbl-128/s_lroundl.c (__lroundl): Likewise. * sysdeps/ieee754/ldbl-128/s_llrintl.c (__llrintl): Avoid conversions to long long int where inexact exceptions could be raised. * sysdeps/ieee754/ldbl-128/s_llroundl.c (__llroundl): Likewise.
39 lines
1.7 KiB
C
39 lines
1.7 KiB
C
/* Fix for conversion of floating point to integer overflow. MIPS version.
|
|
Copyright (C) 2015-2016 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef FIX_FP_INT_CONVERT_OVERFLOW_H
|
|
#define FIX_FP_INT_CONVERT_OVERFLOW_H 1
|
|
|
|
/* As of GCC 5, the generic libgcc2.c conversions from floating point
|
|
to long long may not raise the correct exceptions on overflow (and
|
|
may raise spurious "inexact" exceptions even in non-overflow cases,
|
|
see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59412>). */
|
|
#define FIX_FLT_LLONG_CONVERT_OVERFLOW 1
|
|
#define FIX_DBL_LLONG_CONVERT_OVERFLOW 1
|
|
#define FIX_LDBL_LLONG_CONVERT_OVERFLOW 0
|
|
|
|
/* As of GCC 5 and binutils 2.25, for MIPS I GCC generates calls to
|
|
assembler macros for conversions from floating point to integer
|
|
types, and those macros save and restore the whole of FSCR and so
|
|
lose exceptions. */
|
|
#define FIX_FLT_LONG_CONVERT_OVERFLOW (__mips == 1)
|
|
#define FIX_DBL_LONG_CONVERT_OVERFLOW (__mips == 1)
|
|
#define FIX_LDBL_LONG_CONVERT_OVERFLOW 0
|
|
|
|
#endif /* fix-fp-int-convert-overflow.h */
|