mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-30 00:31:08 +00:00
468700675f
The p{read,write}v{64} consolidation patch [1] added a wrong guard
for LO_HI_LONG definition. It currently uses both
'__WORDSIZE == 64' and 'defined __ASSUME_WORDSIZE64_ILP32' to set
the value to be passed in one argument, otherwise it will be split
in two.
However it fails on MIPS64n32 where syscalls n32 uses the compat
implementation in the kernel meaning the off_t arguments are passed
in two separate registers.
GLIBC already defines a macro for such cases (__OFF_T_MATCHES_OFF64_T),
so this patch uses it instead.
Checked on x86_64, i686, x32, aarch64, armhf, and s390.
* sysdeps/unix/sysv/linux/sysdep.h
[__WORDSIZE == 64 || __ASSUME_WORDSIZE64_ILP32] (LO_HI_LONG): Remove
guards.
* misc/tst-preadvwritev-common.c: New file.
* misc/tst-preadvwritev.c: Use tst-preadvwritev-common.c.
* misc/tst-preadvwritev64.c: Use tst-preadwritev-common.c and add
a check for files larger than 2GB.
[1] 4751bbe2ad
55 lines
2.0 KiB
C
55 lines
2.0 KiB
C
/* Copyright (C) 2015-2016 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <bits/wordsize.h>
|
|
#include <kernel-features.h>
|
|
|
|
/* Set error number and return -1. A target may choose to return the
|
|
internal function, __syscall_error, which sets errno and returns -1.
|
|
We use -1l, instead of -1, so that it can be casted to (void *). */
|
|
#define INLINE_SYSCALL_ERROR_RETURN_VALUE(err) \
|
|
({ \
|
|
__set_errno (err); \
|
|
-1l; \
|
|
})
|
|
|
|
/* Provide a dummy argument that can be used to force register
|
|
alignment for register pairs if required by the syscall ABI. */
|
|
#ifdef __ASSUME_ALIGNED_REGISTER_PAIRS
|
|
#define __ALIGNMENT_ARG 0,
|
|
#define __ALIGNMENT_COUNT(a,b) b
|
|
#else
|
|
#define __ALIGNMENT_ARG
|
|
#define __ALIGNMENT_COUNT(a,b) a
|
|
#endif
|
|
|
|
/* Provide a common macro to pass 64-bit value on syscalls. */
|
|
#if __WORDSIZE == 64 || defined __ASSUME_WORDSIZE64_ILP32
|
|
# define SYSCALL_LL(val) (val)
|
|
# define SYSCALL_LL64(val) (val)
|
|
#else
|
|
#define SYSCALL_LL(val) \
|
|
__LONG_LONG_PAIR ((val) >> 31, (val))
|
|
#define SYSCALL_LL64(val) \
|
|
__LONG_LONG_PAIR ((long) ((val) >> 32), (long) ((val) & 0xffffffff))
|
|
#endif
|
|
|
|
/* Provide a macro to pass the off{64}_t argument on p{readv,writev}{64}. */
|
|
#define LO_HI_LONG(val) \
|
|
(long) (val), \
|
|
(long) (((uint64_t) (val)) >> 32)
|