mirror of
https://sourceware.org/git/glibc.git
synced 2024-09-20 08:30:00 +00:00
a1735e0aa8
When strcmp-avx2.S is used as the default, elf/tst-valgrind-smoke fails with ==1272761== Conditional jump or move depends on uninitialised value(s) ==1272761== at 0x4022C98: strcmp (strcmp-avx2.S:462) ==1272761== by 0x400B05B: _dl_name_match_p (dl-misc.c:75) ==1272761== by 0x40085F3: _dl_map_object (dl-load.c:1966) ==1272761== by 0x401AEA4: map_doit (rtld.c:644) ==1272761== by 0x4001488: _dl_catch_exception (dl-catch.c:237) ==1272761== by 0x40015AE: _dl_catch_error (dl-catch.c:256) ==1272761== by 0x401B38F: do_preload (rtld.c:816) ==1272761== by 0x401C116: handle_preload_list (rtld.c:892) ==1272761== by 0x401EDF5: dl_main (rtld.c:1842) ==1272761== by 0x401A79E: _dl_sysdep_start (dl-sysdep.c:140) ==1272761== by 0x401BEEE: _dl_start_final (rtld.c:494) ==1272761== by 0x401BEEE: _dl_start (rtld.c:581) ==1272761== by 0x401AD87: ??? (in */elf/ld.so) The assembly codes are: 0x0000000004022c80 <+144>: vmovdqu 0x20(%rdi),%ymm0 0x0000000004022c85 <+149>: vpcmpeqb 0x20(%rsi),%ymm0,%ymm1 0x0000000004022c8a <+154>: vpcmpeqb %ymm0,%ymm15,%ymm2 0x0000000004022c8e <+158>: vpandn %ymm1,%ymm2,%ymm1 0x0000000004022c92 <+162>: vpmovmskb %ymm1,%ecx 0x0000000004022c96 <+166>: inc %ecx => 0x0000000004022c98 <+168>: jne 0x4022c32 <strcmp+66> strcmp-avx2.S has 32-byte vector loads of strings which are shorter than 32 bytes: (gdb) p (char *) ($rdi + 0x20) $6 = 0x1ffeffea20 "memcheck-amd64-linux.so" (gdb) p (char *) ($rsi + 0x20) $7 = 0x4832640 "core-amd64-linux.so" (gdb) call (int) strlen ((char *) ($rsi + 0x20)) $8 = 19 (gdb) call (int) strlen ((char *) ($rdi + 0x20)) $9 = 23 (gdb) It triggers the valgrind error. The above code is safe since the loads don't cross the page boundary. Update tst-valgrind-smoke.sh to accept an optional suppression file and pass a suppression file to valgrind when strcmp-avx2.S is the default implementation of strcmp. Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>
48 lines
1.7 KiB
Bash
48 lines
1.7 KiB
Bash
#!/bin/sh
|
|
# Valgrind smoke test.
|
|
# Copyright (C) 2022-2024 Free Software Foundation, Inc.
|
|
# This file is part of the GNU C Library.
|
|
|
|
# The GNU C Library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2.1 of the License, or (at your option) any later version.
|
|
|
|
# The GNU C Library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with the GNU C Library; if not, see
|
|
# <https://www.gnu.org/licenses/>.
|
|
|
|
set -e
|
|
|
|
rtld="$1"
|
|
system_rtld="$2"
|
|
test_wrapper_env="$3"
|
|
run_program_env="$4"
|
|
library_path="$5"
|
|
test_prog="$6"
|
|
valgrind_suppressions="$7"
|
|
|
|
# Test whether valgrind is available in the test
|
|
# environment. If not, skip the test.
|
|
${test_wrapper_env} ${run_program_env} \
|
|
/bin/sh -c "command -v valgrind" || exit 77
|
|
|
|
# Test valgrind works with the system ld.so in the test environment
|
|
/bin/sh -c \
|
|
"${test_wrapper_env} ${run_program_env} \
|
|
valgrind -q --error-exitcode=1 ${valgrind_suppressions} \
|
|
${system_rtld} /bin/echo ${system_rtld}" || exit 77
|
|
|
|
# Finally the actual test inside the test environment,
|
|
# using the just build ld.so and new libraries to run
|
|
# the smoke test under valgrind.
|
|
/bin/sh -c \
|
|
"${test_wrapper_env} ${run_program_env} \
|
|
valgrind -q --error-exitcode=1 ${valgrind_suppressions} \
|
|
${rtld} --library-path ${library_path} ${test_prog} ${rtld}"
|