mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-10 07:10:06 +00:00
34a5a1460e
The GNU Coding Standards specify that line breaks in expressions should go before an operator, not after one. This patch fixes various code to do this. It only changes code that appears to be mostly following GNU style anyway, not files and directories with substantially different formatting. It is not exhaustive even for files using GNU style (for example, changes to sysdeps files are deferred for subsequent cleanups). Some files changed are shared with gnulib, but most are specific to glibc. Changes were made manually, with places to change found by grep (so some cases, e.g. where the operator was followed by a comment at end of line, are particularly liable to have been missed by grep, but I did include cases where the operator was followed by backslash-newline). This patch generally does not attempt to address other coding style issues in the expressions changed (for example, missing spaces before '(', or lack of parentheses to ensure indentation of continuation lines properly reflects operator precedence). Tested for x86_64, and with build-many-glibcs.py. * benchtests/bench-memmem.c (simple_memmem): Break lines before rather than after operators. * benchtests/bench-skeleton.c (TIMESPEC_AFTER): Likewise. * crypt/md5.c (md5_finish_ctx): Likewise. * crypt/sha256.c (__sha256_finish_ctx): Likewise. * crypt/sha512.c (__sha512_finish_ctx): Likewise. * elf/cache.c (load_aux_cache): Likewise. * elf/dl-load.c (open_verify): Likewise. * elf/get-dynamic-info.h (elf_get_dynamic_info): Likewise. * elf/readelflib.c (process_elf_file): Likewise. * elf/rtld.c (dl_main): Likewise. * elf/sprof.c (generate_call_graph): Likewise. * hurd/ctty-input.c (_hurd_ctty_input): Likewise. * hurd/ctty-output.c (_hurd_ctty_output): Likewise. * hurd/dtable.c (reauth_dtable): Likewise. * hurd/getdport.c (__getdport): Likewise. * hurd/hurd/signal.h (_hurd_interrupted_rpc_timeout): Likewise. * hurd/hurd/sigpreempt.h (HURD_PREEMPT_SIGNAL_P): Likewise. * hurd/hurdfault.c (_hurdsig_fault_catch_exception_raise): Likewise. * hurd/hurdioctl.c (fioctl): Likewise. * hurd/hurdselect.c (_hurd_select): Likewise. * hurd/hurdsig.c (_hurdsig_abort_rpcs): Likewise. (STOPSIGS): Likewise. * hurd/hurdstartup.c (_hurd_startup): Likewise. * hurd/intr-msg.c (_hurd_intr_rpc_mach_msg): Likewise. * hurd/lookup-retry.c (__hurd_file_name_lookup_retry): Likewise. * hurd/msgportdemux.c (msgport_server): Likewise. * hurd/setauth.c (_hurd_setauth): Likewise. * include/features.h (__GLIBC_USE_DEPRECATED_SCANF): Likewise. * libio/libioP.h [IO_DEBUG] (CHECK_FILE): Likewise. * locale/programs/ld-ctype.c (set_class_defaults): Likewise. * localedata/tests-mbwc/tst_swscanf.c (tst_swscanf): Likewise. * login/tst-utmp.c (do_check): Likewise. (simulate_login): Likewise. * mach/lowlevellock.h (lll_lock): Likewise. (lll_trylock): Likewise. * math/test-fenv.c (ALL_EXC): Likewise. * math/test-fenvinline.c (ALL_EXC): Likewise. * misc/sys/cdefs.h (__attribute_deprecated_msg__): Likewise. * nis/nis_call.c (__do_niscall3): Likewise. * nis/nis_callback.c (cb_prog_1): Likewise. * nis/nis_defaults.c (searchaccess): Likewise. * nis/nis_findserv.c (__nis_findfastest_with_timeout): Likewise. * nis/nis_ismember.c (internal_ismember): Likewise. * nis/nis_local_names.c (nis_local_principal): Likewise. * nis/nss_nis/nis-rpc.c (_nss_nis_getrpcbyname_r): Likewise. * nis/nss_nisplus/nisplus-netgrp.c (_nss_nisplus_getnetgrent_r): Likewise. * nis/ypclnt.c (yp_match): Likewise. (yp_first): Likewise. (yp_next): Likewise. (yp_master): Likewise. (yp_order): Likewise. * nscd/hstcache.c (cache_addhst): Likewise. * nscd/initgrcache.c (addinitgroupsX): Likewise. * nss/nss_compat/compat-pwd.c (copy_pwd_changes): Likewise. (internal_getpwuid_r): Likewise. * nss/nss_compat/compat-spwd.c (copy_spwd_changes): Likewise. * posix/glob.h (__GLOB_FLAGS): Likewise. * posix/regcomp.c (peek_token): Likewise. (peek_token_bracket): Likewise. (parse_expression): Likewise. * posix/regexec.c (sift_states_iter_mb): Likewise. (check_node_accept_bytes): Likewise. * posix/tst-spawn3.c (do_test): Likewise. * posix/wordexp-test.c (testit): Likewise. * posix/wordexp.c (parse_tilde): Likewise. (exec_comm): Likewise. * posix/wordexp.h (__WRDE_FLAGS): Likewise. * resource/vtimes.c (TIMEVAL_TO_VTIMES): Likewise. * setjmp/sigjmp.c (__sigjmp_save): Likewise. * stdio-common/printf_fp.c (__printf_fp_l): Likewise. * stdio-common/tst-fileno.c (do_test): Likewise. * stdio-common/vfprintf-internal.c (vfprintf): Likewise. * stdlib/strfmon_l.c (__vstrfmon_l_internal): Likewise. * stdlib/strtod_l.c (round_and_return): Likewise. (____STRTOF_INTERNAL): Likewise. * stdlib/tst-strfrom.h (TEST_STRFROM): Likewise. * string/strcspn.c (STRCSPN): Likewise. * string/test-memmem.c (simple_memmem): Likewise. * termios/tcsetattr.c (tcsetattr): Likewise. * time/alt_digit.c (_nl_parse_alt_digit): Likewise. * time/asctime.c (asctime_internal): Likewise. * time/strptime_l.c (__strptime_internal): Likewise. * time/sys/time.h (timercmp): Likewise. * time/tzfile.c (__tzfile_compute): Likewise.
404 lines
7.7 KiB
C
404 lines
7.7 KiB
C
/* Tests for UTMP functions.
|
|
Copyright (C) 1998-2019 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Mark Kettenis <kettenis@phys.uva.nl>, 1998.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <errno.h>
|
|
#include <error.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <sys/types.h>
|
|
#include <time.h>
|
|
|
|
#ifdef UTMPX
|
|
# include <utmpx.h>
|
|
# define utmp utmpx
|
|
# define utmpname utmpxname
|
|
# define setutent setutxent
|
|
# define getutent getutxent
|
|
# define endutent endutxent
|
|
# define getutline getutxline
|
|
# define getutid getutxid
|
|
# define pututline pututxline
|
|
#else
|
|
# include <utmp.h>
|
|
#endif
|
|
|
|
|
|
#if defined UTMPX || _HAVE_UT_TYPE
|
|
|
|
/* Prototype for our test function. */
|
|
static int do_test (int argc, char *argv[]);
|
|
|
|
/* We have a preparation function. */
|
|
static void do_prepare (int argc, char *argv[]);
|
|
#define PREPARE do_prepare
|
|
|
|
/* This defines the `main' function and some more. */
|
|
#include <test-skeleton.c>
|
|
|
|
|
|
/* These are for the temporary file we generate. */
|
|
char *name;
|
|
int fd;
|
|
|
|
static void
|
|
do_prepare (int argc, char *argv[])
|
|
{
|
|
size_t name_len;
|
|
|
|
name_len = strlen (test_dir);
|
|
name = xmalloc (name_len + sizeof ("/utmpXXXXXX"));
|
|
mempcpy (mempcpy (name, test_dir, name_len),
|
|
"/utmpXXXXXX", sizeof ("/utmpXXXXXX"));
|
|
|
|
/* Open our test file. */
|
|
fd = mkstemp (name);
|
|
if (fd == -1)
|
|
error (EXIT_FAILURE, errno, "cannot open test file `%s'", name);
|
|
add_temp_file (name);
|
|
}
|
|
|
|
struct utmp entry[] =
|
|
{
|
|
#if defined UTMPX || _HAVE_UT_TV
|
|
#define UT(a) .ut_tv = { .tv_sec = (a)}
|
|
#else
|
|
#define UT(a) .ut_time = (a)
|
|
#endif
|
|
|
|
{ .ut_type = BOOT_TIME, .ut_pid = 1, UT(1000) },
|
|
{ .ut_type = RUN_LVL, .ut_pid = 1, UT(2000) },
|
|
{ .ut_type = INIT_PROCESS, .ut_pid = 5, .ut_id = "si", UT(3000) },
|
|
{ .ut_type = LOGIN_PROCESS, .ut_pid = 23, .ut_line = "tty1", .ut_id = "1",
|
|
.ut_user = "LOGIN", UT(4000) },
|
|
{ .ut_type = USER_PROCESS, .ut_pid = 24, .ut_line = "tty2", .ut_id = "2",
|
|
.ut_user = "albert", UT(8000) },
|
|
{ .ut_type = USER_PROCESS, .ut_pid = 196, .ut_line = "ttyp0", .ut_id = "p0",
|
|
.ut_user = "niels", UT(10000) },
|
|
{ .ut_type = DEAD_PROCESS, .ut_line = "ttyp1", .ut_id = "p1", UT(16000) },
|
|
{ .ut_type = EMPTY },
|
|
{ .ut_type = EMPTY }
|
|
};
|
|
int num_entries = sizeof entry / sizeof (struct utmp);
|
|
|
|
time_t entry_time = 20000;
|
|
pid_t entry_pid = 234;
|
|
|
|
static int
|
|
do_init (void)
|
|
{
|
|
int n;
|
|
|
|
setutent ();
|
|
|
|
for (n = 0; n < num_entries; n++)
|
|
{
|
|
if (pututline (&entry[n]) == NULL)
|
|
{
|
|
error (0, errno, "cannot write UTMP entry");
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
endutent ();
|
|
|
|
return 0;
|
|
}
|
|
|
|
|
|
static int
|
|
do_check (void)
|
|
{
|
|
struct utmp *ut;
|
|
int n;
|
|
|
|
setutent ();
|
|
|
|
n = 0;
|
|
while ((ut = getutent ()))
|
|
{
|
|
if (n < num_entries
|
|
&& memcmp (ut, &entry[n], sizeof (struct utmp)))
|
|
{
|
|
error (0, 0, "UTMP entry does not match");
|
|
return 1;
|
|
}
|
|
|
|
n++;
|
|
}
|
|
|
|
if (n != num_entries)
|
|
{
|
|
error (0, 0, "number of UTMP entries is incorrect");
|
|
return 1;
|
|
}
|
|
|
|
endutent ();
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
simulate_login (const char *line, const char *user)
|
|
{
|
|
int n;
|
|
|
|
for (n = 0; n < num_entries; n++)
|
|
{
|
|
if (strcmp (line, entry[n].ut_line) == 0
|
|
|| entry[n].ut_type == DEAD_PROCESS)
|
|
{
|
|
if (entry[n].ut_pid == DEAD_PROCESS)
|
|
entry[n].ut_pid = (entry_pid += 27);
|
|
entry[n].ut_type = USER_PROCESS;
|
|
strncpy (entry[n].ut_user, user, sizeof (entry[n].ut_user));
|
|
#if defined UTMPX || _HAVE_UT_TV - 0
|
|
entry[n].ut_tv.tv_sec = (entry_time += 1000);
|
|
#else
|
|
entry[n].ut_time = (entry_time += 1000);
|
|
#endif
|
|
setutent ();
|
|
|
|
if (pututline (&entry[n]) == NULL)
|
|
{
|
|
error (0, errno, "cannot write UTMP entry");
|
|
return 1;
|
|
}
|
|
|
|
endutent ();
|
|
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
error (0, 0, "no entries available");
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
simulate_logout (const char *line)
|
|
{
|
|
int n;
|
|
|
|
for (n = 0; n < num_entries; n++)
|
|
{
|
|
if (strcmp (line, entry[n].ut_line) == 0)
|
|
{
|
|
entry[n].ut_type = DEAD_PROCESS;
|
|
strncpy (entry[n].ut_user, "", sizeof (entry[n].ut_user));
|
|
#if defined UTMPX || _HAVE_UT_TV - 0
|
|
entry[n].ut_tv.tv_sec = (entry_time += 1000);
|
|
#else
|
|
entry[n].ut_time = (entry_time += 1000);
|
|
#endif
|
|
setutent ();
|
|
|
|
if (pututline (&entry[n]) == NULL)
|
|
{
|
|
error (0, errno, "cannot write UTMP entry");
|
|
return 1;
|
|
}
|
|
|
|
endutent ();
|
|
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
error (0, 0, "no entry found for `%s'", line);
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
check_login (const char *line)
|
|
{
|
|
struct utmp *up;
|
|
struct utmp ut;
|
|
int n;
|
|
|
|
setutent ();
|
|
|
|
strcpy (ut.ut_line, line);
|
|
up = getutline (&ut);
|
|
if (up == NULL)
|
|
{
|
|
error (0, errno, "cannot get entry for line `%s'", line);
|
|
return 1;
|
|
}
|
|
|
|
endutent ();
|
|
|
|
for (n = 0; n < num_entries; n++)
|
|
{
|
|
if (strcmp (line, entry[n].ut_line) == 0)
|
|
{
|
|
if (memcmp (up, &entry[n], sizeof (struct utmp)))
|
|
{
|
|
error (0, 0, "UTMP entry does not match");
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
error (0, 0, "bogus entry for line `%s'", line);
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
check_logout (const char *line)
|
|
{
|
|
struct utmp ut;
|
|
|
|
setutent ();
|
|
|
|
strcpy (ut.ut_line, line);
|
|
if (getutline (&ut) != NULL)
|
|
{
|
|
error (0, 0, "bogus login entry for `%s'", line);
|
|
return 1;
|
|
}
|
|
|
|
endutent ();
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
check_id (const char *id)
|
|
{
|
|
struct utmp *up;
|
|
struct utmp ut;
|
|
int n;
|
|
|
|
setutent ();
|
|
|
|
ut.ut_type = USER_PROCESS;
|
|
strcpy (ut.ut_id, id);
|
|
up = getutid (&ut);
|
|
if (up == NULL)
|
|
{
|
|
error (0, errno, "cannot get entry for ID `%s'", id);
|
|
return 1;
|
|
}
|
|
|
|
endutent ();
|
|
|
|
for (n = 0; n < num_entries; n++)
|
|
{
|
|
if (strcmp (id, entry[n].ut_id) == 0)
|
|
{
|
|
if (memcmp (up, &entry[n], sizeof (struct utmp)))
|
|
{
|
|
error (0, 0, "UTMP entry does not match");
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
error (0, 0, "bogus entry for ID `%s'", id);
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
check_type (int type)
|
|
{
|
|
struct utmp *up;
|
|
struct utmp ut;
|
|
int n;
|
|
|
|
setutent ();
|
|
|
|
ut.ut_type = type;
|
|
up = getutid (&ut);
|
|
if (up == NULL)
|
|
{
|
|
error (0, errno, "cannot get entry for type `%d'", type);
|
|
return 1;
|
|
}
|
|
|
|
endutent ();
|
|
|
|
for (n = 0; n < num_entries; n++)
|
|
{
|
|
if (type == entry[n].ut_type)
|
|
{
|
|
if (memcmp (up, &entry[n], sizeof (struct utmp)))
|
|
{
|
|
error (0, 0, "UTMP entry does not match");
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
error (0, 0, "bogus entry for type `%d'", type);
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
do_test (int argc, char *argv[])
|
|
{
|
|
int result = 0;
|
|
|
|
utmpname (name);
|
|
|
|
result |= do_init ();
|
|
result |= do_check ();
|
|
|
|
result |= simulate_login ("tty1", "erwin");
|
|
result |= do_check ();
|
|
|
|
result |= simulate_login ("ttyp1", "paul");
|
|
result |= do_check ();
|
|
|
|
result |= simulate_logout ("tty2");
|
|
result |= do_check ();
|
|
|
|
result |= simulate_logout ("ttyp0");
|
|
result |= do_check ();
|
|
|
|
result |= simulate_login ("ttyp2", "richard");
|
|
result |= do_check ();
|
|
|
|
result |= check_login ("tty1");
|
|
result |= check_logout ("ttyp0");
|
|
result |= check_id ("p1");
|
|
result |= check_id ("2");
|
|
result |= check_id ("si");
|
|
result |= check_type (BOOT_TIME);
|
|
result |= check_type (RUN_LVL);
|
|
|
|
return result;
|
|
}
|
|
|
|
#else
|
|
|
|
/* No field 'ut_type' in struct utmp. */
|
|
int
|
|
main (void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
#endif
|