mirror of
https://sourceware.org/git/glibc.git
synced 2025-01-15 13:30:09 +00:00
9ff72da471
This patch implements a new posix_spawn{p} implementation for Linux. The main difference is it uses the clone syscall directly with CLONE_VM and CLONE_VFORK flags and a direct allocated stack. The new stack and start function solves most the vfork limitation (possible parent clobber due stack spilling). The remaning issue are related to signal handling: 1. That no signal handlers must run in child context, to avoid corrupt parent's state. 2. Child must synchronize with parent to enforce stack deallocation and to possible return execv issues. The first one is solved by blocking all signals in child, even NPTL-internal ones (SIGCANCEL and SIGSETXID). The second issue is done by a stack allocation in parent and a synchronization with using a pipe or waitpid (in case or error). The pipe has the advantage of allowing the child signal an exec error (checked with new tst-spawn2 test). There is an inherent race condition in pipe2 usage for architectures that do not support the syscall directly. In such cases the a pipe plus fctnl is used instead and it may lead to file descriptor leak in parent (as decribed by fcntl documentation). The child process stack is allocate with a mmap with MAP_STACK flag using default architecture stack size. Although it is slower than use a stack buffer from parent, it allows some slack for the compatibility code to run scripts with no shebang (which may use a buffer with size depending of argument list count). Performance should be similar to the vfork default posix implementation and way faster than fork path (vfork on mostly linux ports are basically clone with CLONE_VM plus CLONE_VFORK). The only difference is the syscalls required for the stack allocation/deallocation. It fixes BZ#10354, BZ#14750, and BZ#18433. Tested on i386, x86_64, powerpc64le, and aarch64. [BZ #14750] [BZ #10354] [BZ #18433] * include/sched.h (__clone): Add hidden prototype. (__clone2): Likewise. * include/unistd.h (__dup): Likewise. * posix/Makefile (tests): Add tst-spawn2. * posix/tst-spawn2.c: New file. * sysdeps/posix/dup.c (__dup): Add hidden definition. * sysdeps/unix/sysv/linux/aarch64/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/alpha/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/hppa/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/i386/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/ia64/clone2.S (__clone): Likewise. * sysdeps/unix/sysv/linux/m68k/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/microblaze/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/mips/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/nios2/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/sh/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/tile/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/x86_64/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/nptl-signals.h (____nptl_is_internal_signal): New function. * sysdeps/unix/sysv/linux/spawni.c: New file.
132 lines
3.4 KiB
ArmAsm
132 lines
3.4 KiB
ArmAsm
/* Copyright (C) 1996-2016 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Andreas Schwab (schwab@issan.informatik.uni-dortmund.de)
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library. If not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
/* clone() is even more special than fork() as it mucks with stacks
|
|
and invokes a function in the right context after its all over. */
|
|
|
|
#include <sysdep.h>
|
|
#define _ERRNO_H 1
|
|
#include <bits/errno.h>
|
|
#include <tls.h>
|
|
|
|
#define CLONE_VM 0x00000100
|
|
#define CLONE_THREAD 0x00010000
|
|
|
|
/* int clone(int (*fn)(void *arg), void *child_stack, int flags, void *arg,
|
|
void *parent_tidptr, void *tls, void *child_tidptr) */
|
|
|
|
.text
|
|
ENTRY (__clone)
|
|
|
|
/* Sanity check arguments. */
|
|
movel #-EINVAL, %d0
|
|
movel 4(%sp), %a0 /* no NULL function pointers */
|
|
tstl %a0
|
|
jeq SYSCALL_ERROR_LABEL
|
|
movel 8(%sp), %a1 /* no NULL stack pointers */
|
|
tstl %a1
|
|
jeq SYSCALL_ERROR_LABEL
|
|
|
|
/* Allocate space and copy the argument onto the new stack. */
|
|
movel 16(%sp), -(%a1)
|
|
|
|
/* Do the system call */
|
|
movel 12+0(%sp), %d1 /* get flags */
|
|
movel %d3, -(%a1) /* save %d3 and get parent_tidptr */
|
|
movel %d3, -(%sp)
|
|
cfi_adjust_cfa_offset (4)
|
|
cfi_rel_offset (%d3, 0)
|
|
movel 20+4(%sp), %d3
|
|
movel %d4, -(%a1) /* save %d4 and get child_tidptr */
|
|
movel %d4, -(%sp)
|
|
cfi_adjust_cfa_offset (4)
|
|
cfi_rel_offset (%d4, 0)
|
|
movel 28+8(%sp), %d4
|
|
movel %d5, -(%a1) /* save %d5 and get tls */
|
|
movel %d5, -(%sp)
|
|
cfi_adjust_cfa_offset (4)
|
|
cfi_rel_offset (%d5, 0)
|
|
movel 24+12(%sp), %d5
|
|
/* save %d2 and get stack pointer */
|
|
#ifdef __mcoldfire__
|
|
movel %d2, -(%a1)
|
|
movel %d2, -(%sp)
|
|
cfi_adjust_cfa_offset (4)
|
|
cfi_rel_offset (%d2, 0)
|
|
movel %a1, %d2
|
|
#else
|
|
exg %d2, %a1 /* save %d2 and get stack pointer */
|
|
cfi_register (%d2, %a1)
|
|
#endif
|
|
movel #SYS_ify (clone), %d0
|
|
|
|
/* End FDE now, because in the child the unwind info will be
|
|
wrong. */
|
|
cfi_endproc
|
|
|
|
trap #0
|
|
#ifdef __mcoldfire__
|
|
movel (%sp)+, %d2
|
|
#else
|
|
exg %d2, %a1 /* restore %d2 */
|
|
#endif
|
|
movel (%sp)+, %d5 /* restore %d5, %d4 and %d3 */
|
|
movel (%sp)+, %d4
|
|
movel (%sp)+, %d3
|
|
|
|
tstl %d0
|
|
jmi SYSCALL_ERROR_LABEL
|
|
jeq thread_start
|
|
|
|
rts
|
|
|
|
thread_start:
|
|
cfi_startproc
|
|
cfi_undefined (pc) /* Mark end of stack */
|
|
subl %fp, %fp /* terminate the stack frame */
|
|
/* Check and see if we need to reset the PID. */
|
|
movel %d1, %a1
|
|
andl #CLONE_THREAD, %d1
|
|
jne donepid
|
|
movel %a1, %d1
|
|
movel #-1, %d0
|
|
andl #CLONE_VM, %d1
|
|
jne gotpid
|
|
movel #SYS_ify (getpid), %d0
|
|
trap #0
|
|
gotpid:
|
|
movel %a0, -(%sp)
|
|
movel %d0, -(%sp)
|
|
bsrl __m68k_read_tp@PLTPC
|
|
movel (%sp)+, %d0
|
|
movel %d0, PID_OFFSET(%a0)
|
|
movel %d0, TID_OFFSET(%a0)
|
|
movel (%sp)+, %a0
|
|
donepid:
|
|
jsr (%a0)
|
|
movel %d0, %d1
|
|
movel #SYS_ify (exit), %d0
|
|
trap #0
|
|
cfi_endproc
|
|
|
|
cfi_startproc
|
|
PSEUDO_END (__clone)
|
|
|
|
libc_hidden_def (__clone)
|
|
weak_alias (__clone, clone)
|