glibc/string/test-memset.c
Noah Goldstein 0281c7a7ec String: Strength memset tests in test-memset.c
The prior sentinel logic was broken and was checking the SIMPLE_MEMSET
as opposed to the tested implementation. As well `s` (the test buffer)
was not reset between implementation tests so it was possible for a
buggy implementation to be hidden by a previously executed correct
one.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
2022-02-15 11:25:04 -06:00

283 lines
6.2 KiB
C

/* Test memset functions.
Copyright (C) 1999-2022 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#define TEST_MAIN
#ifdef TEST_BZERO
# ifdef TEST_EXPLICIT_BZERO
# define TEST_NAME "explicit_bzero"
# else
# define TEST_NAME "bzero"
# endif
#else
# ifndef WIDE
# define TEST_NAME "memset"
# else
# define TEST_NAME "wmemset"
# endif /* WIDE */
#endif /* !TEST_BZERO */
#define MIN_PAGE_SIZE 131072
#include "test-string.h"
#ifndef WIDE
# define MEMSET memset
# define CHAR char
# define UCHAR unsigned char
# define SIMPLE_MEMSET simple_memset
# define MEMCMP memcmp
# define BIG_CHAR CHAR_MAX
#else
# include <wchar.h>
# define MEMSET wmemset
# define CHAR wchar_t
# define UCHAR wchar_t
# define SIMPLE_MEMSET simple_wmemset
# define MEMCMP wmemcmp
# define BIG_CHAR WCHAR_MAX
#endif /* WIDE */
CHAR *SIMPLE_MEMSET (CHAR *, int, size_t);
#ifdef TEST_BZERO
typedef void (*proto_t) (char *, size_t);
void simple_bzero (char *, size_t);
void builtin_bzero (char *, size_t);
IMPL (simple_bzero, 0)
IMPL (builtin_bzero, 0)
#ifdef TEST_EXPLICIT_BZERO
IMPL (explicit_bzero, 1)
#else
IMPL (bzero, 1)
#endif
void
simple_bzero (char *s, size_t n)
{
SIMPLE_MEMSET (s, 0, n);
}
void
builtin_bzero (char *s, size_t n)
{
__builtin_bzero (s, n);
}
#else
typedef CHAR *(*proto_t) (CHAR *, int, size_t);
IMPL (SIMPLE_MEMSET, 0)
# ifndef WIDE
char *builtin_memset (char *, int, size_t);
IMPL (builtin_memset, 0)
# endif /* !WIDE */
IMPL (MEMSET, 1)
# ifndef WIDE
char *
builtin_memset (char *s, int c, size_t n)
{
return __builtin_memset (s, c, n);
}
# endif /* !WIDE */
#endif /* !TEST_BZERO */
CHAR *
inhibit_loop_to_libcall
SIMPLE_MEMSET (CHAR *s, int c, size_t n)
{
CHAR *r = s, *end = s + n;
while (r < end)
*r++ = c;
return s;
}
static void
do_one_test (impl_t *impl, CHAR *s, int c __attribute ((unused)), size_t n, int space_below, int space_above)
{
CHAR buf[n];
CHAR sentinel = ~c;
if (space_below)
s[-1] = sentinel;
if (space_above)
s[n] = sentinel;
SIMPLE_MEMSET(s, ~c, n);
#ifdef TEST_BZERO
simple_bzero (buf, n);
CALL (impl, s, n);
if (memcmp (s, buf, n) != 0
|| (space_below && s[-1] != sentinel)
|| (space_above && s[n] != sentinel))
#else
CHAR *res = CALL (impl, s, c, n);
if (res != s
|| SIMPLE_MEMSET (buf, c, n) != buf
|| MEMCMP (s, buf, n) != 0
|| (space_below && s[-1] != sentinel)
|| (space_above && s[n] != sentinel))
#endif /* !TEST_BZERO */
{
error (0, 0, "Wrong result in function %s", impl->name);
ret = 1;
return;
}
}
static void
do_test (size_t align, int c, size_t len)
{
int space_below, space_above;
align &= 4095;
if ((align + len) * sizeof (CHAR) > page_size)
return;
space_below = !!align;
space_above = !((align + len + 1) * sizeof (CHAR) > page_size);
FOR_EACH_IMPL (impl, 0)
do_one_test (impl, (CHAR *) (buf1) + align, c, len, space_below, space_above);
}
#ifndef TEST_BZERO
static void
do_random_tests (void)
{
size_t i, j, k, n, align, len, size;
int c, o;
UCHAR *p, *res;
UCHAR *p2 = (UCHAR *) buf2;
for (i = 0; i < 65536 / sizeof (CHAR); ++i)
p2[i] = random () & BIG_CHAR;
for (n = 0; n < ITERATIONS; n++)
{
if ((random () & 31) == 0)
size = 65536 / sizeof (CHAR);
else
size = 512;
p = (UCHAR *) (buf1 + page_size) - size;
len = random () & (size - 1);
align = size - len - (random () & 31);
if (align > size)
align = size - len;
if ((random () & 7) == 0)
align &= ~63;
if ((random () & 7) == 0)
c = 0;
else
c = random () & BIG_CHAR;
o = random () & BIG_CHAR;
if (o == c)
o = (c + 1) & BIG_CHAR;
j = len + align + 128;
if (j > size)
j = size;
if (align >= 128)
k = align - 128;
else
k = 0;
for (i = k; i < align; ++i)
p[i] = o;
for (i = align + len; i < j; ++i)
p[i] = o;
FOR_EACH_IMPL (impl, 1)
{
for (i = 0; i < len; ++i)
{
p[i + align] = p2[i];
if (p[i + align] == c)
p[i + align] = o;
}
res = (UCHAR *) CALL (impl, (CHAR *) p + align, c, len);
if (res != p + align)
{
error (0, 0, "Iteration %zd - wrong result in function %s (%zd, %d, %zd) %p != %p",
n, impl->name, align, c, len, res, p + align);
ret = 1;
}
for (i = k; i < align; ++i)
if (p[i] != o)
{
error (0, 0, "Iteration %zd - garbage before %s (%zd, %d, %zd)",
n, impl->name, align, c, len);
ret = 1;
break;
}
for (; i < align + len; ++i)
if (p[i] != c)
{
error (0, 0, "Iteration %zd - not cleared correctly %s (%zd, %d, %zd)",
n, impl->name, align, c, len);
ret = 1;
break;
}
for (; i < j; ++i)
if (p[i] != o)
{
error (0, 0, "Iteration %zd - garbage after %s (%zd, %d, %zd)",
n, impl->name, align, c, len);
ret = 1;
break;
}
}
}
}
#endif /* !TEST_BZERO */
int
test_main (void)
{
size_t i;
int c = 0;
test_init ();
printf ("%24s", "");
FOR_EACH_IMPL (impl, 0)
printf ("\t%s", impl->name);
putchar ('\n');
#ifndef TEST_BZERO
for (c = -65; c <= 130; c += 65)
#endif
{
for (i = 0; i < 18; ++i)
do_test (0, c, 1 << i);
for (i = 1; i < 64; ++i)
{
do_test (i, c, i);
do_test (4096 - i, c, i);
do_test (4095, c, i);
if (i & (i - 1))
do_test (0, c, i);
}
do_test (1, c, 14);
do_test (3, c, 1024);
do_test (4, c, 64);
do_test (2, c, 25);
}
#ifndef TEST_BZERO
do_random_tests ();
#endif
return ret;
}
#include <support/test-driver.c>