mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-11 13:50:06 +00:00
852d631207
Different than other architectures hppa-linux-gnu define different values
for ENOTSUP and EOPNOTSUPP, where the later is a Linux specific one.
This leads to tst-preadwritev{64}v2 tests failures:
$ ./testrun.sh misc/tst-preadvwritev2
error: tst-preadvwritev2-common.c:35: preadv2 failure did not set errno to ENOTSUP (223)
error: 1 test failures
The straightforward fix is to return the POSIX defined ENOTSUP on all
p{read,write}v{64}v2 implementations instead of Linux specific one.
Checked on x86_64-linux-gnu and the tst-preadwritev{64}v2 on
hppa-linux-gnu (although due the installed kernel on my testing system
the pwritev{64}v2 with an invalid flag still fails due a known kernel
issue [1]).
[BZ #21780]
* sysdeps/posix/preadv2.c (preadv2): Use ENOTSUP instead of
EOPNOTSUPP.
* sysdeps/posix/preadv64v2.c (preadv64v2): Likewise.
* sysdeps/posix/pwritev2.c (pwritev2): Likewise.
* sysdeps/posix/pwritev64v2.c (pwritev64v2): Likewise.
* sysdeps/unix/sysv/linux/preadv2.c (preadv2): Likewise.
* sysdeps/unix/sysv/linux/preadv64v2.c (preadv64v2): Likewise.
* sysdeps/unix/sysv/linux/pwritev2.c (pwritev2): Likewise.
* sysdeps/unix/sysv/linux/pwritev64v2.c (pwritev64v2): Likewise.
[1] https://sourceware.org/ml/libc-alpha/2017-06/msg00726.html
52 lines
1.7 KiB
C
52 lines
1.7 KiB
C
/* Linux implementation of pwritev2.
|
|
Copyright (C) 2017 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <sys/uio.h>
|
|
#include <sysdep-cancel.h>
|
|
|
|
#ifndef __OFF_T_MATCHES_OFF64_T
|
|
|
|
ssize_t
|
|
pwritev2 (int fd, const struct iovec *vector, int count, off_t offset,
|
|
int flags)
|
|
{
|
|
# ifdef __NR_pwritev2
|
|
ssize_t result = SYSCALL_CANCEL (pwritev2, fd, vector, count,
|
|
LO_HI_LONG (offset), flags);
|
|
if (result >= 0)
|
|
return result;
|
|
# endif
|
|
/* Trying to emulate the pwritev2 syscall flags is troublesome:
|
|
|
|
* We can not temporary change the file state of the O_DSYNC and O_SYNC
|
|
flags to emulate RWF_{D}SYNC (attempts to change the state of using
|
|
fcntl are silently ignored).
|
|
|
|
* IOCB_HIPRI requires the file opened in O_DIRECT and uses an internal
|
|
semantic not provided by any other flag (O_NONBLOCK for instance). */
|
|
|
|
if (flags != 0)
|
|
{
|
|
__set_errno (ENOTSUP);
|
|
return -1;
|
|
}
|
|
return pwritev (fd, vector, count, offset);
|
|
}
|
|
|
|
#endif
|