mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-25 14:30:06 +00:00
2cc7bad0ae
C99 specifies that the EOF condition on a file is "sticky": once EOF has been encountered, all subsequent reads should continue to return EOF until the file is closed or something clears the "end-of-file indicator" (e.g. fseek, clearerr). This is arguably a change from C89, where the wording was ambiguous; the BSDs always had sticky EOF, but the System V lineage would attempt to read from the underlying fd again. GNU libc has followed System V for as long as we've been using libio, but nowadays C99 conformance and BSD compatibility are more important than System V compatibility. You might wonder if changing the _underflow impls is sufficient to apply the C99 semantics to all of the many stdio functions that perform input. It should be enough to cover all paths to _IO_SYSREAD, and the only other functions that call _IO_SYSREAD are the _seekoff impls, which is OK because seeking clears EOF, and the _xsgetn impls, which, as far as I can tell, are unused within glibc. The test programs in this patch use a pseudoterminal to set up the necessary conditions. To facilitate this I added a new test-support function that sets up a pair of pty file descriptors for you; it's almost the same as BSD openpty, the only differences are that it allocates the optionally-returned tty pathname with malloc, and that it crashes if anything goes wrong. [BZ #1190] [BZ #19476] * libio/fileops.c (_IO_new_file_underflow): Return EOF immediately if the _IO_EOF_SEEN bit is already set; update commentary. * libio/oldfileops.c (_IO_old_file_underflow): Likewise. * libio/wfileops.c (_IO_wfile_underflow): Likewise. * support/support_openpty.c, support/tty.h: New files. * support/Makefile (libsupport-routines): Add support_openpty. * libio/tst-fgetc-after-eof.c, wcsmbs/test-fgetwc-after-eof.c: New test cases. * libio/Makefile (tests): Add tst-fgetc-after-eof. * wcsmbs/Makefile (tests): Add tst-fgetwc-after-eof.
173 lines
4.1 KiB
Makefile
173 lines
4.1 KiB
Makefile
# Makefile for support library, used only at build and test time
|
|
# Copyright (C) 2016-2018 Free Software Foundation, Inc.
|
|
# This file is part of the GNU C Library.
|
|
|
|
# The GNU C Library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2.1 of the License, or (at your option) any later version.
|
|
|
|
# The GNU C Library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with the GNU C Library; if not, see
|
|
# <http://www.gnu.org/licenses/>.
|
|
|
|
subdir := support
|
|
|
|
include ../Makeconfig
|
|
|
|
extra-libs := libsupport
|
|
extra-libs-others = $(extra-libs)
|
|
extra-libs-noinstall := $(extra-libs)
|
|
|
|
libsupport-routines = \
|
|
check \
|
|
check_addrinfo \
|
|
check_dns_packet \
|
|
check_hostent \
|
|
check_netent \
|
|
delayed_exit \
|
|
ignore_stderr \
|
|
next_to_fault \
|
|
oom_error \
|
|
resolv_test \
|
|
set_fortify_handler \
|
|
support-xfstat \
|
|
support-xstat \
|
|
support_become_root \
|
|
support_can_chroot \
|
|
support_capture_subprocess \
|
|
support_capture_subprocess_check \
|
|
support_chroot \
|
|
support_enter_mount_namespace \
|
|
support_enter_network_namespace \
|
|
support_format_address_family \
|
|
support_format_addrinfo \
|
|
support_format_dns_packet \
|
|
support_format_herrno \
|
|
support_format_hostent \
|
|
support_format_netent \
|
|
support_isolate_in_subprocess \
|
|
support_openpty \
|
|
support_record_failure \
|
|
support_run_diff \
|
|
support_shared_allocate \
|
|
support_test_compare_failure \
|
|
support_write_file_string \
|
|
support_test_main \
|
|
support_test_verify_impl \
|
|
temp_file \
|
|
write_message \
|
|
xaccept \
|
|
xaccept4 \
|
|
xasprintf \
|
|
xbind \
|
|
xcalloc \
|
|
xchroot \
|
|
xclose \
|
|
xconnect \
|
|
xdlfcn \
|
|
xdup2 \
|
|
xfclose \
|
|
xfopen \
|
|
xfork \
|
|
xftruncate \
|
|
xgetsockname \
|
|
xlisten \
|
|
xlseek \
|
|
xmalloc \
|
|
xmemstream \
|
|
xmkdir \
|
|
xmmap \
|
|
xmprotect \
|
|
xmunmap \
|
|
xopen \
|
|
xpipe \
|
|
xpoll \
|
|
xpthread_attr_destroy \
|
|
xpthread_attr_init \
|
|
xpthread_attr_setdetachstate \
|
|
xpthread_attr_setguardsize \
|
|
xpthread_attr_setstacksize \
|
|
xpthread_barrier_destroy \
|
|
xpthread_barrier_init \
|
|
xpthread_barrier_wait \
|
|
xpthread_cancel \
|
|
xpthread_check_return \
|
|
xpthread_cond_wait \
|
|
xpthread_create \
|
|
xpthread_detach \
|
|
xpthread_join \
|
|
xpthread_mutex_consistent \
|
|
xpthread_mutex_destroy \
|
|
xpthread_mutex_init \
|
|
xpthread_mutex_lock \
|
|
xpthread_mutex_unlock \
|
|
xpthread_mutexattr_destroy \
|
|
xpthread_mutexattr_init \
|
|
xpthread_mutexattr_setprotocol \
|
|
xpthread_mutexattr_setpshared \
|
|
xpthread_mutexattr_setrobust \
|
|
xpthread_mutexattr_settype \
|
|
xpthread_once \
|
|
xpthread_rwlock_init \
|
|
xpthread_rwlock_rdlock \
|
|
xpthread_rwlock_unlock \
|
|
xpthread_rwlock_wrlock \
|
|
xpthread_rwlockattr_init \
|
|
xpthread_rwlockattr_setkind_np \
|
|
xpthread_sigmask \
|
|
xpthread_spin_lock \
|
|
xpthread_spin_unlock \
|
|
xraise \
|
|
xreadlink \
|
|
xrealloc \
|
|
xrecvfrom \
|
|
xsendto \
|
|
xsetsockopt \
|
|
xsigaction \
|
|
xsignal \
|
|
xsocket \
|
|
xstrdup \
|
|
xstrndup \
|
|
xsysconf \
|
|
xunlink \
|
|
xwaitpid \
|
|
xwrite \
|
|
|
|
libsupport-static-only-routines := $(libsupport-routines)
|
|
# Only build one variant of the library.
|
|
libsupport-inhibit-o := .os
|
|
ifeq ($(build-shared),yes)
|
|
libsupport-inhibit-o += .o
|
|
endif
|
|
|
|
tests = \
|
|
README-testing \
|
|
tst-support-namespace \
|
|
tst-support_capture_subprocess \
|
|
tst-support_format_dns_packet \
|
|
tst-support_record_failure \
|
|
tst-test_compare \
|
|
tst-xreadlink \
|
|
|
|
ifeq ($(run-built-tests),yes)
|
|
tests-special = \
|
|
$(objpfx)tst-support_record_failure-2.out
|
|
|
|
$(objpfx)tst-support_record_failure-2.out: tst-support_record_failure-2.sh \
|
|
$(objpfx)tst-support_record_failure
|
|
$(SHELL) $< $(common-objpfx) '$(test-program-prefix-before-env)' \
|
|
'$(run-program-env)' '$(test-program-prefix-after-env)' \
|
|
> $@; \
|
|
$(evaluate-test)
|
|
endif
|
|
|
|
$(objpfx)tst-support_format_dns_packet: $(common-objpfx)resolv/libresolv.so
|
|
|
|
include ../Rules
|