mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-11 13:50:06 +00:00
c579f48edb
This patch remove the PID cache and usage in current GLIBC code. Current
usage is mainly used a performance optimization to avoid the syscall,
however it adds some issues:
- The exposed clone syscall will try to set pid/tid to make the new
thread somewhat compatible with current GLIBC assumptions. This cause
a set of issue with new workloads and usecases (such as BZ#17214 and
[1]) as well for new internal usage of clone to optimize other algorithms
(such as clone plus CLONE_VM for posix_spawn, BZ#19957).
- The caching complexity also added some bugs in the past [2] [3] and
requires more effort of each port to handle such requirements (for
both clone and vfork implementation).
- Caching performance gain in mainly on getpid and some specific
code paths. The getpid performance leverage is questionable [4],
either by the idea of getpid being a hotspot as for the getpid
implementation itself (if it is indeed a justifiable hotspot a
vDSO symbol could let to a much more simpler solution).
Other usage is mainly for non usual code paths, such as pthread
cancellation signal and handling.
For thread creation (on stack allocation) the code simplification in fact
adds some performance gain due the no need of transverse the stack cache
and invalidate each element pid.
Other thread usages will require a direct getpid syscall, such as
cancellation/setxid signal, thread cancellation, thread fail path (at
create_thread), and thread signal (pthread_kill and pthread_sigqueue).
However these are hardly usual hotspots and I think adding a syscall is
justifiable.
It also simplifies both the clone and vfork arch-specific implementation.
And by review each fork implementation there are some discrepancies that
this patch also solves:
- microblaze clone/vfork does not set/reset the pid/tid field
- hppa uses the default vfork implementation that fallback to fork.
Since vfork is deprecated I do not think we should bother with it.
The patch also removes the TID caching in clone. My understanding for
such semantic is try provide some pthread usage after a user program
issue clone directly (as done by thread creation with CLONE_PARENT_SETTID
and pthread tid member). However, as stated before in multiple discussions
threads, GLIBC provides clone syscalls without further supporting all this
semantics.
I ran a full make check on x86_64, x32, i686, armhf, aarch64, and powerpc64le.
For sparc32, sparc64, and mips I ran the basic fork and vfork tests from
posix/ folder (on a qemu system). So it would require further testing
on alpha, hppa, ia64, m68k, nios2, s390, sh, and tile (I excluded microblaze
because it is already implementing the patch semantic regarding clone/vfork).
[1] https://codereview.chromium.org/800183004/
[2] https://sourceware.org/ml/libc-alpha/2006-07/msg00123.html
[3] https://sourceware.org/bugzilla/show_bug.cgi?id=15368
[4] http://yarchive.net/comp/linux/getpid_caching.html
* sysdeps/nptl/fork.c (__libc_fork): Remove pid cache setting.
* nptl/allocatestack.c (allocate_stack): Likewise.
(__reclaim_stacks): Likewise.
(setxid_signal_thread): Obtain pid through syscall.
* nptl/nptl-init.c (sigcancel_handler): Likewise.
(sighandle_setxid): Likewise.
* nptl/pthread_cancel.c (pthread_cancel): Likewise.
* sysdeps/unix/sysv/linux/pthread_kill.c (__pthread_kill): Likewise.
* sysdeps/unix/sysv/linux/pthread_sigqueue.c (pthread_sigqueue):
Likewise.
* sysdeps/unix/sysv/linux/createthread.c (create_thread): Likewise.
* sysdeps/unix/sysv/linux/getpid.c: Remove file.
* nptl/descr.h (struct pthread): Change comment about pid value.
* nptl/pthread_getattr_np.c (pthread_getattr_np): Remove thread
pid assert.
* sysdeps/unix/sysv/linux/pthread-pids.h (__pthread_initialize_pids):
Do not set pid value.
* nptl_db/td_ta_thr_iter.c (iterate_thread_list): Remove thread
pid cache check.
* nptl_db/td_thr_validate.c (td_thr_validate): Likewise.
* sysdeps/aarch64/nptl/tcb-offsets.sym: Remove pid offset.
* sysdeps/alpha/nptl/tcb-offsets.sym: Likewise.
* sysdeps/arm/nptl/tcb-offsets.sym: Likewise.
* sysdeps/hppa/nptl/tcb-offsets.sym: Likewise.
* sysdeps/i386/nptl/tcb-offsets.sym: Likewise.
* sysdeps/ia64/nptl/tcb-offsets.sym: Likewise.
* sysdeps/m68k/nptl/tcb-offsets.sym: Likewise.
* sysdeps/microblaze/nptl/tcb-offsets.sym: Likewise.
* sysdeps/mips/nptl/tcb-offsets.sym: Likewise.
* sysdeps/nios2/nptl/tcb-offsets.sym: Likewise.
* sysdeps/powerpc/nptl/tcb-offsets.sym: Likewise.
* sysdeps/s390/nptl/tcb-offsets.sym: Likewise.
* sysdeps/sh/nptl/tcb-offsets.sym: Likewise.
* sysdeps/sparc/nptl/tcb-offsets.sym: Likewise.
* sysdeps/tile/nptl/tcb-offsets.sym: Likewise.
* sysdeps/x86_64/nptl/tcb-offsets.sym: Likewise.
* sysdeps/unix/sysv/linux/aarch64/clone.S: Remove pid and tid caching.
* sysdeps/unix/sysv/linux/alpha/clone.S: Likewise.
* sysdeps/unix/sysv/linux/arm/clone.S: Likewise.
* sysdeps/unix/sysv/linux/hppa/clone.S: Likewise.
* sysdeps/unix/sysv/linux/i386/clone.S: Likewise.
* sysdeps/unix/sysv/linux/ia64/clone2.S: Likewise.
* sysdeps/unix/sysv/linux/mips/clone.S: Likewise.
* sysdeps/unix/sysv/linux/nios2/clone.S: Likewise.
* sysdeps/unix/sysv/linux/powerpc/powerpc32/clone.S: Likewise.
* sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S: Likewise.
* sysdeps/unix/sysv/linux/s390/s390-32/clone.S: Likewise.
* sysdeps/unix/sysv/linux/s390/s390-64/clone.S: Likewise.
* sysdeps/unix/sysv/linux/sh/clone.S: Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc32/clone.S: Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc64/clone.S: Likewise.
* sysdeps/unix/sysv/linux/tile/clone.S: Likewise.
* sysdeps/unix/sysv/linux/x86_64/clone.S: Likewise.
* sysdeps/unix/sysv/linux/aarch64/vfork.S: Remove pid set and reset.
* sysdeps/unix/sysv/linux/alpha/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/arm/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/i386/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/ia64/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/m68k/clone.S: Likewise.
* sysdeps/unix/sysv/linux/m68k/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/mips/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/nios2/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/powerpc/powerpc32/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/powerpc/powerpc64/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/s390/s390-32/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/s390/s390-64/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/sh/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc32/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc64/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/tile/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/x86_64/vfork.S: Likewise.
* sysdeps/unix/sysv/linux/tst-clone2.c (f): Remove direct pthread
struct access.
(clone_test): Remove function.
(do_test): Rewrite to take in consideration pid is not cached anymore.
126 lines
5.4 KiB
Plaintext
126 lines
5.4 KiB
Plaintext
# File name Caller Syscall name Args Strong name Weak names
|
|
|
|
adjtimex adjtime adjtimex i:p __adjtimex adjtimex ntp_adjtime
|
|
alarm - alarm i:i alarm
|
|
bdflush EXTRA bdflush i:ii __compat_bdflush bdflush@GLIBC_2.0:GLIBC_2.23
|
|
capget EXTRA capget i:pp capget
|
|
capset EXTRA capset i:pp capset
|
|
clock_adjtime EXTRA clock_adjtime i:ip clock_adjtime
|
|
creat - creat Ci:si creat
|
|
create_module EXTRA create_module 3 __compat_create_module create_module@GLIBC_2.0:GLIBC_2.23
|
|
delete_module EXTRA delete_module 3 delete_module
|
|
epoll_create EXTRA epoll_create i:i epoll_create
|
|
epoll_create1 EXTRA epoll_create1 i:i epoll_create1
|
|
epoll_ctl EXTRA epoll_ctl i:iiip epoll_ctl
|
|
epoll_wait EXTRA epoll_wait Ci:ipii epoll_wait
|
|
eventfd EXTRA eventfd2 i:ii eventfd
|
|
execve - execve i:spp __execve execve
|
|
fdatasync - fdatasync Ci:i fdatasync
|
|
flock - flock i:ii __flock flock
|
|
get_kernel_syms EXTRA get_kernel_syms i:p __compat_get_kernel_syms get_kernel_syms@GLIBC_2.0:GLIBC_2.23
|
|
getpid - getpid Ei: __getpid getpid
|
|
getegid - getegid Ei: __getegid getegid
|
|
geteuid - geteuid Ei: __geteuid geteuid
|
|
getpgid - getpgid i:i __getpgid getpgid
|
|
getpgrp - getpgrp Ei: getpgrp
|
|
getpmsg - getpmsg i:ipppp getpmsg
|
|
getppid - getppid Ei: __getppid getppid
|
|
getresuid - getresuid i:ppp getresuid
|
|
getresgid - getresgid i:ppp getresgid
|
|
getsid - getsid i:i getsid
|
|
init_module EXTRA init_module 5 init_module
|
|
inotify_add_watch EXTRA inotify_add_watch i:isi inotify_add_watch
|
|
inotify_init EXTRA inotify_init i: inotify_init
|
|
inotify_init1 EXTRA inotify_init1 i:I inotify_init1
|
|
inotify_rm_watch EXTRA inotify_rm_watch i:ii inotify_rm_watch
|
|
ioperm - ioperm i:iii ioperm
|
|
iopl - iopl i:i iopl
|
|
klogctl EXTRA syslog i:isi klogctl
|
|
lchown - lchown i:sii __lchown lchown
|
|
mincore - mincore i:anV mincore
|
|
mlock - mlock i:bn mlock
|
|
mlockall - mlockall i:i mlockall
|
|
mount EXTRA mount i:sssip __mount mount
|
|
mremap EXTRA mremap b:ainip __mremap mremap
|
|
munlock - munlock i:ai munlock
|
|
munlockall - munlockall i: munlockall
|
|
nanosleep - nanosleep Ci:pp __nanosleep nanosleep
|
|
nfsservctl EXTRA nfsservctl i:ipp nfsservctl
|
|
pause - pause Ci: __libc_pause pause
|
|
pipe - pipe i:f __pipe pipe
|
|
pipe2 - pipe2 i:fi __pipe2 pipe2
|
|
pivot_root EXTRA pivot_root i:ss pivot_root
|
|
poll - poll Ci:pii __libc_poll __poll poll
|
|
prctl EXTRA prctl i:iiiii __prctl prctl
|
|
putpmsg - putpmsg i:ippii putpmsg
|
|
query_module EXTRA query_module i:sipip __compat_query_module query_module@GLIBC_2.0:GLIBC_2.23
|
|
quotactl EXTRA quotactl i:isip quotactl
|
|
remap_file_pages - remap_file_pages i:piiii __remap_file_pages remap_file_pages
|
|
sched_getp - sched_getparam i:ip __sched_getparam sched_getparam
|
|
sched_gets - sched_getscheduler i:i __sched_getscheduler sched_getscheduler
|
|
sched_primax - sched_get_priority_max i:i __sched_get_priority_max sched_get_priority_max
|
|
sched_primin - sched_get_priority_min i:i __sched_get_priority_min sched_get_priority_min
|
|
sched_rr_gi - sched_rr_get_interval i:ip __sched_rr_get_interval sched_rr_get_interval
|
|
sched_setp - sched_setparam i:ip __sched_setparam sched_setparam
|
|
sched_sets - sched_setscheduler i:iip __sched_setscheduler sched_setscheduler
|
|
sched_yield - sched_yield i: __sched_yield sched_yield
|
|
select - _newselect Ci:iPPPP __select __libc_select select
|
|
sendfile - sendfile i:iipi sendfile
|
|
sendfile64 - sendfile64 i:iipi sendfile64
|
|
setfsgid EXTRA setfsgid i:i setfsgid
|
|
setfsuid EXTRA setfsuid i:i setfsuid
|
|
setpgid - setpgid i:ii __setpgid setpgid
|
|
sigaltstack - sigaltstack i:PP __sigaltstack sigaltstack
|
|
splice EXTRA splice Ci:iPiPii splice
|
|
stime - stime i:p stime
|
|
sysinfo EXTRA sysinfo i:p __sysinfo sysinfo
|
|
swapon - swapon i:si __swapon swapon
|
|
swapoff - swapoff i:s __swapoff swapoff
|
|
tee EXTRA tee Ci:iiii tee
|
|
unshare EXTRA unshare i:i unshare
|
|
uselib EXTRA uselib i:s __compat_uselib uselib@GLIBC_2.0:GLIBC_2.23
|
|
utime - utime i:sP utime
|
|
vmsplice EXTRA vmsplice Ci:iPii vmsplice
|
|
wait4 - wait4 i:iWiP __wait4 wait4
|
|
|
|
chown - chown i:sii __libc_chown __chown chown
|
|
|
|
fchownat - fchownat i:isiii fchownat
|
|
linkat - linkat i:isisi linkat
|
|
mkdirat - mkdirat i:isi mkdirat
|
|
readlinkat - readlinkat i:issi readlinkat
|
|
renameat - renameat i:isis renameat
|
|
symlinkat - symlinkat i:sis symlinkat
|
|
unlinkat - unlinkat i:isi unlinkat
|
|
|
|
setxattr - setxattr i:sspii setxattr
|
|
lsetxattr - lsetxattr i:sspii lsetxattr
|
|
fsetxattr - fsetxattr i:ispii fsetxattr
|
|
getxattr - getxattr i:sspi getxattr
|
|
lgetxattr - lgetxattr i:sspi lgetxattr
|
|
fgetxattr - fgetxattr i:ispi fgetxattr
|
|
listxattr - listxattr i:ssi listxattr
|
|
llistxattr - llistxattr i:ssi llistxattr
|
|
flistxattr - flistxattr i:isi flistxattr
|
|
removexattr - removexattr i:ss removexattr
|
|
lremovexattr - lremovexattr i:ss lremovexattr
|
|
fremovexattr - fremovexattr i:is fremovexattr
|
|
|
|
mq_timedsend - mq_timedsend Ci:ipiip __mq_timedsend mq_timedsend
|
|
mq_timedreceive - mq_timedreceive Ci:ipipp __mq_timedreceive mq_timedreceive
|
|
mq_setattr - mq_getsetattr i:ipp mq_setattr
|
|
|
|
timerfd_create EXTRA timerfd_create i:ii timerfd_create
|
|
timerfd_settime EXTRA timerfd_settime i:iipp timerfd_settime
|
|
timerfd_gettime EXTRA timerfd_gettime i:ip timerfd_gettime
|
|
|
|
fanotify_init EXTRA fanotify_init i:ii fanotify_init
|
|
|
|
name_to_handle_at EXTRA name_to_handle_at i:isppi name_to_handle_at
|
|
open_by_handle_at EXTRA open_by_handle_at Ci:ipi open_by_handle_at
|
|
|
|
setns EXTRA setns i:ii setns
|
|
|
|
process_vm_readv EXTRA process_vm_readv i:ipipii process_vm_readv
|
|
process_vm_writev EXTRA process_vm_writev i:ipipii process_vm_writev
|