mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-25 20:21:07 +00:00
9ff72da471
This patch implements a new posix_spawn{p} implementation for Linux. The main difference is it uses the clone syscall directly with CLONE_VM and CLONE_VFORK flags and a direct allocated stack. The new stack and start function solves most the vfork limitation (possible parent clobber due stack spilling). The remaning issue are related to signal handling: 1. That no signal handlers must run in child context, to avoid corrupt parent's state. 2. Child must synchronize with parent to enforce stack deallocation and to possible return execv issues. The first one is solved by blocking all signals in child, even NPTL-internal ones (SIGCANCEL and SIGSETXID). The second issue is done by a stack allocation in parent and a synchronization with using a pipe or waitpid (in case or error). The pipe has the advantage of allowing the child signal an exec error (checked with new tst-spawn2 test). There is an inherent race condition in pipe2 usage for architectures that do not support the syscall directly. In such cases the a pipe plus fctnl is used instead and it may lead to file descriptor leak in parent (as decribed by fcntl documentation). The child process stack is allocate with a mmap with MAP_STACK flag using default architecture stack size. Although it is slower than use a stack buffer from parent, it allows some slack for the compatibility code to run scripts with no shebang (which may use a buffer with size depending of argument list count). Performance should be similar to the vfork default posix implementation and way faster than fork path (vfork on mostly linux ports are basically clone with CLONE_VM plus CLONE_VFORK). The only difference is the syscalls required for the stack allocation/deallocation. It fixes BZ#10354, BZ#14750, and BZ#18433. Tested on i386, x86_64, powerpc64le, and aarch64. [BZ #14750] [BZ #10354] [BZ #18433] * include/sched.h (__clone): Add hidden prototype. (__clone2): Likewise. * include/unistd.h (__dup): Likewise. * posix/Makefile (tests): Add tst-spawn2. * posix/tst-spawn2.c: New file. * sysdeps/posix/dup.c (__dup): Add hidden definition. * sysdeps/unix/sysv/linux/aarch64/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/alpha/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/hppa/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/i386/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/ia64/clone2.S (__clone): Likewise. * sysdeps/unix/sysv/linux/m68k/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/microblaze/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/mips/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/nios2/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/sh/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/tile/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/x86_64/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/nptl-signals.h (____nptl_is_internal_signal): New function. * sysdeps/unix/sysv/linux/spawni.c: New file.
180 lines
4.9 KiB
ArmAsm
180 lines
4.9 KiB
ArmAsm
/* Copyright (C) 1996-2016 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by David Huggins-Daines <dhd@debian.org>, 2000.
|
|
Based on the Alpha version by Richard Henderson <rth@tamu.edu>, 1996.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library. If not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
/* clone() is even more special than fork() as it mucks with stacks
|
|
and invokes a function in the right context after its all over. */
|
|
|
|
#include <asm/unistd.h>
|
|
#include <sysdep.h>
|
|
#define _ERRNO_H 1
|
|
#include <bits/errno.h>
|
|
#include <tcb-offsets.h>
|
|
|
|
/* Non-thread code calls __clone with the following parameters:
|
|
int clone(int (*fn)(void *arg),
|
|
void *child_stack,
|
|
int flags,
|
|
void *arg)
|
|
|
|
NPTL Code will call __clone with the following parameters:
|
|
int clone(int (*fn)(void *arg),
|
|
void *child_stack,
|
|
int flags,
|
|
void *arg,
|
|
int *parent_tidptr,
|
|
struct user_desc *newtls,
|
|
int *child_pidptr)
|
|
|
|
The code should not mangle the extra input registers.
|
|
Syscall expects: Input to __clone:
|
|
4(r25) - function pointer (r26, arg0)
|
|
0(r25) - argument (r23, arg3)
|
|
r26 - clone flags. (r24, arg2)
|
|
r25+64 - user stack pointer. (r25, arg1)
|
|
r24 - parent tid pointer. (stack - 52)
|
|
r23 - struct user_desc newtls pointer. (stack - 56)
|
|
r22 - child tid pointer. (stack - 60)
|
|
r20 - clone syscall number (constant)
|
|
|
|
Return:
|
|
|
|
On success the thread ID of the child process is returend in
|
|
the callers context.
|
|
On error return -1, and set errno to the value returned by
|
|
the syscall.
|
|
*/
|
|
|
|
.text
|
|
ENTRY(__clone)
|
|
/* Prologue */
|
|
stwm %r4, 64(%sp)
|
|
stw %sp, -4(%sp)
|
|
#ifdef PIC
|
|
stw %r19, -32(%sp)
|
|
#endif
|
|
|
|
/* Sanity check arguments. */
|
|
comib,=,n 0, %arg0, .LerrorSanity /* no NULL function pointers */
|
|
comib,=,n 0, %arg1, .LerrorSanity /* no NULL stack pointers */
|
|
|
|
/* Save the function pointer, arg, and flags on the new stack. */
|
|
stwm %r26, 64(%r25)
|
|
stw %r23, -60(%r25)
|
|
stw %r24, -56(%r25)
|
|
/* Clone arguments are (int flags, void * child_stack) */
|
|
copy %r24, %r26 /* flags are first */
|
|
/* User stack pointer is in the correct register already */
|
|
|
|
/* Load args from stack... */
|
|
ldw -116(%sp), %r24 /* Load parent_tidptr */
|
|
ldw -120(%sp), %r23 /* Load newtls */
|
|
ldw -124(%sp), %r22 /* Load child_tidptr */
|
|
|
|
/* Save the PIC register. */
|
|
#ifdef PIC
|
|
copy %r19, %r4 /* parent */
|
|
#endif
|
|
|
|
/* Do the system call */
|
|
ble 0x100(%sr2, %r0)
|
|
ldi __NR_clone, %r20
|
|
|
|
ldi -4096, %r1
|
|
comclr,>>= %r1, %ret0, %r0 /* Note: unsigned compare. */
|
|
b,n .LerrorRest
|
|
|
|
/* Restore the PIC register. */
|
|
#ifdef PIC
|
|
copy %r4, %r19 /* parent */
|
|
#endif
|
|
|
|
comib,=,n 0, %ret0, .LthreadStart
|
|
|
|
/* Successful return from the parent
|
|
No need to restore the PIC register,
|
|
since we return immediately. */
|
|
|
|
ldw -84(%sp), %rp
|
|
bv %r0(%rp)
|
|
ldwm -64(%sp), %r4
|
|
|
|
.LerrorRest:
|
|
/* Something bad happened -- no child created */
|
|
bl __syscall_error, %rp
|
|
sub %r0, %ret0, %arg0
|
|
ldw -84(%sp), %rp
|
|
/* Return after setting errno, ret0 is set to -1 by __syscall_error. */
|
|
bv %r0(%rp)
|
|
ldwm -64(%sp), %r4
|
|
|
|
.LerrorSanity:
|
|
/* Sanity checks failed, return -1, and set errno to EINVAL. */
|
|
bl __syscall_error, %rp
|
|
ldi EINVAL, %arg0
|
|
ldw -84(%sp), %rp
|
|
bv %r0(%rp)
|
|
ldwm -64(%sp), %r4
|
|
|
|
.LthreadStart:
|
|
# define CLONE_VM_BIT 23 /* 0x00000100 */
|
|
# define CLONE_THREAD_BIT 15 /* 0x00010000 */
|
|
/* Load original clone flags.
|
|
If CLONE_THREAD was passed, don't reset the PID/TID.
|
|
If CLONE_VM was passed, we need to store -1 to PID/TID.
|
|
If CLONE_VM and CLONE_THREAD were not set store the result
|
|
of getpid to PID/TID. */
|
|
ldw -56(%sp), %r26
|
|
bb,<,n %r26, CLONE_THREAD_BIT, 1f
|
|
bb,< %r26, CLONE_VM_BIT, 2f
|
|
ldi -1, %ret0
|
|
ble 0x100(%sr2, %r0)
|
|
ldi __NR_getpid, %r20
|
|
2:
|
|
mfctl %cr27, %r26
|
|
stw %ret0, PID_THREAD_OFFSET(%r26)
|
|
stw %ret0, TID_THREAD_OFFSET(%r26)
|
|
1:
|
|
/* Load up the arguments. */
|
|
ldw -60(%sp), %arg0
|
|
ldw -64(%sp), %r22
|
|
|
|
/* $$dyncall fixes child's PIC register */
|
|
|
|
/* Call the user's function */
|
|
#ifdef PIC
|
|
copy %r19, %r4
|
|
#endif
|
|
bl $$dyncall, %r31
|
|
copy %r31, %rp
|
|
#ifdef PIC
|
|
copy %r4, %r19
|
|
#endif
|
|
/* The call to _exit needs saved r19. */
|
|
bl _exit, %rp
|
|
copy %ret0, %arg0
|
|
|
|
/* We should not return from _exit.
|
|
We do not restore r4, or the stack state. */
|
|
iitlbp %r0, (%sr0, %r0)
|
|
|
|
PSEUDO_END(__clone)
|
|
|
|
libc_hidden_def (__clone)
|
|
weak_alias (__clone, clone)
|