mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-22 13:00:06 +00:00
5c112f1b62
Various glibc testcases use tmpnam in ways subject to race conditions (generate a temporary file name, then later open that file without O_EXCL). This patch fixes those tests to use mkstemp - generally a minimal local fix to use mkstemp instead of tmpnam, rather than a larger fix to use other testsuite infrastructure for temporary files. The unchanged use of tmpnam in posix/wordexp-test.c would fail safe in the event of a race (it's generating a name for use with mkdir rather than for a file to be opened for writing). Tested for x86_64. * grp/tst_fgetgrent.c: Include <unistd.h>. (main): Use mkstemp instead of tmpnam. * io/test-utime.c (main): Likewise. * posix/annexc.c (macrofile): Change to modifiable array. (get_null_defines): Use mkstemp instead of tmpnam. Do not remove macrofile here. * posix/bug-getopt1.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt2.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt3.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt4.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt5.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * stdio-common/bug7.c: Include <stdlib.h> and <unistd.h>. (main): Use mkstemp instead of tmpnam. * stdio-common/tst-fdopen.c: Include <stdlib.h>. (main): Use mkstemp instead of tmpnam. * stdio-common/tst-ungetc.c: Include <stdlib.h>. (main): use mkstemp instead of tmpnam. * stdlib/isomac.c (macrofile): Change to modifiable array. (get_null_defines): Use mkstemp instead of tmpnam. Do not remove macrofile here.
78 lines
1.4 KiB
C
78 lines
1.4 KiB
C
/* Regression test for fseek and freopen bugs. */
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
|
|
int
|
|
main (int argc, char *argv[])
|
|
{
|
|
int lose = 0;
|
|
char filename[] = "/tmp/bug7.XXXXXX";
|
|
FILE *fp;
|
|
|
|
int fd = mkstemp (filename);
|
|
if (fd == -1)
|
|
{
|
|
printf ("mkstemp failed\n");
|
|
lose = 1;
|
|
}
|
|
else
|
|
{
|
|
close (fd);
|
|
fp = fopen (filename, "w+");
|
|
fprintf (fp, "Hello world!\n");
|
|
fflush (fp);
|
|
fseek (fp, 5L, SEEK_SET);
|
|
if (fseek (fp, -1L, SEEK_CUR) < 0)
|
|
{
|
|
printf ("seek failed\n");
|
|
lose = 1;
|
|
}
|
|
fclose (fp);
|
|
remove (filename);
|
|
}
|
|
|
|
{
|
|
FILE *file1;
|
|
FILE *file2;
|
|
char filename1[] = "/tmp/bug7.XXXXXX";
|
|
char filename2[] = "/tmp/bug7.XXXXXX";
|
|
int ch;
|
|
|
|
int fd1 = mkstemp (filename1);
|
|
int fd2 = mkstemp (filename2);
|
|
if (fd1 == -1 || fd2 == -1)
|
|
{
|
|
printf ("mkstemp failed\n");
|
|
lose = 1;
|
|
}
|
|
else
|
|
{
|
|
close (fd1);
|
|
close (fd2);
|
|
|
|
file1 = fopen (filename1, "w");
|
|
fclose (file1);
|
|
|
|
file2 = fopen (filename2, "w");
|
|
fputc ('x', file2);
|
|
fclose (file2);
|
|
|
|
file1 = fopen (filename1, "r");
|
|
file2 = freopen (filename2, "r", file1);
|
|
if ((ch = fgetc (file2)) != 'x')
|
|
{
|
|
printf ("wrong character in reopened file, value = %d\n", ch);
|
|
lose = 1;
|
|
}
|
|
fclose (file2);
|
|
remove (filename1);
|
|
remove (filename2);
|
|
}
|
|
}
|
|
|
|
puts (lose ? "Test FAILED!" : "Test succeeded.");
|
|
return lose;
|
|
}
|