mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-21 20:40:05 +00:00
018f0fc3b8
It turns out that quite a few applications use bundled mallocs that have been built to use global-dynamic TLS (instead of the recommended initial-exec TLS). The previous workaround from commitafe42e935b("elf: Avoid some free (NULL) calls in _dl_update_slotinfo") does not fix all encountered cases unfortunatelly. This change avoids the TLS generation update for recursive use of TLS from a malloc that was called during a TLS update. This is possible because an interposed malloc has a fixed module ID and TLS slot. (It cannot be unloaded.) If an initially-loaded module ID is encountered in __tls_get_addr and the dynamic linker is already in the middle of a TLS update, use the outdated DTV, thus avoiding another call into malloc. It's still necessary to update the DTV to the most recent generation, to get out of the slow path, which is why the check for recursion is needed. The bookkeeping is done using a global counter instead of per-thread flag because TLS access in the dynamic linker is tricky. All this will go away once the dynamic linker stops using malloc for TLS, likely as part of a change that pre-allocates all TLS during pthread_create/dlopen. Fixes commitd2123d6827("elf: Fix slow tls access after dlopen [BZ #19924]"). Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
61 lines
2.0 KiB
C
61 lines
2.0 KiB
C
/* Test with interposed malloc with dynamic TLS.
|
|
Copyright (C) 2024 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <array_length.h>
|
|
#include <stdio.h>
|
|
#include <support/check.h>
|
|
#include <support/xdlfcn.h>
|
|
|
|
/* Defined in tst-recursive-tlsmallocmod.so. */
|
|
extern __thread unsigned int malloc_subsytem_counter;
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
/* 16 is large enough to exercise the DTV resizing case. */
|
|
void *handles[16];
|
|
|
|
for (unsigned int i = 0; i < array_length (handles); ++i)
|
|
{
|
|
/* Re-use the TLS slot for module 0. */
|
|
if (i > 0)
|
|
xdlclose (handles[0]);
|
|
|
|
char soname[30];
|
|
snprintf (soname, sizeof (soname), "tst-recursive-tlsmod%u.so", i);
|
|
handles[i] = xdlopen (soname, RTLD_NOW);
|
|
|
|
if (i > 0)
|
|
{
|
|
handles[0] = xdlopen ("tst-recursive-tlsmod0.so", RTLD_NOW);
|
|
int (*fptr) (void) = xdlsym (handles[0], "get_threadvar_0");
|
|
/* May trigger TLS storage allocation using malloc. */
|
|
TEST_COMPARE (fptr (), 0);
|
|
}
|
|
}
|
|
|
|
for (unsigned int i = 0; i < array_length (handles); ++i)
|
|
xdlclose (handles[i]);
|
|
|
|
printf ("info: malloc subsystem calls: %u\n", malloc_subsytem_counter);
|
|
TEST_VERIFY (malloc_subsytem_counter > 0);
|
|
return 0;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|