mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-09 23:00:07 +00:00
ce7eb0e903
This patch wraps all uses of *_{enable,disable}_asynccancel and
and *_CANCEL_{ASYNC,RESET} in either already provided macros
(lll_futex_timed_wait_cancel) or creates new ones if the
functionality is not provided (SYSCALL_CANCEL_NCS, lll_futex_wait_cancel,
and lll_futex_timed_wait_cancel).
Also for some generic implementations, the direct call of the macros
are removed since the underlying symbols are suppose to provide
cancellation support.
This is a priliminary patch intended to simplify the work required
for BZ#12683 fix. It is a refactor change, no semantic changes are
expected.
Checked on x86_64-linux-gnu and i686-linux-gnu.
* nptl/pthread_join_common.c (__pthread_timedjoin_ex): Use
lll_wait_tid with timeout.
* nptl/sem_wait.c (__old_sem_wait): Use lll_futex_wait_cancel.
* sysdeps/nptl/aio_misc.h (AIO_MISC_WAIT): Use
futex_reltimed_wait_cancelable for cancelabla mode.
* sysdeps/nptl/gai_misc.h (GAI_MISC_WAIT): Likewise.
* sysdeps/posix/open64.c (__libc_open64): Do not call cancelation
macros.
* sysdeps/posix/sigwait.c (__sigwait): Likewise.
* sysdeps/posix/waitid.c (__sigwait): Likewise.
* sysdeps/unix/sysdep.h (__SYSCALL_CANCEL_CALL,
SYSCALL_CANCEL_NCS): New macro.
* sysdeps/nptl/lowlevellock.h (lll_wait_tid): Add timeout argument.
(lll_timedwait_tid): Remove macro.
* sysdeps/unix/sysv/linux/i386/lowlevellock.h (lll_wait_tid):
Likewise.
(lll_timedwait_tid): Likewise.
* sysdeps/unix/sysv/linux/sparc/lowlevellock.h (lll_wait_tid):
Likewise.
(lll_timedwait_tid): Likewise.
* sysdeps/unix/sysv/linux/x86_64/lowlevellock.h (lll_wait_tid):
Likewise.
(lll_timedwait_tid): Likewise.
* sysdeps/unix/sysv/linux/clock_nanosleep.c (__clock_nanosleep):
Use INTERNAL_SYSCALL_CANCEL.
* sysdeps/unix/sysv/linux/futex-internal.h
(futex_reltimed_wait_cancelable): Use LIBC_CANCEL_{ASYNC,RESET}
instead of __pthread_{enable,disable}_asynccancel.
* sysdeps/unix/sysv/linux/lowlevellock-futex.h
(lll_futex_wait_cancel): New macro.
101 lines
3.1 KiB
C
101 lines
3.1 KiB
C
/* sem_wait -- wait on a semaphore. Generic futex-using version.
|
|
Copyright (C) 2003-2019 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Paul Mackerras <paulus@au.ibm.com>, 2003.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <lowlevellock.h> /* lll_futex* used by the old code. */
|
|
#include "sem_waitcommon.c"
|
|
|
|
int
|
|
__new_sem_wait (sem_t *sem)
|
|
{
|
|
/* We need to check whether we need to act upon a cancellation request here
|
|
because POSIX specifies that cancellation points "shall occur" in
|
|
sem_wait and sem_timedwait, which also means that they need to check
|
|
this regardless whether they block or not (unlike "may occur"
|
|
functions). See the POSIX Rationale for this requirement: Section
|
|
"Thread Cancellation Overview" [1] and austin group issue #1076 [2]
|
|
for thoughs on why this may be a suboptimal design.
|
|
|
|
[1] http://pubs.opengroup.org/onlinepubs/9699919799/xrat/V4_xsh_chap02.html
|
|
[2] http://austingroupbugs.net/view.php?id=1076 for thoughts on why this
|
|
*/
|
|
__pthread_testcancel ();
|
|
|
|
if (__new_sem_wait_fast ((struct new_sem *) sem, 0) == 0)
|
|
return 0;
|
|
else
|
|
return __new_sem_wait_slow((struct new_sem *) sem, NULL);
|
|
}
|
|
versioned_symbol (libpthread, __new_sem_wait, sem_wait, GLIBC_2_1);
|
|
|
|
#if SHLIB_COMPAT (libpthread, GLIBC_2_0, GLIBC_2_1)
|
|
int
|
|
attribute_compat_text_section
|
|
__old_sem_wait (sem_t *sem)
|
|
{
|
|
int *futex = (int *) sem;
|
|
int err;
|
|
|
|
do
|
|
{
|
|
if (atomic_decrement_if_positive (futex) > 0)
|
|
return 0;
|
|
|
|
/* Always assume the semaphore is shared. */
|
|
err = lll_futex_wait_cancel (futex, 0, LLL_SHARED);
|
|
}
|
|
while (err == 0 || err == -EWOULDBLOCK);
|
|
|
|
__set_errno (-err);
|
|
return -1;
|
|
}
|
|
|
|
compat_symbol (libpthread, __old_sem_wait, sem_wait, GLIBC_2_0);
|
|
#endif
|
|
|
|
int
|
|
__new_sem_trywait (sem_t *sem)
|
|
{
|
|
/* We must not fail spuriously, so require a definitive result even if this
|
|
may lead to a long execution time. */
|
|
if (__new_sem_wait_fast ((struct new_sem *) sem, 1) == 0)
|
|
return 0;
|
|
__set_errno (EAGAIN);
|
|
return -1;
|
|
}
|
|
versioned_symbol (libpthread, __new_sem_trywait, sem_trywait, GLIBC_2_1);
|
|
#if SHLIB_COMPAT (libpthread, GLIBC_2_0, GLIBC_2_1)
|
|
int
|
|
__old_sem_trywait (sem_t *sem)
|
|
{
|
|
int *futex = (int *) sem;
|
|
int val;
|
|
|
|
if (*futex > 0)
|
|
{
|
|
val = atomic_decrement_if_positive (futex);
|
|
if (val > 0)
|
|
return 0;
|
|
}
|
|
|
|
__set_errno (EAGAIN);
|
|
return -1;
|
|
}
|
|
compat_symbol (libpthread, __old_sem_trywait, sem_trywait, GLIBC_2_0);
|
|
#endif
|