mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-25 22:40:05 +00:00
3f823e87cc
On aarch64, alpha, arm, hppa, mips, nios2, powerpc, sh, sparc, tile, and x86_64 the clone syscall jumps to _exit after the child execution and the function ends the process execution by calling exit_group. This behavior have a small issue where threads created with CLONE_THREAD using clone syscall directly will eventually exit the whole group altogether instead of just the thread created. Also, s390, microblaze, ia64, i386, and m68k differs by calling exit syscall directly. This patch changes all architectures to call the exit syscall directly, as for s390, microblaze, ia64, i386, and m68k. This do not have change glibc internal behavior in any sort, since the only usage of clone implementation in posix_spawn calls _exit directly in the created child (fork uses a direct call to clone). Checked on x86_64-linux-gnu, i686-linux-gnu, aarch64-linux-gnu, powerpc-linux-gnu, powerpc64le-linux-gnu, sparc64-linux-gnu, and sparcv9-linux-gnu. [BZ #21512] * sysdeps/unix/sysv/linux/aarch64/clone.S (__clone): Call exit syscall instead of jump to _exit. (CLONE_VM_BIT): Remove unused define. (CLONE_VM): Likewise. (CLONE_THREAD_BIT): Likewise. (CLONE_THREAD): Likewise. * sysdeps/unix/sysv/linux/alpha/clone.S (__clone): Likewise. (CLONE_VM): Remove unused define. * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Likewise. (CLONE_VM): Remove unused define. (CLONE_THREAD): Likewise. * sysdeps/unix/sysv/linux/i386/clone.S (CLONE_VM): Likewise. * sysdeps/unix/sysv/linux/ia64/clone2.S (__clone2): Call exit syscall instead of jump to _exit. * sysdeps/unix/sysv/linux/hppa/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/mips/clone.S (__clone): Likewise. (CLONE_VM): Remove unused define. (CLONE_THREAD): Likewise. * sysdeps/unix/sysv/linux/nios2/clone.S (__clone): Likewise. (CLONE_VM): Remove unused define. * sysdeps/unix/sysv/linux/powerpc/powerpc32/clone.S (__clone): Likewise. (CLONE_VM): Remove unused define. (CLONE_THREAD): Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S (__clone): Likewise. (CLONE_VM): Remove unused define. (CLONE_THREAD): Likewise. * sysdeps/unix/sysv/linux/sh/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/clone.S (__clone): Likewise. (CLONE_VM): Remove unused define. * sysdeps/unix/sysv/linux/sparc/sparc64/clone.S (__clone): Likewise. (CLONE_VM): Remove unused define. * sysdeps/unix/sysv/linux/tile/clone.S (__clone): Likewise. * sysdeps/unix/sysv/linux/x86_64/clone.S (__clone): Likewise. (CLONE_VM): Remove unused define. * sysdeps/unix/sysv/linux/Makefile (tests): Add tst-clone3. * sysdeps/unix/sysv/linux/tst-clone3.c: New file. Fix
97 lines
2.9 KiB
C
97 lines
2.9 KiB
C
/* Check if clone (CLONE_THREAD) does not call exit_group (BZ #21512)
|
|
Copyright (C) 2017 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <string.h>
|
|
#include <sched.h>
|
|
#include <signal.h>
|
|
#include <unistd.h>
|
|
#include <sys/syscall.h>
|
|
#include <sys/wait.h>
|
|
#include <sys/types.h>
|
|
#include <linux/futex.h>
|
|
|
|
#include <stackinfo.h> /* For _STACK_GROWS_{UP,DOWN}. */
|
|
#include <support/check.h>
|
|
|
|
/* Test if clone call with CLONE_THREAD does not call exit_group. The 'f'
|
|
function returns '1', which will be used by clone thread to call the
|
|
'exit' syscall directly. If _exit is used instead, exit_group will be
|
|
used and thus the thread group will finish with return value of '1'
|
|
(where '2' from main thread is expected. */
|
|
|
|
static int
|
|
f (void *a)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
/* Futex wait for TID argument, similar to pthread_join internal
|
|
implementation. */
|
|
#define wait_tid(tid) \
|
|
do { \
|
|
__typeof (tid) __tid; \
|
|
while ((__tid = (tid)) != 0) \
|
|
futex_wait (&(tid), __tid); \
|
|
} while (0)
|
|
|
|
static inline int
|
|
futex_wait (int *futexp, int val)
|
|
{
|
|
return syscall (__NR_futex, futexp, FUTEX_WAIT, val);
|
|
}
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
char st[1024] __attribute__ ((aligned));
|
|
int clone_flags = CLONE_THREAD;
|
|
/* Minimum required flags to used along with CLONE_THREAD. */
|
|
clone_flags |= CLONE_VM | CLONE_SIGHAND;
|
|
/* We will used ctid to call on futex to wait for thread exit. */
|
|
clone_flags |= CLONE_CHILD_CLEARTID;
|
|
pid_t ctid, tid;
|
|
|
|
#ifdef __ia64__
|
|
extern int __clone2 (int (*__fn) (void *__arg), void *__child_stack_base,
|
|
size_t __child_stack_size, int __flags,
|
|
void *__arg, ...);
|
|
tid = __clone2 (f, st, sizeof (st), clone_flags, NULL, /* ptid */ NULL,
|
|
/* tls */ NULL, &ctid);
|
|
#else
|
|
#if _STACK_GROWS_DOWN
|
|
tid = clone (f, st + sizeof (st), clone_flags, NULL, /* ptid */ NULL,
|
|
/* tls */ NULL, &ctid);
|
|
#elif _STACK_GROWS_UP
|
|
tid = clone (f, st, clone_flags, NULL, /* ptid */ NULL, /* tls */ NULL,
|
|
&ctid);
|
|
#else
|
|
#error "Define either _STACK_GROWS_DOWN or _STACK_GROWS_UP"
|
|
#endif
|
|
#endif
|
|
if (tid == -1)
|
|
FAIL_EXIT1 ("clone failed: %m");
|
|
|
|
ctid = tid;
|
|
wait_tid (ctid);
|
|
|
|
return 2;
|
|
}
|
|
|
|
#define EXPECTED_STATUS 2
|
|
#include <support/test-driver.c>
|