Stefan Liebler 403b4feb22 Fix race in pthread_mutex_lock while promoting to PTHREAD_MUTEX_ELISION_NP [BZ #23275] ... The race leads either to pthread_mutex_destroy returning EBUSY or triggering an assertion (See description in bugzilla). This patch is fixing the race by ensuring that the elision path is used in all cases if elision is enabled by the GLIBC_TUNABLES framework. The __kind variable in struct __pthread_mutex_s is accessed concurrently. Therefore we are now using the atomic macros. The new testcase tst-mutex10 is triggering the race on s390x and intel. Presumably also on power, but I don't have access to a power machine with lock-elision. At least the code for power is the same as on the other two architectures. ChangeLog: [BZ #23275] * nptl/tst-mutex10.c: New File. * nptl/Makefile (tests): Add tst-mutex10. (tst-mutex10-ENV): New variable. * sysdeps/unix/sysv/linux/s390/force-elision.h: (FORCE_ELISION): Ensure that elision path is used if elision is available. * sysdeps/unix/sysv/linux/powerpc/force-elision.h (FORCE_ELISION): Likewise. * sysdeps/unix/sysv/linux/x86/force-elision.h: (FORCE_ELISION): Likewise. * nptl/pthreadP.h (PTHREAD_MUTEX_TYPE, PTHREAD_MUTEX_TYPE_ELISION) (PTHREAD_MUTEX_PSHARED): Use atomic_load_relaxed. * nptl/pthread_mutex_consistent.c (pthread_mutex_consistent): Likewise. * nptl/pthread_mutex_getprioceiling.c (pthread_mutex_getprioceiling): Likewise. * nptl/pthread_mutex_lock.c (__pthread_mutex_lock_full) (__pthread_mutex_cond_lock_adjust): Likewise. * nptl/pthread_mutex_setprioceiling.c (pthread_mutex_setprioceiling): Likewise. * nptl/pthread_mutex_timedlock.c (__pthread_mutex_timedlock): Likewise. * nptl/pthread_mutex_trylock.c (__pthread_mutex_trylock): Likewise. * nptl/pthread_mutex_unlock.c (__pthread_mutex_unlock_full): Likewise. * sysdeps/nptl/bits/thread-shared-types.h (struct __pthread_mutex_s): Add comments. * nptl/pthread_mutex_destroy.c (__pthread_mutex_destroy): Use atomic_load_relaxed and atomic_store_relaxed. * nptl/pthread_mutex_init.c (__pthread_mutex_init): Use atomic_store_relaxed.		2018-10-17 12:23:04 +02:00
..
aarch64	Remove extra space at end of line.	2018-10-16 11:02:03 -07:00
alpha	Use copysign functions not __copysign functions in glibc libm.	2018-09-27 20:04:48 +00:00
arm	Add new exp and exp2 implementations	2018-09-05 16:22:00 +01:00
generic	libio: Flush stream at freopen (BZ#21037)	2018-10-02 10:01:56 -03:00
gnu	Update netinet/udp.h from Linux 4.18.	2018-08-27 13:43:05 +00:00
hppa	Move SNAN_TESTS_PRESERVE_PAYLOAD out of math-tests.h.	2018-08-01 11:21:16 +00:00
htl	hurd: Avoid PLTs for __pthread_get/setspecific	2018-08-09 01:28:55 +02:00
hurd	Fix ISO C threads installed header and HURD assumption	2018-07-25 17:27:45 -03:00
i386	Remove unnecessary math_private.h includes.	2018-09-28 21:53:33 +00:00
ia64	Remove unnecessary math_private.h includes.	2018-09-28 21:53:33 +00:00
ieee754	Fix libnldbl_nonshared.a references to internal libm symbols (bug 23735).	2018-10-04 12:16:05 +00:00
init_array	sysdeps/init_array: Add PREINIT_FUNCTION to crti.S	2018-01-29 10:22:26 -08:00
m68k	Use trunc functions not __trunc functions in glibc libm.	2018-09-20 21:11:10 +00:00
mach	hurd: Fix exec usage of mach_setup_thread	2018-08-01 00:10:03 +02:00
microblaze	Mark _init and _fini as hidden [BZ #23145]	2018-06-08 10:28:52 -07:00
mips	Split fenv_private.h out of math_private.h more consistently.	2018-08-28 20:48:49 +00:00
nios2	Move EXCEPTION_TESTS_* out of math-tests.h	2018-08-23 23:41:13 +00:00
nptl	Fix race in pthread_mutex_lock while promoting to PTHREAD_MUTEX_ELISION_NP [BZ #23275]	2018-10-17 12:23:04 +02:00
posix	Fix Linux fcntl OFD locks for non-LFS architectures (BZ#20251)	2018-06-26 13:22:53 -03:00
powerpc	Remove unnecessary math_private.h includes.	2018-09-28 21:53:33 +00:00
pthread	hurd: fix sigevent's sigev_notify_attributes field type	2018-04-19 21:43:44 +02:00
riscv	Remove unnecessary math_private.h includes.	2018-09-28 21:53:33 +00:00
s390	S390: Regenerate ULPs.	2018-09-06 14:29:01 +02:00
sh	Update SH libm-tests-ulps	2018-07-31 10:33:53 -03:00
sparc	Use copysign functions not __copysign functions in glibc libm.	2018-09-27 20:04:48 +00:00
unix	Fix race in pthread_mutex_lock while promoting to PTHREAD_MUTEX_ELISION_NP [BZ #23275]	2018-10-17 12:23:04 +02:00
wordsize-32	Use libc_hidden_* for strtoumax (bug 15105).	2018-02-28 14:16:21 +00:00
wordsize-64	Don't reduce test timeout to less than default	2018-10-17 09:34:13 +02:00
x86	Use round functions not __round functions in glibc libm.	2018-09-27 12:35:23 +00:00
x86_64	Use trunc functions not __trunc functions in glibc libm.	2018-09-20 21:11:10 +00:00