mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-16 08:00:05 +00:00
7455b70027
In the glibc the gettimeofday can use vDSO (on power and x86 the USE_IFUNC_GETTIMEOFDAY is defined), gettimeofday syscall or 'default' ___gettimeofday() from ./time/gettime.c (as a fallback). In this patch the last function (___gettimeofday) has been refactored and moved to ./sysdeps/unix/sysv/linux/gettimeofday.c to be Linux specific. The new __gettimeofday64 explicit 64 bit function for getting 64 bit time from the kernel (by internally calling __clock_gettime64) has been introduced. Moreover, a 32 bit version - __gettimeofday has been refactored to internally use __gettimeofday64. The __gettimeofday is now supposed to be used on systems still supporting 32 bit time (__TIMESIZE != 64) - hence the necessary check for time_t potential overflow and conversion of struct __timeval64 to 32 bit struct timespec. The iFUNC vDSO direct call optimization has been removed from both i686 and powerpc32 (USE_IFUNC_GETTIMEOFDAY is not defined for those architectures anymore). The Linux kernel does not provide a y2038 safe implementation of gettimeofday neither it plans to provide it in the future, clock_gettime64 should be used instead. Keeping support for this optimization would require to handle another build permutation (!__ASSUME_TIME64_SYSCALLS && USE_IFUNC_GETTIMEOFDAY) which adds more complexity and has limited use (since the idea is to eventually have a y2038 safe glibc build). Build tests: ./src/scripts/build-many-glibcs.py glibcs Run-time tests: - Run specific tests on ARM/x86 32bit systems (qemu): https://github.com/lmajewski/meta-y2038 and run tests: https://github.com/lmajewski/y2038-tests/commits/master Above tests were performed with Y2038 redirection applied as well as without to test proper usage of both __gettimeofday64 and __gettimeofday. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> [Including some commit message improvement]
97 lines
2.6 KiB
C
97 lines
2.6 KiB
C
/* gettimeofday - set time. Linux version.
|
|
Copyright (C) 2020 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public License as
|
|
published by the Free Software Foundation; either version 2.1 of the
|
|
License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
/* Optimize the function call by setting the PLT directly to vDSO symbol. */
|
|
#ifdef USE_IFUNC_GETTIMEOFDAY
|
|
# include <time.h>
|
|
# include <string.h>
|
|
# include <sysdep.h>
|
|
# include <sysdep-vdso.h>
|
|
|
|
# ifdef SHARED
|
|
# include <dl-vdso.h>
|
|
# include <libc-vdso.h>
|
|
|
|
static int
|
|
__gettimeofday_syscall (struct timeval *restrict tv, void *restrict tz)
|
|
{
|
|
if (__glibc_unlikely (tz != 0))
|
|
memset (tz, 0, sizeof *tz);
|
|
return INLINE_SYSCALL_CALL (gettimeofday, tv, tz);
|
|
}
|
|
|
|
# undef INIT_ARCH
|
|
# define INIT_ARCH() \
|
|
void *vdso_gettimeofday = dl_vdso_vsym (HAVE_GETTIMEOFDAY_VSYSCALL)
|
|
libc_ifunc (__gettimeofday,
|
|
vdso_gettimeofday ? VDSO_IFUNC_RET (vdso_gettimeofday)
|
|
: (void *) __gettimeofday_syscall)
|
|
|
|
# else
|
|
int
|
|
__gettimeofday (struct timeval *restrict tv, void *restrict tz)
|
|
{
|
|
if (__glibc_unlikely (tz != 0))
|
|
memset (tz, 0, sizeof *tz);
|
|
|
|
return INLINE_VSYSCALL (gettimeofday, 2, tv, tz);
|
|
}
|
|
# endif
|
|
weak_alias (__gettimeofday, gettimeofday)
|
|
#else /* USE_IFUNC_GETTIMEOFDAY */
|
|
/* Conversion of gettimeofday function to support 64 bit time on archs
|
|
with __WORDSIZE == 32 and __TIMESIZE == 32/64 */
|
|
#include <errno.h>
|
|
|
|
int
|
|
__gettimeofday64 (struct __timeval64 *restrict tv, void *restrict tz)
|
|
{
|
|
if (__glibc_unlikely (tz != 0))
|
|
memset (tz, 0, sizeof (struct timezone));
|
|
|
|
struct __timespec64 ts64;
|
|
if (__clock_gettime64 (CLOCK_REALTIME, &ts64))
|
|
return -1;
|
|
|
|
*tv = timespec64_to_timeval64 (ts64);
|
|
return 0;
|
|
}
|
|
|
|
# if __TIMESIZE != 64
|
|
libc_hidden_def (__gettimeofday64)
|
|
|
|
int
|
|
__gettimeofday (struct timeval *restrict tv, void *restrict tz)
|
|
{
|
|
struct __timeval64 tv64;
|
|
if (__gettimeofday64 (&tv64, tz))
|
|
return -1;
|
|
|
|
if (! in_time_t_range (tv64.tv_sec))
|
|
{
|
|
__set_errno (EOVERFLOW);
|
|
return -1;
|
|
}
|
|
|
|
*tv = valid_timeval64_to_timeval (tv64);
|
|
return 0;
|
|
}
|
|
# endif
|
|
weak_alias (__gettimeofday, gettimeofday)
|
|
#endif
|