mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-27 05:00:15 +00:00
283d985122
Current posix_spawnp implementation wrongly tries to execute invalid
binaries (for instance script without shebang) as a shell script in
non compat mode. It was a regression introduced by
9ff72da471 when __spawni started to use
__execvpe instead of __execve (glibc __execvpe try to execute ENOEXEC
as shell script regardless).
This patch fixes it by using an internal symbol (__execvpex) with the
faulty semantic (since compat mode is handled by spawni.c itself).
It was reported by Daniel Drake on libc-help [1].
Checked on x86_64-linux-gnu and i686-linux-gnu.
[BZ #23264]
* include/unistd.h (__execvpex): New prototype.
* posix/Makefile (tests): Add tst-spawn4.
(tests-internal): Add tst-spawn4-compat.
* posix/execvpe.c (__execvpe_common, __execvpex): New functions.
* posix/tst-spawn4-compat.c: New file.
* posix/tst-spawn4.c: Likewise.
* sysdeps/unix/sysv/linux/spawni.c (__spawni): Do not interpret invalid
binaries as shell scripts.
* sysdeps/posix/spawni.c (__spawni): Likewise.
[1] https://sourceware.org/ml/libc-help/2018-06/msg00012.html
78 lines
2.3 KiB
C
78 lines
2.3 KiB
C
/* Check if posix_spawn does handle correctly ENOEXEC files.
|
|
Copyright (C) 2018 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <spawn.h>
|
|
#include <errno.h>
|
|
#include <unistd.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/wait.h>
|
|
|
|
#include <support/xunistd.h>
|
|
#include <support/check.h>
|
|
#include <support/temp_file.h>
|
|
|
|
#include <shlib-compat.h>
|
|
#if TEST_COMPAT (libc, GLIBC_2_0, GLIBC_2_15)
|
|
|
|
compat_symbol_reference (libc, posix_spawn, posix_spawn, GLIBC_2_2);
|
|
compat_symbol_reference (libc, posix_spawnp, posix_spawnp, GLIBC_2_2);
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
char *scriptname;
|
|
int fd = create_temp_file ("tst-spawn4.", &scriptname);
|
|
TEST_VERIFY_EXIT (fd >= 0);
|
|
|
|
const char script[] = "exit 65";
|
|
xwrite (fd, script, sizeof (script) - 1);
|
|
xclose (fd);
|
|
|
|
TEST_VERIFY_EXIT (chmod (scriptname, 0x775) == 0);
|
|
|
|
pid_t pid;
|
|
int status;
|
|
|
|
/* For compat symbol it verifies that trying to issued a shell script
|
|
without a shebang is correctly executed. */
|
|
status = posix_spawn (&pid, scriptname, NULL, NULL, (char *[]) { 0 },
|
|
(char *[]) { 0 });
|
|
TEST_VERIFY_EXIT (status == 0);
|
|
|
|
TEST_VERIFY_EXIT (waitpid (pid, &status, 0) == pid);
|
|
TEST_VERIFY_EXIT (WIFEXITED (status) == 1 && WEXITSTATUS (status) == 65);
|
|
|
|
status = posix_spawnp (&pid, scriptname, NULL, NULL, (char *[]) { 0 },
|
|
(char *[]) { 0 });
|
|
TEST_VERIFY_EXIT (status == 0);
|
|
|
|
TEST_VERIFY_EXIT (waitpid (pid, &status, 0) == pid);
|
|
TEST_VERIFY_EXIT (WIFEXITED (status) == 1 && WEXITSTATUS (status) == 65);
|
|
|
|
return 0;
|
|
}
|
|
#else
|
|
static int
|
|
do_test (void)
|
|
{
|
|
return 77;
|
|
}
|
|
#endif
|
|
|
|
#include <support/test-driver.c>
|