mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-25 06:20:06 +00:00
34a5a1460e
The GNU Coding Standards specify that line breaks in expressions should go before an operator, not after one. This patch fixes various code to do this. It only changes code that appears to be mostly following GNU style anyway, not files and directories with substantially different formatting. It is not exhaustive even for files using GNU style (for example, changes to sysdeps files are deferred for subsequent cleanups). Some files changed are shared with gnulib, but most are specific to glibc. Changes were made manually, with places to change found by grep (so some cases, e.g. where the operator was followed by a comment at end of line, are particularly liable to have been missed by grep, but I did include cases where the operator was followed by backslash-newline). This patch generally does not attempt to address other coding style issues in the expressions changed (for example, missing spaces before '(', or lack of parentheses to ensure indentation of continuation lines properly reflects operator precedence). Tested for x86_64, and with build-many-glibcs.py. * benchtests/bench-memmem.c (simple_memmem): Break lines before rather than after operators. * benchtests/bench-skeleton.c (TIMESPEC_AFTER): Likewise. * crypt/md5.c (md5_finish_ctx): Likewise. * crypt/sha256.c (__sha256_finish_ctx): Likewise. * crypt/sha512.c (__sha512_finish_ctx): Likewise. * elf/cache.c (load_aux_cache): Likewise. * elf/dl-load.c (open_verify): Likewise. * elf/get-dynamic-info.h (elf_get_dynamic_info): Likewise. * elf/readelflib.c (process_elf_file): Likewise. * elf/rtld.c (dl_main): Likewise. * elf/sprof.c (generate_call_graph): Likewise. * hurd/ctty-input.c (_hurd_ctty_input): Likewise. * hurd/ctty-output.c (_hurd_ctty_output): Likewise. * hurd/dtable.c (reauth_dtable): Likewise. * hurd/getdport.c (__getdport): Likewise. * hurd/hurd/signal.h (_hurd_interrupted_rpc_timeout): Likewise. * hurd/hurd/sigpreempt.h (HURD_PREEMPT_SIGNAL_P): Likewise. * hurd/hurdfault.c (_hurdsig_fault_catch_exception_raise): Likewise. * hurd/hurdioctl.c (fioctl): Likewise. * hurd/hurdselect.c (_hurd_select): Likewise. * hurd/hurdsig.c (_hurdsig_abort_rpcs): Likewise. (STOPSIGS): Likewise. * hurd/hurdstartup.c (_hurd_startup): Likewise. * hurd/intr-msg.c (_hurd_intr_rpc_mach_msg): Likewise. * hurd/lookup-retry.c (__hurd_file_name_lookup_retry): Likewise. * hurd/msgportdemux.c (msgport_server): Likewise. * hurd/setauth.c (_hurd_setauth): Likewise. * include/features.h (__GLIBC_USE_DEPRECATED_SCANF): Likewise. * libio/libioP.h [IO_DEBUG] (CHECK_FILE): Likewise. * locale/programs/ld-ctype.c (set_class_defaults): Likewise. * localedata/tests-mbwc/tst_swscanf.c (tst_swscanf): Likewise. * login/tst-utmp.c (do_check): Likewise. (simulate_login): Likewise. * mach/lowlevellock.h (lll_lock): Likewise. (lll_trylock): Likewise. * math/test-fenv.c (ALL_EXC): Likewise. * math/test-fenvinline.c (ALL_EXC): Likewise. * misc/sys/cdefs.h (__attribute_deprecated_msg__): Likewise. * nis/nis_call.c (__do_niscall3): Likewise. * nis/nis_callback.c (cb_prog_1): Likewise. * nis/nis_defaults.c (searchaccess): Likewise. * nis/nis_findserv.c (__nis_findfastest_with_timeout): Likewise. * nis/nis_ismember.c (internal_ismember): Likewise. * nis/nis_local_names.c (nis_local_principal): Likewise. * nis/nss_nis/nis-rpc.c (_nss_nis_getrpcbyname_r): Likewise. * nis/nss_nisplus/nisplus-netgrp.c (_nss_nisplus_getnetgrent_r): Likewise. * nis/ypclnt.c (yp_match): Likewise. (yp_first): Likewise. (yp_next): Likewise. (yp_master): Likewise. (yp_order): Likewise. * nscd/hstcache.c (cache_addhst): Likewise. * nscd/initgrcache.c (addinitgroupsX): Likewise. * nss/nss_compat/compat-pwd.c (copy_pwd_changes): Likewise. (internal_getpwuid_r): Likewise. * nss/nss_compat/compat-spwd.c (copy_spwd_changes): Likewise. * posix/glob.h (__GLOB_FLAGS): Likewise. * posix/regcomp.c (peek_token): Likewise. (peek_token_bracket): Likewise. (parse_expression): Likewise. * posix/regexec.c (sift_states_iter_mb): Likewise. (check_node_accept_bytes): Likewise. * posix/tst-spawn3.c (do_test): Likewise. * posix/wordexp-test.c (testit): Likewise. * posix/wordexp.c (parse_tilde): Likewise. (exec_comm): Likewise. * posix/wordexp.h (__WRDE_FLAGS): Likewise. * resource/vtimes.c (TIMEVAL_TO_VTIMES): Likewise. * setjmp/sigjmp.c (__sigjmp_save): Likewise. * stdio-common/printf_fp.c (__printf_fp_l): Likewise. * stdio-common/tst-fileno.c (do_test): Likewise. * stdio-common/vfprintf-internal.c (vfprintf): Likewise. * stdlib/strfmon_l.c (__vstrfmon_l_internal): Likewise. * stdlib/strtod_l.c (round_and_return): Likewise. (____STRTOF_INTERNAL): Likewise. * stdlib/tst-strfrom.h (TEST_STRFROM): Likewise. * string/strcspn.c (STRCSPN): Likewise. * string/test-memmem.c (simple_memmem): Likewise. * termios/tcsetattr.c (tcsetattr): Likewise. * time/alt_digit.c (_nl_parse_alt_digit): Likewise. * time/asctime.c (asctime_internal): Likewise. * time/strptime_l.c (__strptime_internal): Likewise. * time/sys/time.h (timercmp): Likewise. * time/tzfile.c (__tzfile_compute): Likewise.
185 lines
4.8 KiB
C
185 lines
4.8 KiB
C
/* Skeleton for benchmark programs.
|
|
Copyright (C) 2013-2019 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <string.h>
|
|
#include <stdint.h>
|
|
#include <stdbool.h>
|
|
#include <stdio.h>
|
|
#include <time.h>
|
|
#include <inttypes.h>
|
|
#include "bench-timing.h"
|
|
#include "json-lib.h"
|
|
#include "bench-util.h"
|
|
|
|
#include "bench-util.c"
|
|
|
|
#define TIMESPEC_AFTER(a, b) \
|
|
(((a).tv_sec == (b).tv_sec) \
|
|
? ((a).tv_nsec > (b).tv_nsec) \
|
|
: ((a).tv_sec > (b).tv_sec))
|
|
int
|
|
main (int argc, char **argv)
|
|
{
|
|
unsigned long i, k;
|
|
struct timespec runtime;
|
|
timing_t start, end;
|
|
bool detailed = false;
|
|
json_ctx_t json_ctx;
|
|
|
|
if (argc == 2 && !strcmp (argv[1], "-d"))
|
|
detailed = true;
|
|
|
|
bench_start ();
|
|
|
|
memset (&runtime, 0, sizeof (runtime));
|
|
|
|
unsigned long iters, res;
|
|
|
|
#ifdef BENCH_INIT
|
|
BENCH_INIT ();
|
|
#endif
|
|
TIMING_INIT (res);
|
|
|
|
iters = 1000 * res;
|
|
|
|
json_init (&json_ctx, 2, stdout);
|
|
|
|
/* Begin function. */
|
|
json_attr_object_begin (&json_ctx, FUNCNAME);
|
|
|
|
for (int v = 0; v < NUM_VARIANTS; v++)
|
|
{
|
|
/* Run for approximately DURATION seconds. */
|
|
clock_gettime (CLOCK_MONOTONIC_RAW, &runtime);
|
|
runtime.tv_sec += DURATION;
|
|
|
|
bool is_bench = strncmp (VARIANT (v), "workload-", 9) == 0;
|
|
double d_total_i = 0;
|
|
timing_t total = 0, max = 0, min = 0x7fffffffffffffff;
|
|
timing_t throughput = 0, latency = 0;
|
|
int64_t c = 0;
|
|
uint64_t cur;
|
|
BENCH_VARS;
|
|
while (1)
|
|
{
|
|
if (is_bench)
|
|
{
|
|
/* Benchmark a real trace of calls - all samples are iterated
|
|
over once before repeating. This models actual use more
|
|
accurately than repeating the same sample many times. */
|
|
TIMING_NOW (start);
|
|
for (k = 0; k < iters; k++)
|
|
for (i = 0; i < NUM_SAMPLES (v); i++)
|
|
BENCH_FUNC (v, i);
|
|
TIMING_NOW (end);
|
|
TIMING_DIFF (cur, start, end);
|
|
TIMING_ACCUM (throughput, cur);
|
|
|
|
TIMING_NOW (start);
|
|
for (k = 0; k < iters; k++)
|
|
for (i = 0; i < NUM_SAMPLES (v); i++)
|
|
BENCH_FUNC_LAT (v, i);
|
|
TIMING_NOW (end);
|
|
TIMING_DIFF (cur, start, end);
|
|
TIMING_ACCUM (latency, cur);
|
|
|
|
d_total_i += iters * NUM_SAMPLES (v);
|
|
}
|
|
else
|
|
for (i = 0; i < NUM_SAMPLES (v); i++)
|
|
{
|
|
TIMING_NOW (start);
|
|
for (k = 0; k < iters; k++)
|
|
BENCH_FUNC (v, i);
|
|
TIMING_NOW (end);
|
|
|
|
TIMING_DIFF (cur, start, end);
|
|
|
|
if (cur > max)
|
|
max = cur;
|
|
|
|
if (cur < min)
|
|
min = cur;
|
|
|
|
TIMING_ACCUM (total, cur);
|
|
/* Accumulate timings for the value. In the end we will divide
|
|
by the total iterations. */
|
|
RESULT_ACCUM (cur, v, i, c * iters, (c + 1) * iters);
|
|
|
|
d_total_i += iters;
|
|
}
|
|
c++;
|
|
struct timespec curtime;
|
|
|
|
memset (&curtime, 0, sizeof (curtime));
|
|
clock_gettime (CLOCK_MONOTONIC_RAW, &curtime);
|
|
if (TIMESPEC_AFTER (curtime, runtime))
|
|
goto done;
|
|
}
|
|
|
|
double d_total_s;
|
|
double d_iters;
|
|
|
|
done:
|
|
d_total_s = total;
|
|
d_iters = iters;
|
|
|
|
/* Begin variant. */
|
|
json_attr_object_begin (&json_ctx, VARIANT (v));
|
|
|
|
if (is_bench)
|
|
{
|
|
json_attr_double (&json_ctx, "duration", throughput + latency);
|
|
json_attr_double (&json_ctx, "iterations", 2 * d_total_i);
|
|
json_attr_double (&json_ctx, "reciprocal-throughput",
|
|
throughput / d_total_i);
|
|
json_attr_double (&json_ctx, "latency", latency / d_total_i);
|
|
json_attr_double (&json_ctx, "max-throughput",
|
|
d_total_i / throughput * 1000000000.0);
|
|
json_attr_double (&json_ctx, "min-throughput",
|
|
d_total_i / latency * 1000000000.0);
|
|
}
|
|
else
|
|
{
|
|
json_attr_double (&json_ctx, "duration", d_total_s);
|
|
json_attr_double (&json_ctx, "iterations", d_total_i);
|
|
json_attr_double (&json_ctx, "max", max / d_iters);
|
|
json_attr_double (&json_ctx, "min", min / d_iters);
|
|
json_attr_double (&json_ctx, "mean", d_total_s / d_total_i);
|
|
}
|
|
|
|
if (detailed && !is_bench)
|
|
{
|
|
json_array_begin (&json_ctx, "timings");
|
|
|
|
for (int i = 0; i < NUM_SAMPLES (v); i++)
|
|
json_element_double (&json_ctx, RESULT (v, i));
|
|
|
|
json_array_end (&json_ctx);
|
|
}
|
|
|
|
/* End variant. */
|
|
json_attr_object_end (&json_ctx);
|
|
}
|
|
|
|
/* End function. */
|
|
json_attr_object_end (&json_ctx);
|
|
|
|
return 0;
|
|
}
|