mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-27 07:20:11 +00:00
0f4840be25
To make a strtok faster and improve performance in general we need to do one additional change. A comment: /* It doesn't make sense to send libc-internal strcspn calls through a PLT. The speedup we get from using SSE4.2 instruction is likely eaten away by the indirect call in the PLT. */ Does not make sense at all because nobody bothered to check it. Gap between these implementations is quite big, when haystack is empty a sse2 is around 40 cycles slower because it needs to populate a lookup table and difference only increases with size. That is much bigger than plt slowdown which is few cycles. Even benchtest show a gap which also may be reverse by branch misprediction but my internal benchmark shown. simple_strspn stupid_strspn __strspn_sse42 __strspn_sse2 Length 0, alignment 0, acc len 6: 18.6562 35.2344 17.0469 61.6719 Length 6, alignment 0, acc len 6: 59.5469 72.5781 16.4219 73.625 This patch also handles strpbrk which is implemented by including a x86_64/multiarch/strcspn.S file. * sysdeps/x86_64/multiarch/strspn.S: Remove plt indirection. * sysdeps/x86_64/multiarch/strcspn.S: Likewise.
76 lines
2.2 KiB
ArmAsm
76 lines
2.2 KiB
ArmAsm
/* Multiple versions of strcspn
|
|
All versions must be listed in ifunc-impl-list.c.
|
|
Copyright (C) 2009-2015 Free Software Foundation, Inc.
|
|
Contributed by Intel Corporation.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <config.h>
|
|
|
|
#ifdef HAVE_SSE4_SUPPORT
|
|
|
|
#include <sysdep.h>
|
|
#include <init-arch.h>
|
|
|
|
#ifdef USE_AS_STRPBRK
|
|
#define STRCSPN_SSE42 __strpbrk_sse42
|
|
#define STRCSPN_SSE2 __strpbrk_sse2
|
|
#define __GI_STRCSPN __GI_strpbrk
|
|
#else
|
|
#ifndef STRCSPN
|
|
#define STRCSPN strcspn
|
|
#define STRCSPN_SSE42 __strcspn_sse42
|
|
#define STRCSPN_SSE2 __strcspn_sse2
|
|
#define __GI_STRCSPN __GI_strcspn
|
|
#endif
|
|
#endif
|
|
|
|
/* Define multiple versions only for the definition in libc. Don't
|
|
define multiple versions for strpbrk in static library since we
|
|
need strpbrk before the initialization happened. */
|
|
#if (defined SHARED || !defined USE_AS_STRPBRK) && IS_IN (libc)
|
|
.text
|
|
ENTRY(STRCSPN)
|
|
.type STRCSPN, @gnu_indirect_function
|
|
cmpl $0, __cpu_features+KIND_OFFSET(%rip)
|
|
jne 1f
|
|
call __init_cpu_features
|
|
1: leaq STRCSPN_SSE2(%rip), %rax
|
|
testl $bit_SSE4_2, __cpu_features+CPUID_OFFSET+index_SSE4_2(%rip)
|
|
jz 2f
|
|
leaq STRCSPN_SSE42(%rip), %rax
|
|
2: ret
|
|
END(STRCSPN)
|
|
|
|
# undef ENTRY
|
|
# define ENTRY(name) \
|
|
.type STRCSPN_SSE2, @function; \
|
|
.globl STRCSPN_SSE2; \
|
|
.align 16; \
|
|
STRCSPN_SSE2: cfi_startproc; \
|
|
CALL_MCOUNT
|
|
# undef END
|
|
# define END(name) \
|
|
cfi_endproc; .size STRCSPN_SSE2, .-STRCSPN_SSE2
|
|
#endif
|
|
#endif /* HAVE_SSE4_SUPPORT */
|
|
|
|
#ifdef USE_AS_STRPBRK
|
|
#include "../strpbrk.S"
|
|
#else
|
|
#include "../strcspn.S"
|
|
#endif
|