mirror of
https://sourceware.org/git/glibc.git
synced 2024-09-21 17:04:05 +00:00
4cf69995e2
http://sourceware.org/ml/libc-alpha/2013-06/msg00919.html I discovered a number of places where denormals and other corner cases were being handled wrongly. - printf_fphex.c: Testing for the low double exponent being zero is unnecessary. If the difference in exponents is less than 53 then the high double exponent must be nearing the low end of its range, and the low double exponent hit rock bottom. - ldbl2mpn.c: A denormal (ie. exponent of zero) value is treated as if the exponent was one, so shift mantissa left by one. Code handling normalisation of the low double mantissa lacked a test for shift count greater than bits in type being shifted, and lacked anything to handle the case where the difference in exponents is less than 53 as in printf_fphex.c. - math_ldbl.h (ldbl_extract_mantissa): Same as above, but worse, with code testing for exponent > 1 for some reason, probably a typo for >= 1. - math_ldbl.h (ldbl_insert_mantissa): Round the high double as per mpn2ldbl.c (hi is odd or explicit mantissas non-zero) so that the number we return won't change when applying ldbl_canonicalize(). Add missing overflow checks and normalisation of high mantissa. Correct misleading comment: "The hidden bit of the lo mantissa is zero" is not always true as can be seen from the code rounding the hi mantissa. Also by inspection, lzcount can never be less than zero so remove that test. Lastly, masking bitfields to their widths can be left to the compiler. - mpn2ldbl.c: The overflow checks here on rounding of high double were just plain wrong. Incrementing the exponent must be accompanied by a shift right of the mantissa to keep the value unchanged. Above notes for ldbl_insert_mantissa are also relevant. [BZ #15680] * sysdeps/ieee754/ldbl-128ibm/e_rem_pio2l.c: Comment fix. * sysdeps/ieee754/ldbl-128ibm/printf_fphex.c (PRINT_FPHEX_LONG_DOUBLE): Tidy code by moving -53 into ediff calculation. Remove unnecessary test for denormal exponent. * sysdeps/ieee754/ldbl-128ibm/ldbl2mpn.c (__mpn_extract_long_double): Correct handling of denormals. Avoid undefined shift behaviour. Correct normalisation of low mantissa when low double is denormal. * sysdeps/ieee754/ldbl-128ibm/math_ldbl.h (ldbl_extract_mantissa): Likewise. Comment. Use uint64_t* for hi64. (ldbl_insert_mantissa): Make both hi64 and lo64 parms uint64_t. Correct normalisation of low mantissa. Test for overflow of high mantissa and normalise. (ldbl_nearbyint): Use more readable constant for two52. * sysdeps/ieee754/ldbl-128ibm/mpn2ldbl.c (__mpn_construct_long_double): Fix test for overflow of high mantissa and correct normalisation. Avoid undefined shift. |
||
|---|---|---|
| .. | ||
| e_acoshl.c | ||
| e_acosl.c | ||
| e_asinl.c | ||
| e_atan2l.c | ||
| e_atanhl.c | ||
| e_coshl.c | ||
| e_exp10l.c | ||
| e_expl.c | ||
| e_fmodl.c | ||
| e_gammal_r.c | ||
| e_hypotl.c | ||
| e_ilogbl.c | ||
| e_j0l.c | ||
| e_j1l.c | ||
| e_jnl.c | ||
| e_lgammal_r.c | ||
| e_log2l.c | ||
| e_log10l.c | ||
| e_logl.c | ||
| e_powl.c | ||
| e_rem_pio2l.c | ||
| e_remainderl.c | ||
| e_sinhl.c | ||
| e_sqrtl.c | ||
| gamma_productl.c | ||
| ieee754.h | ||
| k_cosl.c | ||
| k_sincosl.c | ||
| k_sinl.c | ||
| k_tanl.c | ||
| ldbl2mpn.c | ||
| Makefile | ||
| math_ldbl.h | ||
| mpn2ldbl.c | ||
| printf_fphex.c | ||
| s_asinhl.c | ||
| s_atanl.c | ||
| s_cbrtl.c | ||
| s_ceill.c | ||
| s_copysignl.c | ||
| s_cosl.c | ||
| s_cprojl.c | ||
| s_ctanhl.c | ||
| s_ctanl.c | ||
| s_erfl.c | ||
| s_expm1l.c | ||
| s_fabsl.c | ||
| s_finitel.c | ||
| s_floorl.c | ||
| s_fmal.c | ||
| s_fpclassifyl.c | ||
| s_frexpl.c | ||
| s_isinf_nsl.c | ||
| s_isinfl.c | ||
| s_isnanl.c | ||
| s_issignalingl.c | ||
| s_llrintl.c | ||
| s_llroundl.c | ||
| s_log1pl.c | ||
| s_logbl.c | ||
| s_lrintl.c | ||
| s_lroundl.c | ||
| s_modfl.c | ||
| s_nearbyintl.c | ||
| s_nextafterl.c | ||
| s_nexttoward.c | ||
| s_nexttowardf.c | ||
| s_remquol.c | ||
| s_rintl.c | ||
| s_roundl.c | ||
| s_scalblnl.c | ||
| s_scalbnl.c | ||
| s_signbitl.c | ||
| s_sincosl.c | ||
| s_sinl.c | ||
| s_tanhl.c | ||
| s_tanl.c | ||
| s_truncl.c | ||
| strtold_l.c | ||
| t_sincosl.c | ||
| w_expl.c | ||
| x2y2m1l.c | ||