AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-01-04 00:31:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
4ed7a383f9
glibc/sysdeps/x86
History
Joseph Myers 4ed7a383f9 Fix ffma use of round-to-odd on x86 
On 32-bit x86 with -mfpmath=sse, and on x86_64 with
--disable-multi-arch, the tests of ffma and its aliases (fma narrowing
from binary64 to binary32) fail.  This is probably the issue reported
by H.J. in
<https://sourceware.org/pipermail/libc-alpha/2021-September/131277.html>.

The problem is the use of fenv_private.h macros in the round-to-odd
implementation.  Those macros are set up to manipulate only one of the
SSE and 387 floating-point state, whichever is relevant for the type
indicated by the suffix on the macro name.  But x86 configurations
sometimes use the ldbl-96 implementation of binary64 fma (that's where
--disable-multi-arch is relevant for x86_64: it causes the ldbl-96
implementation to be used, instead of an IFUNC implementation that
falls back to the dbl-64 version), contrary to the expectations of
those macros for functions operating on double when __SSE2_MATH__ is
defined.

This can be addressed by using the default versions of those macros
(giving x86 its own version of s_ffma.c), as is done for the *f128
macro variants where it depends on the details of how GCC was
configured when building libgcc which floating-point state is affected
by _Float128 arithmetic.  The issue only applies when __SSE2_MATH__ is
defined, and doesn't apply when __FP_FAST_FMA is defined (because in
that case, fma will be inlined by the compiler, meaning it's
definitely an SSE operation; for the same reason, this is not an issue
for narrowing sqrt, as hardware sqrt is always inlined in that
implementation for x86), but in other cases it's safest to use the
default versions of the fenv_private.h macros to ensure things work
whichever fma implementation is used.

Tested for x86_64 (with and without --disable-multi-arch) and x86
(with and without -mfpmath=sse).
2021-09-23 21:18:31 +00:00
..
bits x86: Install <bits/platform/x86.h> [BZ #27958] 2021-07-23 05:12:51 -07:00
fpu Fix ffma use of round-to-odd on x86 2021-09-23 21:18:31 +00:00
include x86-64: Add Avoid_Short_Distance_REP_MOVSB 2021-07-28 13:23:57 -07:00
nptl Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
sys/platform x86: Install <bits/platform/x86.h> [BZ #27958] 2021-07-23 05:12:51 -07:00
__longjmp_cancel.S Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
abi-note.c x86: Support GNU_PROPERTY_X86_ISA_1_V[234] marker [BZ #26717] 2021-01-07 13:10:13 -08:00
atomic-machine.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
cacheinfo.c x86: Handle _SC_LEVEL1_ICACHE_LINESIZE [BZ #27444] 2021-03-15 05:43:26 -07:00
cacheinfo.h x86-64: Add Avoid_Short_Distance_REP_MOVSB 2021-07-28 13:23:57 -07:00
cet-control.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
check-cet.awk Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
configure x86: fix Autoconf caching of instruction support checks [BZ #27991] 2021-08-19 09:11:35 -03:00
configure.ac x86: fix Autoconf caching of instruction support checks [BZ #27991] 2021-08-19 09:11:35 -03:00
cpu-features-offsets.sym x86: Cleanup cpu-features-offsets.sym 2018-08-03 06:42:09 -07:00
cpu-features.c x86-64: Add Avoid_Short_Distance_REP_MOVSB 2021-07-28 13:23:57 -07:00
cpu-tunables.c x86: Set Prefer_No_VZEROUPPER and add Prefer_AVX2_STRCMP 2021-03-29 07:40:17 -07:00
dl-cacheinfo.h x86: Set rep_movsb_threshold to 2112 on processors with FSRM 2021-05-03 05:08:22 -07:00
dl-cet.c x86: Properly set usable CET feature bits [BZ #26625] 2021-01-29 03:58:11 -08:00
dl-diagnostics-cpu.c x86: Install <bits/platform/x86.h> [BZ #27958] 2021-07-23 05:12:51 -07:00
dl-get-cpu-features.c Fix misplaced const 2021-01-25 15:09:02 +01:00
dl-hwcap.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-isa-level.h ldconfig/x86: Store ISA level in cache and aux cache 2021-01-13 05:51:17 -08:00
dl-lookupcfg.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-minsigstacksize.h sysconf: Add _SC_MINSIGSTKSZ/_SC_SIGSTKSZ [BZ #20305] 2021-02-01 11:00:52 -08:00
dl-procinfo.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-procinfo.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-procruntime.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
dl-prop.h x86: Support GNU_PROPERTY_X86_ISA_1_V[234] marker [BZ #26717] 2021-01-07 13:10:13 -08:00
dl-tunables.list Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
elf-initfini.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
elide.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
float128-abi.h Move __isnanf128 to libc.so 2021-03-30 14:58:19 +05:30
fpu_control.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
get-cpuid-feature-leaf.c <sys/platform/x86.h>: Remove the C preprocessor magic 2021-01-21 05:58:17 -08:00
get-isa-level.h <sys/platform/x86.h>: Remove the C preprocessor magic 2021-01-21 05:58:17 -08:00
hp-timing.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
init-arch.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isa-level.c x86: Set minimum x86-64 level marker [BZ #27318] 2021-03-06 07:49:30 -08:00
jmp_buf-ssp.sym x86: Support shadow stack pointer in setjmp/longjmp 2018-07-14 05:59:53 -07:00
ldbl2mpn.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
ldsodefs.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
libc-start.c Use hidden visibility for early static PIE code 2021-01-21 15:55:01 +00:00
libc-start.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
link_map.h x86: Support GNU_PROPERTY_X86_ISA_1_V[234] marker [BZ #26717] 2021-01-07 13:10:13 -08:00
linkmap.h
longjmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Makeconfig
Makefile configure: Allow LD to be LLD 13.0.0 or above [BZ #26558] 2021-08-31 20:23:34 -07:00
string_private.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
sysdep.h x86-64: Add Avoid_Short_Distance_REP_MOVSB 2021-07-28 13:23:57 -07:00
tininess.h
tst-cet-legacy-1.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-1a.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-2.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-2a.c x86/CET: Add tests with legacy non-CET shared objects 2018-07-25 04:47:05 -07:00
tst-cet-legacy-3.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-4.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-4a.c x86/CET: Add tests with legacy non-CET shared objects 2018-07-25 04:47:05 -07:00
tst-cet-legacy-4b.c x86/CET: Add tests with legacy non-CET shared objects 2018-07-25 04:47:05 -07:00
tst-cet-legacy-4c.c x86/CET: Add tests with legacy non-CET shared objects 2018-07-25 04:47:05 -07:00
tst-cet-legacy-5.c x86: Properly set usable CET feature bits [BZ #26625] 2021-01-29 03:58:11 -08:00
tst-cet-legacy-5a.c Call _dl_open_check after relocation [BZ #24259] 2019-07-01 12:23:22 -07:00
tst-cet-legacy-5b.c Call _dl_open_check after relocation [BZ #24259] 2019-07-01 12:23:22 -07:00
tst-cet-legacy-6.c x86: Properly set usable CET feature bits [BZ #26625] 2021-01-29 03:58:11 -08:00
tst-cet-legacy-6a.c Call _dl_open_check after relocation [BZ #24259] 2019-07-01 12:23:22 -07:00
tst-cet-legacy-6b.c Call _dl_open_check after relocation [BZ #24259] 2019-07-01 12:23:22 -07:00
tst-cet-legacy-7.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-8.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-9-static.c x86: Properly set usable CET feature bits [BZ #26625] 2021-01-29 03:58:11 -08:00
tst-cet-legacy-9.c x86: Properly set usable CET feature bits [BZ #26625] 2021-01-29 03:58:11 -08:00
tst-cet-legacy-10-static.c x86: Properly set usable CET feature bits [BZ #26625] 2021-01-29 03:58:11 -08:00
tst-cet-legacy-10.c x86: Install <bits/platform/x86.h> [BZ #27958] 2021-07-23 05:12:51 -07:00
tst-cet-legacy-mod-1.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-mod-2.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-mod-4.c x86/CET: Add tests with legacy non-CET shared objects 2018-07-25 04:47:05 -07:00
tst-cet-legacy-mod-5.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-mod-5a.c Call _dl_open_check after relocation [BZ #24259] 2019-07-01 12:23:22 -07:00
tst-cet-legacy-mod-5b.c Call _dl_open_check after relocation [BZ #24259] 2019-07-01 12:23:22 -07:00
tst-cet-legacy-mod-5c.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-mod-6.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-mod-6a.c Call _dl_open_check after relocation [BZ #24259] 2019-07-01 12:23:22 -07:00
tst-cet-legacy-mod-6b.c Call _dl_open_check after relocation [BZ #24259] 2019-07-01 12:23:22 -07:00
tst-cet-legacy-mod-6c.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cet-legacy-mod-6d.c Call _dl_open_check after relocation [BZ #24259] 2019-07-01 12:23:22 -07:00
tst-cpu-features-cpuinfo-static.c x86: Add PTWRITE feature detection [BZ #27346] 2021-02-07 08:01:14 -08:00
tst-cpu-features-cpuinfo.c x86: Install <bits/platform/x86.h> [BZ #27958] 2021-07-23 05:12:51 -07:00
tst-cpu-features-supports-static.c x86: Add PTWRITE feature detection [BZ #27346] 2021-02-07 08:01:14 -08:00
tst-cpu-features-supports.c x86: Install <bits/platform/x86.h> [BZ #27958] 2021-07-23 05:12:51 -07:00
tst-get-cpu-features-static.c
tst-get-cpu-features.c x86: Install <bits/platform/x86.h> [BZ #27958] 2021-07-23 05:12:51 -07:00
tst-ifunc-isa-1-static.c x86: Check ifunc resolver with CPU_FEATURE_USABLE [BZ #27072] 2021-01-21 10:22:26 -08:00
tst-ifunc-isa-1.c x86: Check ifunc resolver with CPU_FEATURE_USABLE [BZ #27072] 2021-01-21 10:22:26 -08:00
tst-ifunc-isa-2-static.c x86: Check ifunc resolver with CPU_FEATURE_USABLE [BZ #27072] 2021-01-21 10:22:26 -08:00
tst-ifunc-isa-2.c x86: Check ifunc resolver with CPU_FEATURE_USABLE [BZ #27072] 2021-01-21 10:22:26 -08:00
tst-ifunc-isa.h x86: Install <bits/platform/x86.h> [BZ #27958] 2021-07-23 05:12:51 -07:00
tst-isa-level-1.c <sys/platform/x86.h>: Remove the C preprocessor magic 2021-01-21 05:58:17 -08:00
tst-isa-level-mod-1-baseline.c x86: Support GNU_PROPERTY_X86_ISA_1_V[234] marker [BZ #26717] 2021-01-07 13:10:13 -08:00
tst-isa-level-mod-1-v2.c x86: Support GNU_PROPERTY_X86_ISA_1_V[234] marker [BZ #26717] 2021-01-07 13:10:13 -08:00
tst-isa-level-mod-1-v3.c x86: Support GNU_PROPERTY_X86_ISA_1_V[234] marker [BZ #26717] 2021-01-07 13:10:13 -08:00
tst-isa-level-mod-1-v4.c x86: Support GNU_PROPERTY_X86_ISA_1_V[234] marker [BZ #26717] 2021-01-07 13:10:13 -08:00
tst-isa-level-mod-1.c x86: Support GNU_PROPERTY_X86_ISA_1_V[234] marker [BZ #26717] 2021-01-07 13:10:13 -08:00
tst-ldbl-nonnormal-printf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-memchr-rtm.c x86: Add string/memory function tests in RTM region 2021-03-29 07:40:17 -07:00
tst-memcmp-rtm.c x86: Add string/memory function tests in RTM region 2021-03-29 07:40:17 -07:00
tst-memmove-rtm.c x86: Add string/memory function tests in RTM region 2021-03-29 07:40:17 -07:00
tst-memrchr-rtm.c x86: Add string/memory function tests in RTM region 2021-03-29 07:40:17 -07:00
tst-memset-rtm.c x86: Add string/memory function tests in RTM region 2021-03-29 07:40:17 -07:00
tst-setjmp-cet.c x86: Set header.feature_1 in TCB for always-on CET [BZ #27177] 2021-01-13 05:03:34 -08:00
tst-stack-align.h Properly check stack alignment [BZ #27901] 2021-05-24 07:42:12 -07:00
tst-strchr-rtm.c x86: Add string/memory function tests in RTM region 2021-03-29 07:40:17 -07:00
tst-strcpy-rtm.c x86: Add string/memory function tests in RTM region 2021-03-29 07:40:17 -07:00
tst-string-rtm.h x86: Install <bits/platform/x86.h> [BZ #27958] 2021-07-23 05:12:51 -07:00
tst-strlen-rtm.c x86: Add string/memory function tests in RTM region 2021-03-29 07:40:17 -07:00
tst-strncmp-rtm.c x86: Add string/memory function tests in RTM region 2021-03-29 07:40:17 -07:00
tst-strrchr-rtm.c x86: Add string/memory function tests in RTM region 2021-03-29 07:40:17 -07:00
tst-sysconf-cache-linesize-static.c x86: Handle _SC_LEVEL1_ICACHE_LINESIZE [BZ #27444] 2021-03-15 05:43:26 -07:00
tst-sysconf-cache-linesize.c x86: Handle _SC_LEVEL1_ICACHE_LINESIZE [BZ #27444] 2021-03-15 05:43:26 -07:00
Versions <sys/platform/x86.h>: Remove the C preprocessor magic 2021-01-21 05:58:17 -08:00