mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-27 21:20:18 +00:00
505c884aeb
If libc_hidden_builtin_{def,proto} isn't properly set for *_chk routines,
there are unwanted PLT entries in libc.so.
There is a special case with __asprintf_chk:
If ldbl_* macros are used for asprintf, ABI gets broken on s390x,
if it isn't, ppc64le isn't building due to multiple asm redirections.
This is due to the inclusion of bits/stdio-lbdl.h for ppc64le whereas it
isn't for s390x. This header creates redirections, which are not
compatible with the ones generated using libc_hidden_def.
Yet, we can't use libc_hidden_ldbl_proto on s390x since it will not
create a simple strong alias (e.g. as done on x86_64), but a versioned
alias, leading to ABI breakage.
This results in errors on s390x:
/usr/bin/ld: glibc/iconv/../libio/bits/stdio2.h:137: undefined reference
to `__asprintf_chk'
Original __asprintf_chk symbols:
00000000001395b0 T __asprintf_chk
0000000000177e90 T __nldbl___asprintf_chk
__asprintf_chk symbols with ldbl_* macros:
000000000012d590 t ___asprintf_chk
000000000012d590 t __asprintf_chk@@GLIBC_2.4
000000000012d590 t __GI___asprintf_chk
000000000012d590 t __GL____asprintf_chk___asprintf_chk
0000000000172240 T __nldbl___asprintf_chk
__asprintf_chk symbols with the patch:
000000000012d590 t ___asprintf_chk
000000000012d590 T __asprintf_chk
000000000012d590 t __GI___asprintf_chk
0000000000172240 T __nldbl___asprintf_chk
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
60 lines
2.2 KiB
C
60 lines
2.2 KiB
C
/* Copyright (C) 1993-2023 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>.
|
|
|
|
As a special exception, if you link the code in this file with
|
|
files compiled with a GNU compiler to produce an executable,
|
|
that does not cause the resulting executable to be covered by
|
|
the GNU Lesser General Public License. This exception does not
|
|
however invalidate any other reasons why the executable file
|
|
might be covered by the GNU Lesser General Public License.
|
|
This exception applies to code released by its copyright holders
|
|
in files containing the exception. */
|
|
|
|
#include "libioP.h"
|
|
#include <stdio.h>
|
|
#include <sys/param.h>
|
|
|
|
char *
|
|
__fgets_unlocked_chk (char *buf, size_t size, int n, FILE *fp)
|
|
{
|
|
size_t count;
|
|
char *result;
|
|
CHECK_FILE (fp, NULL);
|
|
if (n <= 0)
|
|
return NULL;
|
|
/* This is very tricky since a file descriptor may be in the
|
|
non-blocking mode. The error flag doesn't mean much in this
|
|
case. We return an error only when there is a new error. */
|
|
int old_error = fp->_flags & _IO_ERR_SEEN;
|
|
fp->_flags &= ~_IO_ERR_SEEN;
|
|
count = _IO_getline (fp, buf, MIN ((size_t) n - 1, size), '\n', 1);
|
|
/* If we read in some bytes and errno is EAGAIN, that error will
|
|
be reported for next read. */
|
|
if (count == 0 || ((fp->_flags & _IO_ERR_SEEN) && errno != EAGAIN))
|
|
result = NULL;
|
|
else if (count >= size)
|
|
__chk_fail ();
|
|
else
|
|
{
|
|
buf[count] = '\0';
|
|
result = buf;
|
|
}
|
|
fp->_flags |= old_error;
|
|
return result;
|
|
}
|
|
libc_hidden_builtin_def (__fgets_unlocked_chk)
|