mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-27 07:20:11 +00:00
1eb8930608
This patch removes all the dynamic allocation on execvpe code and
instead use direct stack allocation. This is QoI approach to make
it possible use in scenarios where memory is shared with parent
(vfork or clone with CLONE_VM).
For default process spawn (script file without a shebang), stack
allocation is bounded by NAME_MAX plus PATH_MAX plus 1. Large
file arguments returns an error (ENAMETOOLONG). This differs than
current GLIBC pratice in general, but it used to limit stack
allocation for large inputs. Also, path in PATH environment variable
larger than PATH_MAX are ignored.
The shell direct execution exeception, where execve returns ENOEXEC,
might requires a large stack allocation due large input argument list.
Tested on i686, x86_64, powerpc64le, and aarch64.
* posix/execvpe.c (__execvpe): Remove dynamic allocation.
* posix/Makefile (tests): Add tst-execvpe{1,2,3,4,5,6}.
* posix/tst-execvp1.c (do_test): Use a macro to call execvp.
* posix/tst-execvp2.c (do_test): Likewise.
* posix/tst-execvp3.c (do_test): Likewise.
* posix/tst-execvp4.c (do_test): Likewise.
* posix/tst-execvpe1.c: New file.
* posix/tst-execvpe2.c: Likewise.
* posix/tst-execvpe3.c: Likewise.
* posix/tst-execvpe4.c: Likewise.
* posix/tst-execvpe5.c: Likewise.
* posix/tst-execvpe6.c: Likewise.
46 lines
777 B
C
46 lines
777 B
C
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <sys/stat.h>
|
|
|
|
|
|
static void do_prepare (void);
|
|
#define PREPARE(argc, argv) do_prepare ()
|
|
static int do_test (void);
|
|
#define TEST_FUNCTION do_test ()
|
|
|
|
#include "../test-skeleton.c"
|
|
|
|
#ifndef EXECVP
|
|
# define EXECVP(file, argv) execvp (file, argv)
|
|
#endif
|
|
|
|
static char *fname;
|
|
|
|
static void
|
|
do_prepare (void)
|
|
{
|
|
int fd = create_temp_file ("testscript", &fname);
|
|
dprintf (fd, "echo foo\n");
|
|
fchmod (fd, 0700);
|
|
close (fd);
|
|
}
|
|
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
if (setenv ("PATH", test_dir, 1) != 0)
|
|
{
|
|
puts ("setenv failed");
|
|
return 1;
|
|
}
|
|
|
|
char *argv[] = { fname, NULL };
|
|
EXECVP (basename (fname), argv);
|
|
|
|
/* If we come here, the execvp call failed. */
|
|
return 1;
|
|
}
|