mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-15 01:21:06 +00:00
c579f48edb
This patch remove the PID cache and usage in current GLIBC code. Current usage is mainly used a performance optimization to avoid the syscall, however it adds some issues: - The exposed clone syscall will try to set pid/tid to make the new thread somewhat compatible with current GLIBC assumptions. This cause a set of issue with new workloads and usecases (such as BZ#17214 and [1]) as well for new internal usage of clone to optimize other algorithms (such as clone plus CLONE_VM for posix_spawn, BZ#19957). - The caching complexity also added some bugs in the past [2] [3] and requires more effort of each port to handle such requirements (for both clone and vfork implementation). - Caching performance gain in mainly on getpid and some specific code paths. The getpid performance leverage is questionable [4], either by the idea of getpid being a hotspot as for the getpid implementation itself (if it is indeed a justifiable hotspot a vDSO symbol could let to a much more simpler solution). Other usage is mainly for non usual code paths, such as pthread cancellation signal and handling. For thread creation (on stack allocation) the code simplification in fact adds some performance gain due the no need of transverse the stack cache and invalidate each element pid. Other thread usages will require a direct getpid syscall, such as cancellation/setxid signal, thread cancellation, thread fail path (at create_thread), and thread signal (pthread_kill and pthread_sigqueue). However these are hardly usual hotspots and I think adding a syscall is justifiable. It also simplifies both the clone and vfork arch-specific implementation. And by review each fork implementation there are some discrepancies that this patch also solves: - microblaze clone/vfork does not set/reset the pid/tid field - hppa uses the default vfork implementation that fallback to fork. Since vfork is deprecated I do not think we should bother with it. The patch also removes the TID caching in clone. My understanding for such semantic is try provide some pthread usage after a user program issue clone directly (as done by thread creation with CLONE_PARENT_SETTID and pthread tid member). However, as stated before in multiple discussions threads, GLIBC provides clone syscalls without further supporting all this semantics. I ran a full make check on x86_64, x32, i686, armhf, aarch64, and powerpc64le. For sparc32, sparc64, and mips I ran the basic fork and vfork tests from posix/ folder (on a qemu system). So it would require further testing on alpha, hppa, ia64, m68k, nios2, s390, sh, and tile (I excluded microblaze because it is already implementing the patch semantic regarding clone/vfork). [1] https://codereview.chromium.org/800183004/ [2] https://sourceware.org/ml/libc-alpha/2006-07/msg00123.html [3] https://sourceware.org/bugzilla/show_bug.cgi?id=15368 [4] http://yarchive.net/comp/linux/getpid_caching.html * sysdeps/nptl/fork.c (__libc_fork): Remove pid cache setting. * nptl/allocatestack.c (allocate_stack): Likewise. (__reclaim_stacks): Likewise. (setxid_signal_thread): Obtain pid through syscall. * nptl/nptl-init.c (sigcancel_handler): Likewise. (sighandle_setxid): Likewise. * nptl/pthread_cancel.c (pthread_cancel): Likewise. * sysdeps/unix/sysv/linux/pthread_kill.c (__pthread_kill): Likewise. * sysdeps/unix/sysv/linux/pthread_sigqueue.c (pthread_sigqueue): Likewise. * sysdeps/unix/sysv/linux/createthread.c (create_thread): Likewise. * sysdeps/unix/sysv/linux/getpid.c: Remove file. * nptl/descr.h (struct pthread): Change comment about pid value. * nptl/pthread_getattr_np.c (pthread_getattr_np): Remove thread pid assert. * sysdeps/unix/sysv/linux/pthread-pids.h (__pthread_initialize_pids): Do not set pid value. * nptl_db/td_ta_thr_iter.c (iterate_thread_list): Remove thread pid cache check. * nptl_db/td_thr_validate.c (td_thr_validate): Likewise. * sysdeps/aarch64/nptl/tcb-offsets.sym: Remove pid offset. * sysdeps/alpha/nptl/tcb-offsets.sym: Likewise. * sysdeps/arm/nptl/tcb-offsets.sym: Likewise. * sysdeps/hppa/nptl/tcb-offsets.sym: Likewise. * sysdeps/i386/nptl/tcb-offsets.sym: Likewise. * sysdeps/ia64/nptl/tcb-offsets.sym: Likewise. * sysdeps/m68k/nptl/tcb-offsets.sym: Likewise. * sysdeps/microblaze/nptl/tcb-offsets.sym: Likewise. * sysdeps/mips/nptl/tcb-offsets.sym: Likewise. * sysdeps/nios2/nptl/tcb-offsets.sym: Likewise. * sysdeps/powerpc/nptl/tcb-offsets.sym: Likewise. * sysdeps/s390/nptl/tcb-offsets.sym: Likewise. * sysdeps/sh/nptl/tcb-offsets.sym: Likewise. * sysdeps/sparc/nptl/tcb-offsets.sym: Likewise. * sysdeps/tile/nptl/tcb-offsets.sym: Likewise. * sysdeps/x86_64/nptl/tcb-offsets.sym: Likewise. * sysdeps/unix/sysv/linux/aarch64/clone.S: Remove pid and tid caching. * sysdeps/unix/sysv/linux/alpha/clone.S: Likewise. * sysdeps/unix/sysv/linux/arm/clone.S: Likewise. * sysdeps/unix/sysv/linux/hppa/clone.S: Likewise. * sysdeps/unix/sysv/linux/i386/clone.S: Likewise. * sysdeps/unix/sysv/linux/ia64/clone2.S: Likewise. * sysdeps/unix/sysv/linux/mips/clone.S: Likewise. * sysdeps/unix/sysv/linux/nios2/clone.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/clone.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/clone.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/clone.S: Likewise. * sysdeps/unix/sysv/linux/sh/clone.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/clone.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/clone.S: Likewise. * sysdeps/unix/sysv/linux/tile/clone.S: Likewise. * sysdeps/unix/sysv/linux/x86_64/clone.S: Likewise. * sysdeps/unix/sysv/linux/aarch64/vfork.S: Remove pid set and reset. * sysdeps/unix/sysv/linux/alpha/vfork.S: Likewise. * sysdeps/unix/sysv/linux/arm/vfork.S: Likewise. * sysdeps/unix/sysv/linux/i386/vfork.S: Likewise. * sysdeps/unix/sysv/linux/ia64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/m68k/clone.S: Likewise. * sysdeps/unix/sysv/linux/m68k/vfork.S: Likewise. * sysdeps/unix/sysv/linux/mips/vfork.S: Likewise. * sysdeps/unix/sysv/linux/nios2/vfork.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/vfork.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/vfork.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/sh/vfork.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/vfork.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/tile/vfork.S: Likewise. * sysdeps/unix/sysv/linux/x86_64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/tst-clone2.c (f): Remove direct pthread struct access. (clone_test): Remove function. (do_test): Rewrite to take in consideration pid is not cached anymore.
148 lines
3.9 KiB
C
148 lines
3.9 KiB
C
/* Test if CLONE_VM does not change pthread pid/tid field (BZ #19957)
|
|
Copyright (C) 2016 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <sched.h>
|
|
#include <signal.h>
|
|
#include <string.h>
|
|
#include <stdio.h>
|
|
#include <fcntl.h>
|
|
#include <unistd.h>
|
|
#include <stddef.h>
|
|
#include <stdbool.h>
|
|
#include <stdint.h>
|
|
#include <stdlib.h>
|
|
#include <sys/types.h>
|
|
#include <sys/wait.h>
|
|
#include <sys/syscall.h>
|
|
|
|
#include <stackinfo.h> /* For _STACK_GROWS_{UP,DOWN}. */
|
|
|
|
static int do_test (void);
|
|
|
|
#define TEST_FUNCTION do_test ()
|
|
#include <test-skeleton.c>
|
|
|
|
static int sig;
|
|
static int pipefd[2];
|
|
|
|
static int
|
|
f (void *a)
|
|
{
|
|
close (pipefd[0]);
|
|
|
|
pid_t ppid = getppid ();
|
|
pid_t pid = getpid ();
|
|
pid_t tid = syscall (__NR_gettid);
|
|
|
|
if (write (pipefd[1], &ppid, sizeof ppid) != sizeof (ppid))
|
|
FAIL_EXIT1 ("write ppid failed\n");
|
|
if (write (pipefd[1], &pid, sizeof pid) != sizeof (pid))
|
|
FAIL_EXIT1 ("write pid failed\n");
|
|
if (write (pipefd[1], &tid, sizeof tid) != sizeof (tid))
|
|
FAIL_EXIT1 ("write tid failed\n");
|
|
|
|
return 0;
|
|
}
|
|
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
sig = SIGRTMIN;
|
|
sigset_t ss;
|
|
sigemptyset (&ss);
|
|
sigaddset (&ss, sig);
|
|
if (sigprocmask (SIG_BLOCK, &ss, NULL) != 0)
|
|
FAIL_EXIT1 ("sigprocmask failed: %m");
|
|
|
|
if (pipe2 (pipefd, O_CLOEXEC))
|
|
FAIL_EXIT1 ("pipe failed: %m");
|
|
|
|
int clone_flags = 0;
|
|
#ifdef __ia64__
|
|
extern int __clone2 (int (*__fn) (void *__arg), void *__child_stack_base,
|
|
size_t __child_stack_size, int __flags,
|
|
void *__arg, ...);
|
|
char st[256 * 1024] __attribute__ ((aligned));
|
|
pid_t p = __clone2 (f, st, sizeof (st), clone_flags, 0);
|
|
#else
|
|
char st[128 * 1024] __attribute__ ((aligned));
|
|
#if _STACK_GROWS_DOWN
|
|
pid_t p = clone (f, st + sizeof (st), clone_flags, 0);
|
|
#elif _STACK_GROWS_UP
|
|
pid_t p = clone (f, st, clone_flags, 0);
|
|
#else
|
|
#error "Define either _STACK_GROWS_DOWN or _STACK_GROWS_UP"
|
|
#endif
|
|
#endif
|
|
|
|
close (pipefd[1]);
|
|
|
|
if (p == -1)
|
|
FAIL_EXIT1("clone failed: %m");
|
|
|
|
pid_t ppid, pid, tid;
|
|
if (read (pipefd[0], &ppid, sizeof pid) != sizeof pid)
|
|
{
|
|
kill (p, SIGKILL);
|
|
FAIL_EXIT1 ("read ppid failed: %m");
|
|
}
|
|
if (read (pipefd[0], &pid, sizeof pid) != sizeof pid)
|
|
{
|
|
kill (p, SIGKILL);
|
|
FAIL_EXIT1 ("read pid failed: %m");
|
|
}
|
|
if (read (pipefd[0], &tid, sizeof tid) != sizeof tid)
|
|
{
|
|
kill (p, SIGKILL);
|
|
FAIL_EXIT1 ("read tid failed: %m");
|
|
}
|
|
|
|
close (pipefd[0]);
|
|
|
|
int ret = 0;
|
|
|
|
pid_t own_pid = getpid ();
|
|
pid_t own_tid = syscall (__NR_gettid);
|
|
|
|
/* Some sanity checks for clone syscall: returned ppid should be current
|
|
pid and both returned tid/pid should be different from current one. */
|
|
if ((ppid != own_pid) || (pid == own_pid) || (tid == own_tid))
|
|
FAIL_RET ("ppid=%i pid=%i tid=%i | own_pid=%i own_tid=%i",
|
|
(int)ppid, (int)pid, (int)tid, (int)own_pid, (int)own_tid);
|
|
|
|
int e;
|
|
if (waitpid (p, &e, __WCLONE) != p)
|
|
{
|
|
kill (p, SIGKILL);
|
|
FAIL_EXIT1 ("waitpid failed");
|
|
}
|
|
if (!WIFEXITED (e))
|
|
{
|
|
if (WIFSIGNALED (e))
|
|
printf ("died from signal %s\n", strsignal (WTERMSIG (e)));
|
|
else
|
|
puts ("did not terminate correctly");
|
|
exit (EXIT_FAILURE);
|
|
}
|
|
if (WEXITSTATUS (e) != 0)
|
|
FAIL_EXIT1 ("exit code %d", WEXITSTATUS (e));
|
|
|
|
return ret;
|
|
}
|