mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-26 23:10:06 +00:00
e442e40de5
With internal fcntl64 internal (commit 06ab719d
), it is possible to
consolidate lockf implementation by using the LFS fcntl interface
instead of using arch and system-specific implementations.
For Linux, the i386 implementation is used as generic implementation
by replacing the direct syscall with fcntl64 call. The LFS symbol
alias for default LFS ABI (__OFF_T_MATCHES_OFF64_T) is used to avoid
the duplicate symbol (instead of overriding the implementation with an
empty file).
For Hurd lockf64 semantic is changed: previous generic lockf64
implementation returned EOVERFLOW if LEN input is larger than 32-bit
off_t. However, Hurd fcntl64 implementation for F_GETLK64, F_SETLK64,
and F_SETLKW64 do accept off64_t inputs (__f_setlk accepts only off64_t
inputs).
Checked on i686-linux-gnu and x86_64-linux-gnu along with a i686-gnu
build.
* io/Makefile (tests): Add tst-lockf.
* io/lockf.c (lockf): Use __fcntl and only define for
!__OFF_T_MATCHES_OFF64_T.
* io/lockf64.c (__lockf64): Call __fcntl64 and alias to lockf for
__OFF_T_MATCHES_OFF64_T case.
* io/tst-lockf.c: New file.
* sysdeps/unix/sysv/linux/i386/lockf64.c: Remove file.
* sysdeps/unix/sysv/linux/arm/lockf64.c: Likewise.
* sysdeps/unix/sysv/linux/m68k/lockf64.c: Likewise.
* sysdeps/unix/sysv/linux/mips/mips32/lockf64.c: Likewise.
* sysdeps/unix/sysv/linux/mips/mips64/n32/lockf64.c: Likewise.
* sysdeps/unix/sysv/linux/powerpc/powerpc32/lockf64.c: Likewise.
* sysdeps/unix/sysv/linux/s390/s390-32/lockf64.c: Likewise.
* sysdeps/unix/sysv/linux/sh/lockf64.c: Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc32/lockf64.c: Likewise.
139 lines
4.7 KiB
C
139 lines
4.7 KiB
C
/* Test POSIX lock on an open file (lockf).
|
|
Copyright (C) 2019 Free Software Foundation, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU General Public License
|
|
as published by the Free Software Foundation; either version 2
|
|
of the License, or (at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <unistd.h>
|
|
#include <stdint.h>
|
|
#include <errno.h>
|
|
#include <stdio.h>
|
|
|
|
#include <support/temp_file.h>
|
|
#include <support/capture_subprocess.h>
|
|
#include <support/check.h>
|
|
|
|
static char *temp_filename;
|
|
static int temp_fd;
|
|
|
|
static void
|
|
do_prepare (int argc, char **argv)
|
|
{
|
|
temp_fd = create_temp_file ("tst-lockfd.", &temp_filename);
|
|
TEST_VERIFY_EXIT (temp_fd != -1);
|
|
}
|
|
#define PREPARE do_prepare
|
|
|
|
static void
|
|
do_test_child_lockf (void *closure)
|
|
{
|
|
/* Check if parent has [0, 1024) locked. */
|
|
TEST_COMPARE (lseek (temp_fd, 0, SEEK_SET), 0);
|
|
TEST_COMPARE (lockf (temp_fd, F_TLOCK, 1024), -1);
|
|
TEST_COMPARE (errno, EAGAIN);
|
|
TEST_COMPARE (lockf (temp_fd, F_TEST, 1024), -1);
|
|
TEST_COMPARE (errno, EACCES);
|
|
/* Also Check if parent has last 1024 bytes locked. */
|
|
TEST_COMPARE (lseek (temp_fd, INT32_MAX-1024, SEEK_SET), INT32_MAX-1024);
|
|
TEST_COMPARE (lockf (temp_fd, F_TEST, 1024), -1);
|
|
|
|
/* And try to lock [1024, 2048). */
|
|
TEST_COMPARE (lseek (temp_fd, 1024, SEEK_SET), 1024);
|
|
TEST_COMPARE (lockf (temp_fd, F_LOCK, 1024), 0);
|
|
|
|
/* Check if non-LFS interface cap access to 32-bif off_t. */
|
|
TEST_COMPARE (lseek64 (temp_fd, (off64_t)INT32_MAX, SEEK_SET),
|
|
(off64_t)INT32_MAX);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), 0);
|
|
}
|
|
|
|
static void
|
|
do_test_child_lockf64 (void *closure)
|
|
{
|
|
/* Check if parent has [0, 1024) locked. */
|
|
TEST_COMPARE (lseek64 (temp_fd, 0, SEEK_SET), 0);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_TLOCK, 1024), -1);
|
|
TEST_COMPARE (errno, EAGAIN);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), -1);
|
|
TEST_COMPARE (errno, EACCES);
|
|
/* Also Check if parent has last 1024 bytes locked. */
|
|
TEST_COMPARE (lseek64 (temp_fd, INT32_MAX-1024, SEEK_SET), INT32_MAX-1024);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), -1);
|
|
|
|
/* And try to lock [1024, 2048). */
|
|
TEST_COMPARE (lseek64 (temp_fd, 1024, SEEK_SET), 1024);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
|
|
|
|
/* And also [INT32_MAX, INT32_MAX+1024). */
|
|
{
|
|
off64_t off = (off64_t)INT32_MAX;
|
|
TEST_COMPARE (lseek64 (temp_fd, off, SEEK_SET), off);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
|
|
}
|
|
|
|
/* Check if [INT32_MAX+1024, INT64_MAX) is locked. */
|
|
{
|
|
off64_t off = (off64_t)INT32_MAX+1024;
|
|
TEST_COMPARE (lseek64 (temp_fd, off, SEEK_SET), off);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_TLOCK, 1024), -1);
|
|
TEST_COMPARE (errno, EAGAIN);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), -1);
|
|
TEST_COMPARE (errno, EACCES);
|
|
}
|
|
}
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
/* Basic tests to check if a lock can be obtained and checked. */
|
|
TEST_COMPARE (lockf (temp_fd, F_LOCK, 1024), 0);
|
|
TEST_COMPARE (lockf (temp_fd, F_LOCK, INT32_MAX), 0);
|
|
TEST_COMPARE (lockf (temp_fd, F_TLOCK, 1024), 0);
|
|
TEST_COMPARE (lockf (temp_fd, F_TEST, 1024), 0);
|
|
TEST_COMPARE (lseek (temp_fd, 1024, SEEK_SET), 1024);
|
|
TEST_COMPARE (lockf (temp_fd, F_ULOCK, 1024), 0);
|
|
/* Parent process should have ([0, 1024), [2048, INT32_MAX)) ranges locked. */
|
|
|
|
{
|
|
struct support_capture_subprocess result;
|
|
result = support_capture_subprocess (do_test_child_lockf, NULL);
|
|
support_capture_subprocess_check (&result, "lockf", 0, sc_allow_none);
|
|
}
|
|
|
|
if (sizeof (off_t) != sizeof (off64_t))
|
|
{
|
|
/* Check if previously locked regions with LFS symbol. */
|
|
TEST_COMPARE (lseek (temp_fd, 0, SEEK_SET), 0);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_TLOCK, 1024), 0);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), 0);
|
|
/* Lock region [INT32_MAX+1024, INT64_MAX). */
|
|
off64_t off = (off64_t)INT32_MAX + 1024;
|
|
TEST_COMPARE (lseek64 (temp_fd, off, SEEK_SET), off);
|
|
TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
|
|
/* Parent process should have ([0, 1024), [2048, INT32_MAX),
|
|
[INT32_MAX+1024, INT64_MAX)) ranges locked. */
|
|
|
|
{
|
|
struct support_capture_subprocess result;
|
|
result = support_capture_subprocess (do_test_child_lockf64, NULL);
|
|
support_capture_subprocess_check (&result, "lockf", 0, sc_allow_none);
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|