mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-14 01:00:07 +00:00
c4f50205e1
This patch fixes various places where a space should have been present before '(' in accordance with the GNU Coding Standards. Most but not all of the fixes in this patch are for calls to sizeof (but it's not exhaustive regarding such calls that should be fixed). Tested for x86_64, and with build-many-glibcs.py. * benchtests/bench-strcpy.c (do_test): Use space before '('. * benchtests/bench-string.h (cmdline_process_function): Likewise. * benchtests/bench-strlen.c (do_test): Likewise. (test_main): Likewise. * catgets/gencat.c (read_old): Likewise. * elf/cache.c (load_aux_cache): Likewise. * iconvdata/bug-iconv8.c (do_test): Likewise. * math/test-tgmath-ret.c (do_test): Likewise. * nis/nis_call.c (rec_dirsearch): Likewise. * nis/nis_findserv.c (__nis_findfastest_with_timeout): Likewise. * nptl/tst-audit-threads.c (do_test): Likewise. * nptl/tst-cancel4-common.h (set_socket_buffer): Likewise. * nss/nss_test1.c (init): Likewise. * nss/test-netdb.c (test_hosts): Likewise. * posix/execvpe.c (maybe_script_execute): Likewise. * stdio-common/tst-fmemopen4.c (do_test): Likewise. * stdio-common/tst-printf.c (do_test): Likewise. * stdio-common/vfscanf-internal.c (__vfscanf_internal): Likewise. * stdlib/fmtmsg.c (NKEYWORDS): Likewise. * stdlib/qsort.c (STACK_SIZE): Likewise. * stdlib/test-canon.c (do_test): Likewise. * stdlib/tst-swapcontext1.c (do_test): Likewise. * string/memcmp.c (OPSIZ): Likewise. * string/test-strcpy.c (do_test): Likewise. (do_random_tests): Likewise. * string/test-strlen.c (do_test): Likewise. (test_main): Likewise. * string/test-strrchr.c (do_test): Likewise. (do_random_tests): Likewise. * string/tester.c (test_memrchr): Likewise. (test_memchr): Likewise. * sysdeps/generic/memcopy.h (OPSIZ): Likewise. * sysdeps/generic/unwind-dw2.c (execute_stack_op): Likewise. * sysdeps/generic/unwind-pe.h (read_sleb128): Likewise. (read_encoded_value_with_base): Likewise. * sysdeps/hppa/dl-machine.h (elf_machine_runtime_setup): Likewise. * sysdeps/hppa/fpu/feupdateenv.c (__feupdateenv): Likewise. * sysdeps/ia64/fpu/sfp-machine.h (TI_BITS): Likewise. * sysdeps/mach/hurd/spawni.c (__spawni): Likewise. * sysdeps/posix/spawni.c (maybe_script_execute): Likewise. * sysdeps/powerpc/fpu/tst-setcontext-fpscr.c (query_auxv): Likewise. * sysdeps/unix/sysv/linux/aarch64/bits/procfs.h (ELF_NGREG): Likewise. * sysdeps/unix/sysv/linux/arm/bits/procfs.h (ELF_NGREG): Likewise. * sysdeps/unix/sysv/linux/arm/ioperm.c (init_iosys): Likewise. * sysdeps/unix/sysv/linux/csky/bits/procfs.h (ELF_NGREG): Likewise. * sysdeps/unix/sysv/linux/m68k/bits/procfs.h (ELF_NGREG): Likewise. * sysdeps/unix/sysv/linux/nios2/bits/procfs.h (ELF_NGREG): Likewise. * sysdeps/unix/sysv/linux/spawni.c (maybe_script_execute): Likewise. * sysdeps/unix/sysv/linux/x86/bits/procfs.h (ELF_NGREG): Likewise. * sysdeps/unix/sysv/linux/x86/bits/sigcontext.h (FP_XSTATE_MAGIC2_SIZE): Likewise. * sysdeps/x86/fpu/sfp-machine.h (TI_BITS): Likewise. * time/test_time.c (main): Likewise.
168 lines
3.6 KiB
C
168 lines
3.6 KiB
C
/* Test and measure STRLEN functions.
|
|
Copyright (C) 1999-2019 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Written by Jakub Jelinek <jakub@redhat.com>, 1999.
|
|
Added wcslen support by Liubov Dmitrieva <liubov.dmitrieva@gmail.com>, 2011
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#define TEST_MAIN
|
|
#ifndef WIDE
|
|
# define TEST_NAME "strlen"
|
|
#else
|
|
# define TEST_NAME "wcslen"
|
|
#endif
|
|
#include "test-string.h"
|
|
|
|
#ifndef WIDE
|
|
# define STRLEN strlen
|
|
# define CHAR char
|
|
# define MAX_CHAR CHAR_MAX
|
|
#else
|
|
# include <wchar.h>
|
|
# define STRLEN wcslen
|
|
# define CHAR wchar_t
|
|
# define MAX_CHAR WCHAR_MAX
|
|
#endif
|
|
|
|
typedef size_t (*proto_t) (const CHAR *);
|
|
|
|
size_t
|
|
simple_STRLEN (const CHAR *s)
|
|
{
|
|
const CHAR *p;
|
|
|
|
for (p = s; *p; ++p);
|
|
return p - s;
|
|
}
|
|
|
|
#ifndef WIDE
|
|
size_t
|
|
builtin_strlen (const CHAR *p)
|
|
{
|
|
return __builtin_strlen (p);
|
|
}
|
|
IMPL (builtin_strlen, 0)
|
|
#endif
|
|
|
|
IMPL (simple_STRLEN, 0)
|
|
IMPL (STRLEN, 1)
|
|
|
|
|
|
static void
|
|
do_one_test (impl_t *impl, const CHAR *s, size_t exp_len)
|
|
{
|
|
size_t len = CALL (impl, s);
|
|
if (len != exp_len)
|
|
{
|
|
error (0, 0, "Wrong result in function %s %zd %zd", impl->name,
|
|
len, exp_len);
|
|
ret = 1;
|
|
return;
|
|
}
|
|
}
|
|
|
|
static void
|
|
do_test (size_t align, size_t len)
|
|
{
|
|
size_t i;
|
|
|
|
align &= 63;
|
|
if (align + sizeof (CHAR) * len >= page_size)
|
|
return;
|
|
|
|
CHAR *buf = (CHAR *) (buf1);
|
|
|
|
for (i = 0; i < len; ++i)
|
|
buf[align + i] = 1 + 11111 * i % MAX_CHAR;
|
|
buf[align + len] = 0;
|
|
|
|
FOR_EACH_IMPL (impl, 0)
|
|
do_one_test (impl, (CHAR *) (buf + align), len);
|
|
}
|
|
|
|
static void
|
|
do_random_tests (void)
|
|
{
|
|
size_t i, j, n, align, len;
|
|
CHAR *p = (CHAR *) (buf1 + page_size - 512 * sizeof (CHAR));
|
|
|
|
for (n = 0; n < ITERATIONS; n++)
|
|
{
|
|
align = random () & 15;
|
|
len = random () & 511;
|
|
if (len + align > 510)
|
|
len = 511 - align - (random () & 7);
|
|
j = len + align + 64;
|
|
if (j > 512)
|
|
j = 512;
|
|
|
|
for (i = 0; i < j; i++)
|
|
{
|
|
if (i == len + align)
|
|
p[i] = 0;
|
|
else
|
|
{
|
|
p[i] = random () & 255;
|
|
if (i >= align && i < len + align && !p[i])
|
|
p[i] = (random () & 127) + 1;
|
|
}
|
|
}
|
|
|
|
FOR_EACH_IMPL (impl, 1)
|
|
if (CALL (impl, (CHAR *) (p + align)) != len)
|
|
{
|
|
error (0, 0, "Iteration %zd - wrong result in function %s (%zd) %zd != %zd, p %p",
|
|
n, impl->name, align, CALL (impl, (CHAR *) (p + align)),
|
|
len, p);
|
|
ret = 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
int
|
|
test_main (void)
|
|
{
|
|
size_t i;
|
|
|
|
test_init ();
|
|
|
|
printf ("%20s", "");
|
|
FOR_EACH_IMPL (impl, 0)
|
|
printf ("\t%s", impl->name);
|
|
putchar ('\n');
|
|
|
|
/* Checking with only 4 * N alignments for wcslen, other alignments are wrong for wchar_t type arrays*/
|
|
|
|
for (i = 1; i < 8; ++i)
|
|
{
|
|
do_test (sizeof (CHAR) * i, i);
|
|
do_test (0, i);
|
|
}
|
|
|
|
for (i = 2; i <= 12; ++i)
|
|
{
|
|
do_test (0, 1 << i);
|
|
do_test (sizeof (CHAR) * 7, 1 << i);
|
|
do_test (sizeof (CHAR) * i, 1 << i);
|
|
do_test (sizeof (CHAR) * i, (size_t)((1 << i) / 1.5));
|
|
}
|
|
|
|
do_random_tests ();
|
|
return ret;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|