AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-12-03 10:21:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
68507377f2
glibc/string
History
Noah Goldstein a910d7e164 x86: Shrink code size of memchr-avx2.S 
This is not meant as a performance optimization. The previous code was
far to liberal in aligning targets and wasted code size unnecissarily.

The total code size saving is: 59 bytes

There are no major changes in the benchmarks.
Geometric Mean of all benchmarks New / Old: 0.967

Full xcheck passes on x86_64.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

(cherry picked from commit 6dcbb7d95d)

x86: Fix page cross case in rawmemchr-avx2 [BZ #29234]

commit 6dcbb7d95d
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Mon Jun 6 21:11:33 2022 -0700

    x86: Shrink code size of memchr-avx2.S

Changed how the page cross case aligned string (rdi) in
rawmemchr. This was incompatible with how
`L(cross_page_continue)` expected the pointer to be aligned and
would cause rawmemchr to read data start started before the
beginning of the string. What it would read was in valid memory
but could count CHAR matches resulting in an incorrect return
value.

This commit fixes that issue by essentially reverting the changes to
the L(page_cross) case as they didn't really matter.

Test cases added and all pass with the new code (and where confirmed
to fail with the old code).
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

(cherry picked from commit 2c9af8421d)
2022-07-18 20:45:21 -07:00
..
bits string.h: fix __fortified_attr_access macro call [BZ #29162] 2022-05-23 14:06:31 +05:30
_strerror.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz-addsep.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz-append.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz-count.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz-create.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz-ctsep.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz-delete.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz-extract.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz-insert.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz-next.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz-replace.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz-stringify.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
argz.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
basename.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
bcopy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
bug-envz1.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
bug-strcoll1.c Update. 2001-04-26 20:45:18 +00:00
bug-strcoll2.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
bug-strncat1.c Fix string/bug-strncat1.c build with GCC 8. 2017-11-14 17:50:36 +00:00
bug-strpbrk1.c Fix bug-strspn1.c, bug-strpbrk1.c build with GCC mainline. 2018-06-20 22:18:22 +00:00
bug-strspn1.c Fix bug-strspn1.c, bug-strpbrk1.c build with GCC mainline. 2018-06-20 22:18:22 +00:00
bug-strtok1.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
byteswap.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
bzero.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Depend Update. 2001-03-19 21:40:15 +00:00
endian.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
envz.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
envz.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
explicit_bzero.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
ffs.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
ffsll.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
inl-tester.c Update. 1997-09-11 12:09:10 +00:00
Makefile dlfcn: Cleanups after -ldl is no longer required 2021-06-03 09:11:45 +02:00
memccpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
memchr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
memcmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
memcpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
memfrob.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
memmem.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
memmove.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
memory.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
mempcpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
memrchr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
memset.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
noinl-tester.c Update. 1997-09-16 00:42:43 +00:00
rawmemchr.c string: Work around GCC PR 98512 in rawmemchr 2021-02-19 13:29:00 +01:00
sigabbrev_np.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
sigdescr_np.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
stpcpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
stpncpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
str-two-way.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
stratcliff.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strcasecmp_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strcasecmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strcasestr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strcat.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strchr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strchrnul.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strcmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strcoll_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strcoll.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strcpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strcspn.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strdup.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strerror_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strerror.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strerrordesc_np.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strerrorname_np.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strfry.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
string-inlines.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
string.h Don't add access size hints to fortifiable functions 2022-03-11 20:36:24 +05:30
strings.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strlen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strncase_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strncase.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strncat.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strncmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strncpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strndup.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strnlen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strpbrk.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strrchr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strsep.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strsignal.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strspn.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strstr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strtok_r.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strtok.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strverscmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strxfrm_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
strxfrm.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
swab.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-bcopy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-bzero.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-endian-file-scope.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-endian-sign-conversion.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-endian-types.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-explicit_bzero.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-ffs.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-memccpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-memchr.c String: Add overflow tests for strnlen, memchr, and strncat [BZ #27974] 2021-06-23 14:13:00 -04:00
test-memcmp.c x86: Expand bench-memcmp.c and test-memcmp.c 2021-05-18 22:57:39 -04:00
test-memcpy.c x86: Expanding test-memmove.c, test-memcpy.c, bench-memcpy-large.c 2021-04-16 12:09:56 -07:00
test-memmem.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-memmove.c Reindent string/test-memmove.c 2021-04-19 17:46:05 -07:00
test-mempcpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-memrchr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-memset.c x86: Expand test-memset.c and bench-memset.c 2021-04-19 15:08:04 -07:00
test-rawmemchr.c x86: Shrink code size of memchr-avx2.S 2022-07-18 20:45:21 -07:00
test-sig_np.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-stpcpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-stpncpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strcasecmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strcasestr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strcat.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strchr.c strchr: Add additional benchmarks and tests 2021-02-08 11:34:00 -08:00
test-strchrnul.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strcmp.c x86-64: Use notl in EVEX strcmp [BZ #28646] 2022-04-26 18:18:16 -07:00
test-strcpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strcspn.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strerror-errno.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-string.h tests: use xmalloc to allocate implementation array 2021-07-28 17:45:19 +05:30
test-strlen.c Improve test coverage of strlen function 2021-06-02 05:37:43 -07:00
test-strncasecmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strncat.c String: Add overflow tests for strnlen, memchr, and strncat [BZ #27974] 2021-06-23 14:13:00 -04:00
test-strncmp.c x86: Fix bug in strncmp-evex and strncmp-avx2 [BZ #28895] 2022-05-05 09:11:49 -07:00
test-strncpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strnlen.c String: Add three more overflow tests cases to test-strnlen.c 2021-06-24 19:14:15 -04:00
test-strpbrk.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strrchr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strspn.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strstr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
testcopy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tester.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-bswap.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-endian.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-inlcall.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-memmove-overflow.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-strcoll-overflow.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-strerror.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-strfry.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strlen.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strsignal.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-strtok_r.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-strtok.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strxfrm2.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strxfrm.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-svc2.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-svc.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-svc.expect * string/strverscmp.c (__strverscmp): Fix last cleanups. 2009-04-07 06:51:59 +00:00
tst-svc.input * string/strverscmp.c (__strverscmp): Fix last cleanups. 2009-04-07 06:51:59 +00:00
tst-xbzero-opt.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Versions string: Add strerrorname_np and strerrordesc_np 2020-07-07 15:02:57 -03:00
wordcopy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
xpg-strerror.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00