mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-27 07:20:11 +00:00
27d83441a2
The behavior of the signal mask on threads created by timer_create for SIGEV_THREAD timers are implementation-defined and glibc explicit unblocks all signals before calling the user-defined function. This behavior, although not incorrect standard-wise, opens a race if a program using a blocked rt-signal plus sigwaitinfo (and without an installed signal handler for the rt-signal) receives a signal while executing the used-defined function for SIGEV_THREAD. A better alternative discussed in bug report is to rather block all signals (besides the internal ones not available to application usage). This patch fixes this issue by only unblocking SIGSETXID (used on set*uid function) and SIGCANCEL (used for thread cancellation). Checked on x86_64-linux-gnu and i686-linux-gnu.
112 lines
3.2 KiB
C
112 lines
3.2 KiB
C
/* Special use of signals internally. Linux version.
|
|
Copyright (C) 2014-2020 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef __INTERNAL_SIGNALS_H
|
|
# define __INTERNAL_SIGNALS_H
|
|
|
|
#include <signal.h>
|
|
#include <sigsetops.h>
|
|
#include <stdbool.h>
|
|
#include <limits.h>
|
|
#include <sysdep.h>
|
|
|
|
/* The signal used for asynchronous cancelation. */
|
|
#define SIGCANCEL __SIGRTMIN
|
|
|
|
|
|
/* Signal needed for the kernel-supported POSIX timer implementation.
|
|
We can reuse the cancellation signal since we can distinguish
|
|
cancellation from timer expirations. */
|
|
#define SIGTIMER SIGCANCEL
|
|
|
|
|
|
/* Signal used to implement the setuid et.al. functions. */
|
|
#define SIGSETXID (__SIGRTMIN + 1)
|
|
|
|
|
|
/* Return is sig is used internally. */
|
|
static inline bool
|
|
__is_internal_signal (int sig)
|
|
{
|
|
return (sig == SIGCANCEL) || (sig == SIGSETXID);
|
|
}
|
|
|
|
/* Remove internal glibc signal from the mask. */
|
|
static inline void
|
|
__clear_internal_signals (sigset_t *set)
|
|
{
|
|
__sigdelset (set, SIGCANCEL);
|
|
__sigdelset (set, SIGSETXID);
|
|
}
|
|
|
|
static const sigset_t sigall_set = {
|
|
.__val = {[0 ... _SIGSET_NWORDS-1 ] = -1 }
|
|
};
|
|
|
|
static const sigset_t sigtimer_set = {
|
|
.__val = { [0] = __sigmask (SIGTIMER),
|
|
[1 ... _SIGSET_NWORDS-1] = 0 }
|
|
};
|
|
|
|
/* Block all signals, including internal glibc ones. */
|
|
static inline void
|
|
__libc_signal_block_all (sigset_t *set)
|
|
{
|
|
INTERNAL_SYSCALL_CALL (rt_sigprocmask, SIG_BLOCK, &sigall_set, set,
|
|
_NSIG / 8);
|
|
}
|
|
|
|
/* Block all application signals (excluding internal glibc ones). */
|
|
static inline void
|
|
__libc_signal_block_app (sigset_t *set)
|
|
{
|
|
sigset_t allset = sigall_set;
|
|
__clear_internal_signals (&allset);
|
|
INTERNAL_SYSCALL_CALL (rt_sigprocmask, SIG_BLOCK, &allset, set,
|
|
_NSIG / 8);
|
|
}
|
|
|
|
/* Block only SIGTIMER and return the previous set on SET. */
|
|
static inline void
|
|
__libc_signal_block_sigtimer (sigset_t *set)
|
|
{
|
|
INTERNAL_SYSCALL_CALL (rt_sigprocmask, SIG_BLOCK, &sigtimer_set, set,
|
|
_NSIG / 8);
|
|
}
|
|
|
|
/* Unblock only SIGTIMER and return the previous set on SET. */
|
|
static inline void
|
|
__libc_signal_unblock_sigtimer (sigset_t *set)
|
|
{
|
|
INTERNAL_SYSCALL_CALL (rt_sigprocmask, SIG_UNBLOCK, &sigtimer_set, set,
|
|
_NSIG / 8);
|
|
}
|
|
|
|
/* Restore current process signal mask. */
|
|
static inline void
|
|
__libc_signal_restore_set (const sigset_t *set)
|
|
{
|
|
INTERNAL_SYSCALL_CALL (rt_sigprocmask, SIG_SETMASK, set, NULL,
|
|
_NSIG / 8);
|
|
}
|
|
|
|
/* Used to communicate with signal handler. */
|
|
extern struct xid_command *__xidcmd attribute_hidden;
|
|
|
|
#endif
|