mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-26 23:10:06 +00:00
4a3d39994e
The natural fix for some linknamespace test failures, where C90 libm functions call C99 <fenv.h> functions, is to make fe* into weak aliases for __fe* and call __fe* from within libm as needed. To do this, the __fe* names need to be available for that purpose - that is, they must not be used for something other than aliases of fe*. On powerpc, however, __fegetround is an inline function in fenv_libc.h, with no corresponding fegetround inline function; fegetround has an equivalent macro expansion in bits/fenvinline.h, but that is disabled if __NO_MATH_INLINES (which is defined for building libm). I see no need for that disabling; it's not even clear that __NO_MATH_INLINES should affect <fenv.h>, and the results of fegetround are completely defined so there is no semantic effect of that disabling at all outside glibc. The x86 inline feraiseexcept is conditioned on __USE_EXTERN_INLINES not __NO_MATH_INLINES (but that's an inline function rather than a macro). This patch removes the __NO_MATH_INLINES conditional on that fegetround macro, so resulting in it being expanded inline inside glibc. In turn, this means that direct calls to __fegetround from C99 functions in ldbl-128ibm can be changed to calls to fegetround, so that nofpu fenv_libc.h files don't need to define __fegetround at all and, by changing ldbl-128ibm files to use <fenv.h> not <fenv_libc.h>, non-e500 nofpu no longer needs an fenv_libc.h file. The other macros in fenvinline.h are left conditional on __NO_MATH_INLINES, although since the only case where this should make a difference is one involving undefined behavior (if the argument to the function is not a valid exception macro). The out-of-line definition for fegetround uses __fegetround (the inline function removed by this patch). So this continues to work, the fenvinline.h header is made to define __fegetround, and then to define fegetround to call __fegetround. Tested for powerpc32 (hard float) that installed stripped shared libraries are unchanged by this patch; also tested that powerpc-nofpu build still works. (This patch does not itself fix any bugs; it simply cleans things up in preparation for separate bug fixes.) * sysdeps/powerpc/bits/fenvinline.h (fegetround): Rename macro to __fegetround and redefine to call __fegetround. Remove condition on [!__NO_MATH_INLINES]. * sysdeps/powerpc/fpu/fenv_libc.h (__fegetround): Remove inline function. * sysdeps/powerpc/nofpu/fenv_libc.h: Remove file. * sysdeps/powerpc/powerpc32/e500/nofpu/fenv_libc.h (__fegetround): Remove macro. * sysdeps/ieee754/ldbl-128ibm/s_llrintl.c: Include <fenv.h> instead of <fenv_libc.h>. (__llrintl): Call fegetround instead of __fegetround. * sysdeps/ieee754/ldbl-128ibm/s_llroundl.c: Include <fenv.h> instead of <fenv_libc.h>. * sysdeps/ieee754/ldbl-128ibm/s_lrintl.c: Likewise. (__lrintl): Call fegetround instead of __fegetround. * sysdeps/ieee754/ldbl-128ibm/s_lroundl.c: Include <fenv.h> instead of <fenv_libc.h>. * sysdeps/ieee754/ldbl-128ibm/s_rintl.c: Likewise. (__rintl): Call fegetround instead of __fegetround. |
||
|---|---|---|
| .. | ||
| e_acoshl.c | ||
| e_acosl.c | ||
| e_asinl.c | ||
| e_atan2l.c | ||
| e_atanhl.c | ||
| e_coshl.c | ||
| e_exp10l.c | ||
| e_expl.c | ||
| e_fmodl.c | ||
| e_gammal_r.c | ||
| e_hypotl.c | ||
| e_ilogbl.c | ||
| e_j0l.c | ||
| e_j1l.c | ||
| e_jnl.c | ||
| e_lgammal_r.c | ||
| e_log2l.c | ||
| e_log10l.c | ||
| e_logl.c | ||
| e_powl.c | ||
| e_rem_pio2l.c | ||
| e_remainderl.c | ||
| e_sinhl.c | ||
| e_sqrtl.c | ||
| gamma_productl.c | ||
| ieee754.h | ||
| k_cosl.c | ||
| k_sincosl.c | ||
| k_sinl.c | ||
| k_tanl.c | ||
| ldbl2mpn.c | ||
| Makefile | ||
| math_ldbl.h | ||
| mpn2ldbl.c | ||
| printf_fphex.c | ||
| s_asinhl.c | ||
| s_atanl.c | ||
| s_cbrtl.c | ||
| s_ceill.c | ||
| s_copysignl.c | ||
| s_cosl.c | ||
| s_cprojl.c | ||
| s_ctanhl.c | ||
| s_ctanl.c | ||
| s_erfl.c | ||
| s_expm1l.c | ||
| s_fabsl.c | ||
| s_finitel.c | ||
| s_floorl.c | ||
| s_fmal.c | ||
| s_fpclassifyl.c | ||
| s_frexpl.c | ||
| s_isinf_nsl.c | ||
| s_isinfl.c | ||
| s_isnanl.c | ||
| s_issignalingl.c | ||
| s_llrintl.c | ||
| s_llroundl.c | ||
| s_log1pl.c | ||
| s_logbl.c | ||
| s_lrintl.c | ||
| s_lroundl.c | ||
| s_modfl.c | ||
| s_nearbyintl.c | ||
| s_nextafterl.c | ||
| s_nexttoward.c | ||
| s_nexttowardf.c | ||
| s_remquol.c | ||
| s_rintl.c | ||
| s_roundl.c | ||
| s_scalblnl.c | ||
| s_scalbnl.c | ||
| s_signbitl.c | ||
| s_sincosl.c | ||
| s_sinl.c | ||
| s_tanhl.c | ||
| s_tanl.c | ||
| s_truncl.c | ||
| strtold_l.c | ||
| t_sincosl.c | ||
| w_expl.c | ||
| w_scalblnl.c | ||
| x2y2m1l.c | ||