glibc/sunrpc
Zack Weinberg 11160cb76f Installed-header hygiene (BZ#20366): obsolete BSD u_* types.
The types u_char, u_short, u_int, u_long, ushort, uint, ulong, u_int8_t,
u_int16_t, u_int32_t, u_int64_t, quad_t, and u_quad_t are BSDisms that
have never been standardized.  While glibc should continue to *provide*
these types for compatibility's sake, its public headers should not
use them.

The meat of this change was mechanically generated by the following
shell command:

    perl -pi~ -e '
        s/\b(__)?u_char\b/unsigned char/g;
        s/\b(__)?u_?short\b/unsigned short/g;
        s/\b(__)?u_?int\b/unsigned int/g;
        s/\b(__)?u_?long\b/unsigned long/g;
        s/\b(__)?u_int8_t\b/uint8_t/g;
        s/\b(__)?u_int16_t\b/uint16_t/g;
        s/\b(__)?u_int32_t\b/uint32_t/g;
        s/\b(__)?u_int64_t\b/uint64_t/g;
        s/\b(__)?u_quad_t\b/uint64_t/g;
        s/\b(__)?quad_t\b/uint64_t/g;
    ' $(grep -lE -e '\<((__)?(quad_t|u(short|int|long|_(char|short|int([0-9]+_t)?|long|quad_t))))\>' \
        $(grep -LE '\<(_(SYS|BITS)_TYPES_H|rpc/(rpc|rpc_msg|types|xdr)\.h)\>' \
          $(find . \( -false $(sed 's/^/-o -name /' all-installed-headers) \
                   \) -printf '%P\n' | sort -u)))

where 'all-installed-headers' was a list of the basenames of all installed
header files, manually extracted from the Makefiles.  Non-installed
wrapper headers in include/ are also adjusted, for consistency.
I then manually fixed up indentation and line-wrapping.

sys/types.h and bits/types.h are excluded because they must continue
to define the u_* types (under __USE_MISC) for compatibility with
applications.  They do not use these types themselves.

All headers that (transitively) include rpc/types.h are also excluded,
for three reasons.  First, the u_* types are defined by rpc/types.h,
unconditionally (not just under __USE_MISC) so they are logically part
of the SunRPC API.  Second, many of those headers appear to be
machine-generated.  Third, it's my understanding that we are getting
rid of as much of SunRPC as possible in the near future.

(The one file under sunrpc/ that's touched, sunrpc/rpc/rpc_des.h, does
*not* include rpc/types.h.  This may itself be a bug.)

After changing from u_intNN_t to uintNN_t, a number of headers now
need to include stdint.h to pick up those types.  It might be more
hygenic, namespace-wise, to use __uintNN_t instead, but none of these
headers are bound by ISO or POSIX to do so, and it's unlikely that
anyone using them will be bothered.  (The two files that were using
__-prefixed versions of the u_types, sysdeps/mach/hurd/net/route.h and
sysdeps/unix/sysv/linux/net/route.h, both already also contained uses of
the unprefixed versions.)

Some of these files directly included features.h and/or sys/cdefs.h,
which I removed, as the style generally seems to be to let sys/types.h
do that for us.  (This does not change the set of definitions exposed
by any header; sys/types.h unconditionally includes both features.h
and sys/cdefs.h.)

One file included asm/types.h unnecessarily.

	* bits/in.h, gmon/sys/gmon.h, inet/netinet/igmp.h
	* inet/protocols/routed.h, inet/protocols/talkd.h
	* inet/protocols/timed.h, io/fts.h, nptl_db/thread_db.h
	* resolv/arpa/nameser.h, resolv/resolv.h, sunrpc/rpc/rpc_des.h
	* sysdeps/generic/netinet/if_ether.h
	* sysdeps/generic/netinet/in_systm.h
	* sysdeps/generic/netinet/ip.h, sysdeps/generic/netinet/tcp.h
	* sysdeps/gnu/netinet/ip_icmp.h, sysdeps/gnu/netinet/tcp.h
	* sysdeps/gnu/netinet/udp.h, sysdeps/mach/hurd/net/ethernet.h
	* sysdeps/mach/hurd/net/if_arp.h
	* sysdeps/mach/hurd/net/if_ppp.h
	* sysdeps/mach/hurd/net/route.h, sysdeps/mach/sys/reboot.h
	* sysdeps/unix/sysv/linux/bits/in.h
	* sysdeps/unix/sysv/linux/net/ethernet.h
	* sysdeps/unix/sysv/linux/net/if_arp.h
	* sysdeps/unix/sysv/linux/net/if_ppp.h
	* sysdeps/unix/sysv/linux/net/if_shaper.h
	* sysdeps/unix/sysv/linux/net/route.h
	* sysdeps/unix/sysv/linux/netinet/if_ether.h
	* sysdeps/unix/sysv/linux/netinet/if_fddi.h
	* sysdeps/unix/sysv/linux/netinet/if_tr.h
	* sysdeps/unix/sysv/linux/netipx/ipx.h
	* sysdeps/unix/sysv/linux/sys/acct.h
	* include/arpa/nameser.h, include/resolv.h:
	Change all uses of u_char to unsigned char,
	u_short and ushort to unsigned short, u_int and uint to unsigned int,
	u_long and ulong to unsigned long, u_int8_t to uint8_t,
        u_int16_t to uint16_t, u_int32_t to uint32_t, quad_t to int64_t,
	and u_int64_t and u_quad_t to uint64_t.

	* mach/sys/reboot.h: Remove two casts of integer literals
	to the types they already have.

	* bits/in.h: Correct error in description of IP_MULTICAST_LOOP.
	* sysdeps/unix/sysv/linux/bits/in.h: Likewise.
	* sysdeps/unix/sysv/linux/netinet/if_ether.h: Change a comment
	from referring to 'unsigned char' to 'uint8_t' for consistency with
	the macro definition below.

	* gmon/sys/gmon.h, inet/netinet/igmp.h, inet/protocols/talkd.h
	* io/fts.h, resolv/arpa/nameser.h, resolv/resolv.h
	* sunrpc/rpc/rpc_des.h, sysdeps/generic/netinet/ip.h
	* sysdeps/gnu/netinet/tcp.h, sysdeps/gnu/netinet/udp.h
	* sysdeps/mach/hurd/net/if_ppp.h, sysdeps/unix/sysv/linux/net/if_ppp.h
	* sysdeps/unix/sysv/linux/sys/acct.h
	* include/arpa/nameser.h, include/resolv.h:
	Fix indentation disrupted by mechanical edits.

	* inet/protocols/talkd.h, resolv/arpa/nameser.h
	* sysdeps/generic/netinet/in_systm.h
	* sysdeps/gnu/netinet/ip_icmp.h, sysdeps/gnu/netinet/tcp.h
	* sysdeps/gnu/netinet/udp.h
	* sysdeps/unix/sysv/linux/net/ethernet.h
	* sysdeps/unix/sysv/linux/net/if_arp.h
	* sysdeps/unix/sysv/linux/net/if_ppp.h
	* sysdeps/unix/sysv/linux/net/if_shaper.h
	* sysdeps/unix/sysv/linux/netinet/if_fddi.h
	* sysdeps/unix/sysv/linux/netinet/if_tr.h
	* sysdeps/unix/sysv/linux/netipx/ipx.h
	* sysdeps/unix/sysv/linux/sys/acct.h
	Include stdint.h for uintNN_t definitions.
	Don't include sys/cdefs.h, features.h, or asm/types.h directly.
2016-09-23 08:43:56 -04:00
..
rpc Installed-header hygiene (BZ#20366): obsolete BSD u_* types. 2016-09-23 08:43:56 -04:00
rpcsvc Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
auth_des.c Add #include <stdint.h> for uint[32|64]_t usage (except installed headers). 2013-05-16 11:32:54 -05:00
auth_none.c Move bits/libc-lock.h and bits/libc-lockP.h out of bits/ (bug 14912). 2015-09-08 21:11:03 +00:00
auth_unix.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
authdes_prot.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
authuxprot.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
bindrsvprt.c Move bits/libc-lock.h and bits/libc-lockP.h out of bits/ (bug 14912). 2015-09-08 21:11:03 +00:00
clnt_gen.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
clnt_perr.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
clnt_raw.c Convert 69 more function definitions to prototype style (line wrap cases). 2015-10-19 21:23:47 +00:00
clnt_simp.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
clnt_tcp.c Convert 69 more function definitions to prototype style (line wrap cases). 2015-10-19 21:23:47 +00:00
clnt_udp.c CVE-2016-4429: sunrpc: Do not use alloca in clntudp_call [BZ #20112] 2016-05-23 20:18:34 +02:00
clnt_unix.c Convert 69 more function definitions to prototype style (line wrap cases). 2015-10-19 21:23:47 +00:00
create_xid.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
des_crypt.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
des_impl.c Replace FSF snail mail address with URLs. 2012-02-09 23:18:22 +00:00
des_soft.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
etc.rpc * sunrpc/etc.rpc (fedfs_admin): Add entry. 2012-12-05 19:45:23 -07:00
get_myaddr.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
getrpcbyname_r.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getrpcbyname.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getrpcbynumber_r.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getrpcbynumber.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getrpcent_r.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getrpcent.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getrpcport.c Once again change RPC copyright notices. 2010-08-19 10:38:55 -07:00
key_call.c sunrpc: In key_call_keyenvoy, use int status instead of union wait 2016-03-08 10:04:24 +01:00
key_prot.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
Makefile Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
netname.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
openchild.c Remove use of INTDEF/INTUSE in libio 2012-05-24 23:06:20 +02:00
pm_getmaps.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
pm_getport.c Convert miscellaneous function definitions to prototype style. 2015-10-20 21:27:22 +00:00
pmap_clnt.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
pmap_prot2.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
pmap_prot.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
pmap_rmt.c Convert a few more function definitions to prototype style. 2015-10-21 11:57:23 +00:00
proto.h Support --with-pkgversion and --with-bugurl. 2012-11-09 22:13:45 +00:00
publickey.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
rpc_clntout.c sunrpc: fix rpc bootstrap builds 2012-07-06 00:37:42 -04:00
rpc_cmsg.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
rpc_common.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
rpc_cout.c Remove __GNU_LIBRARY__ conditionals from rpcgen. 2012-03-09 22:46:12 +00:00
rpc_dtable.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
rpc_hout.c Fix some -Wformat warnings in rpcgen. 2012-07-26 14:35:05 -07:00
rpc_main.c Document rpcgen -5. Fixes bug 15825 2013-10-21 10:02:31 +02:00
rpc_parse.c Once again change RPC copyright notices. 2010-08-19 10:38:55 -07:00
rpc_parse.h Avoid nested comment. 2010-08-24 11:56:51 -07:00
rpc_prot.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
rpc_sample.c Once again change RPC copyright notices. 2010-08-19 10:38:55 -07:00
rpc_scan.c Once again change RPC copyright notices. 2010-08-19 10:38:55 -07:00
rpc_scan.h Once again change RPC copyright notices. 2010-08-19 10:38:55 -07:00
rpc_svcout.c Fix some -Wformat warnings in rpcgen. 2012-07-26 14:35:05 -07:00
rpc_tblout.c Once again change RPC copyright notices. 2010-08-19 10:38:55 -07:00
rpc_thread.c sunrpc: Rewrite with explicit TLS access using __thread 2015-10-17 12:07:04 +02:00
rpc_util.c Once again change RPC copyright notices. 2010-08-19 10:38:55 -07:00
rpc_util.h Once again change RPC copyright notices. 2010-08-19 10:38:55 -07:00
rpcgen.c Use standard build rule to build rpcgen. 2012-03-10 00:56:21 +00:00
rpcinfo.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
rtime.c Add #include <stdint.h> for uint[32|64]_t usage (except installed headers). 2013-05-16 11:32:54 -05:00
svc_auth.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
svc_authux.c Obsolete RPC implementation in libc. 2011-04-16 21:59:36 -04:00
svc_raw.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
svc_run.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
svc_simple.c Fix sunrpc static library 2012-05-21 21:34:54 +02:00
svc_tcp.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
svc_udp.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
svc_unix.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
svc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
svcauth_des.c Add #include <stdint.h> for uint[32|64]_t usage (except installed headers). 2013-05-16 11:32:54 -05:00
test-rpcent.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
thrsvc.c Update. 2002-10-14 18:10:15 +00:00
tst-getmyaddr.c Update. 2004-09-28 23:08:14 +00:00
tst-xdrmem2.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-xdrmem.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
Versions Exclude rpcent functions and NSS backends for rpc, key when excluding sunrpc. 2015-02-06 10:43:19 -08:00
xcrypt.c Fix sunrpc static library 2012-05-21 21:34:54 +02:00
xdr_array.c Convert miscellaneous function definitions to prototype style. 2015-10-20 21:27:22 +00:00
xdr_float.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
xdr_intXX_t.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
xdr_mem.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
xdr_rec.c Add #include <stdint.h> for uint[32|64]_t usage (except installed headers). 2013-05-16 11:32:54 -05:00
xdr_ref.c Convert miscellaneous function definitions to prototype style. 2015-10-20 21:27:22 +00:00
xdr_sizeof.c Make sunrpc code usable again 2012-05-10 20:19:53 +02:00
xdr_stdio.c Remove use of INTDEF/INTUSE in libio 2012-05-24 23:06:20 +02:00
xdr.c Convert miscellaneous function definitions to prototype style. 2015-10-20 21:27:22 +00:00