glibc/string
Adhemerval Zanella 3abeeec5f4 Fix i686 memchr overflow calculation (BZ#21182)
This patch fixes the regression added by 23d2770 for final address
overflow calculation.  The subtraction of the considered size (16)
at line 120 is at wrong place, for sizes less than 16 subsequent
overflow check will not take in consideration an invalid size (since
the subtraction will be negative).  Also, the lea instruction also
does not raise the carry flag (CF) that is used in subsequent jbe
to check for overflow.

The fix is to follow x86_64 logic from 3daef2c where the overflow
is first check and a sub instruction is issued.  In case of resulting
negative size, CF will be set by the sub instruction and a NULL
result will be returned.  The patch also add similar tests reported
in bug report.

Checked on i686-linux-gnu and x86_64-linux-gnu.

	* string/test-memchr.c (do_test): Add BZ#21182 checks for address
	near end of a page.
	* sysdeps/i386/i686/multiarch/memchr-sse2.S (__memchr): Fix
	overflow calculation.
2017-03-29 09:54:14 -03:00
..
bits Remove the str(n)dup inlines from string/bits/string2.h. Although inlining 2017-03-13 18:45:42 +00:00
_strerror.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz-addsep.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz-append.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz-count.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz-create.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz-ctsep.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz-delete.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz-extract.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz-insert.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz-next.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz-replace.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz-stringify.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
argz.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
basename.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bcopy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bug-envz1.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
bug-strcoll1.c Update. 2001-04-26 20:45:18 +00:00
bug-strcoll2.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
bug-strncat1.c * malloc/memusagestat.c (main): Use return instead of exit to 2000-12-31 10:52:32 +00:00
bug-strpbrk1.c * malloc/memusagestat.c (main): Use return instead of exit to 2000-12-31 10:52:32 +00:00
bug-strspn1.c * malloc/memusagestat.c (main): Use return instead of exit to 2000-12-31 10:52:32 +00:00
bug-strtok1.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
byteswap.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bzero.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
Depend Update. 2001-03-19 21:40:15 +00:00
endian.h Make endian-conversion macros always return correct types (bug 16458). 2017-01-11 15:28:08 +00:00
envz.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
envz.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
explicit_bzero.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
ffs.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
ffsll.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
inl-tester.c Update. 1997-09-11 12:09:10 +00:00
Makefile string/tst-strcoll-overflow: Do not accept timeout as test result 2017-01-25 16:27:03 +01:00
memccpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
memchr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
memcmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
memcpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
memfrob.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
memmem.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
memmove.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
memory.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
mempcpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
memrchr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
memset.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
noinl-tester.c Update. 1997-09-16 00:42:43 +00:00
rawmemchr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
stpcpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
stpncpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
str-two-way.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
stratcliff.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
strcasecmp_l.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strcasecmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strcasestr.c Miscellaneous low-risk changes preparing for _ISOMAC testsuite. 2017-03-01 20:32:50 -05:00
strcat.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strchr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strchrnul.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strcmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strcoll_l.c Narrowing the visibility of libc-internal.h even further. 2017-03-01 20:33:46 -05:00
strcoll.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strcpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strcspn.c Narrowing the visibility of libc-internal.h even further. 2017-03-01 20:33:46 -05:00
strdup.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strerror_l.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strerror.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strfry.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
string-inlines.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
string.h Remove C++ namespace handling from glibc headers. 2017-03-16 13:31:57 +00:00
strings.h Clean up redundancies between string.h and strings.h. 2017-02-16 17:02:50 -05:00
strlen.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strncase_l.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strncase.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strncat.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strncmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strncpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strndup.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strnlen.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strpbrk.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strrchr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strsep.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strsignal.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strspn.c Narrowing the visibility of libc-internal.h even further. 2017-03-01 20:33:46 -05:00
strstr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strtok_r.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strtok.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strverscmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strxfrm_l.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strxfrm.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
swab.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
test-bcopy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
test-bzero.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
test-endian-types.c Make endian-conversion macros always return correct types (bug 16458). 2017-01-11 15:28:08 +00:00
test-explicit_bzero.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
test-ffs.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-memccpy.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-memchr.c Fix i686 memchr overflow calculation (BZ#21182) 2017-03-29 09:54:14 -03:00
test-memcmp.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-memcpy.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-memmem.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-memmove.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-mempcpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
test-memrchr.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-memset.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-rawmemchr.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-stpcpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
test-stpncpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
test-strcasecmp.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strcasestr.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strcat.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strchr.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strchrnul.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
test-strcmp.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strcpy.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strcspn.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
test-string.h Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strlen.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strncasecmp.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strncat.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strncmp.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strncpy.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strnlen.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strpbrk.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strrchr.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strspn.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
test-strstr.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
testcopy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
tester.c Split DIAG_* macros to new header libc-diag.h. 2017-02-25 09:59:46 -05:00
tst-bswap.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-cmp.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-endian.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-inlcall.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strcoll-overflow.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strfry.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strlen.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strtok_r.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strtok.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strxfrm2.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strxfrm.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-svc2.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-svc.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-svc.expect * string/strverscmp.c (__strverscmp): Fix last cleanups. 2009-04-07 06:51:59 +00:00
tst-svc.input * string/strverscmp.c (__strverscmp): Fix last cleanups. 2009-04-07 06:51:59 +00:00
tst-xbzero-opt.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
Versions New string function explicit_bzero (from OpenBSD). 2016-12-16 16:21:54 -05:00
wordcopy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpg-strerror.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00