AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-12-02 09:40:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
76f71081cd
glibc/sysdeps/unix/sysv/linux/tile
History
Joseph Myers ea41469b7a Fix profil_counter namespace (bug 17725). 
On ARM, where profil_counter is not static, it is brought in by
references to various standard functions, as noted in
<https://sourceware.org/ml/libc-alpha/2014-11/msg00890.html>, although
it is not a standard function itself.  I don't know if this also
causes test failures on SPARC, although I see no reason for it not to
do so.

This patch fixes this namespace issue.  profil_counter is renamed to
__profil_counter and made a weak alias on ARM and SPARC.  Because of
the uses in profil.c / sprofil.c it seems simplest to make the rename
globally, including on the other architectures for which
profil_counter was static and so the change is of no substance.  The
variant names profil_counter_* used in sprofil.c are also renamed to
start with __ so that undesired function names do not get exported in
static libc.

As I noted in bug 17726, profil_counter should probably be a compat
symbol on ARM and SPARC, so it wouldn't exist at all in static libc
even as a weak alias.  Since defining a compat symbol still requires
an internal name as a target of an alias, this patch still seems
reasonable as an intermediate step towards that goal: it wouldn't be
possible for the function simply to be static profil_counter on ARM
and SPARC with profil_counter also being the exported compat symbol
name, so profil.c / sprofil.c would still need to be prepared to call
the function under another name (here, __profil_counter).

Tested for x86_64 (testsuite, and that stripped installed shared
libraries are unchanged by the patch) and ARM (ABI and linknamespace
tests - this patch reduces the number of linknamespace failures I see
on ARM from 227 to 5, the residue being math.h failures for fe*
functions and for j0l/j1n/jnl/y0l/y1l/ynl aliases).

2014-12-17  Joseph Myers  <joseph@codesourcery.com>

	[BZ #17725]
	* sysdeps/generic/profil-counter.h (profil_counter): Rename to
	__profil_counter.
	* sysdeps/unix/sysv/linux/hppa/profil-counter.h (profil_counter):
	Likewise.
	* sysdeps/unix/sysv/linux/i386/profil-counter.h (profil_counter):
	Likewise.
	* sysdeps/unix/sysv/linux/ia64/profil-counter.h (profil_counter):
	Likewise.
	* sysdeps/unix/sysv/linux/s390/s390-32/profil-counter.h
	(profil_counter): Likewise.
	* sysdeps/unix/sysv/linux/s390/s390-64/profil-counter.h
	(profil_counter): Likewise.
	* sysdeps/unix/sysv/linux/sh/profil-counter.h (profil_counter):
	Likewise.
	* sysdeps/unix/sysv/linux/tile/profil-counter.h (profil_counter):
	Likewise.
	* sysdeps/unix/sysv/linux/x86_64/profil-counter.h
	(profil_counter): Likewise.
	* sysdeps/unix/sysv/linux/arm/profil-counter.h (profil_counter):
	Likewise.
	[!__profil_counter] (profil_counter): Define as weak alias of
	__profil_counter.
	* sysdeps/unix/sysv/linux/sparc/sparc32/profil-counter.h
	(profil_counter): Rename to __profil_counter.
	[!__profil_counter] (profil_counter): Define as weak alias of
	__profil_counter.
	* sysdeps/unix/sysv/linux/sparc/sparc64/profil-counter.h
	(profil_counter): Rename to __profil_counter.
	[!__profil_counter] (profil_counter): Define as weak alias of
	__profil_counter.
	* sysdeps/posix/profil.c: Update comment referring to
	profil_counter.
	(__profil): Use __profil_counter instead of profil_counter.
	* sysdeps/posix/sprofil.c (profil_counter): Rename to
	__profil_counter.  Use __profil_counter_ushort and
	__profil_counter_uint in definitions.
	(__sprofil): Use __profil_counter_uint and __profil_counter_ushort
	instead of profil_counter_uint and profil_counter_ushort.
2014-12-17 18:10:37 +00:00
..
bits tile: add clock_gettime support via vDSO 2014-10-06 11:22:14 -04:00
sys
tilegx tile: move sysdeps/unix/sysv/linux/tile nptl files. 2014-06-10 14:10:17 -04:00
tilepro tile: move sysdeps/unix/sysv/linux/tile nptl files. 2014-06-10 14:10:17 -04:00
arch-fork.h tile: Convert fork.c to arch-fork.h 2014-05-28 14:23:16 -04:00
cacheflush.c
clone.S tile: make the prolog of clone() more conformant 2014-10-06 11:21:29 -04:00
dl-static.c
getcontext.S
gettimeofday.c tile: add clock_gettime support via vDSO 2014-10-06 11:22:14 -04:00
Implies NPTL is no longer an add-on! 2014-07-07 09:29:06 -07:00
init-first.c tile: add clock_gettime support via vDSO 2014-10-06 11:22:14 -04:00
kernel-features.h Reduce kernel-features.h duplication. 2014-05-14 00:45:19 +00:00
ldsodefs.h
makecontext.c
Makefile tile: move sysdeps/unix/sysv/linux/tile nptl files. 2014-06-10 14:10:17 -04:00
profil-counter.h Fix profil_counter namespace (bug 17725). 2014-12-17 18:10:37 +00:00
pt-vfork.c tile: Consolidate NPTL/non versions of vfork 2014-06-11 15:52:53 -04:00
set_dataplane.c
setcontext.S
shlib-versions Remove configuration name patterns from shlib-versions. 2014-09-12 12:28:47 +00:00
sigcontextinfo.h
swapcontext.S
syscall.S
sysconf.c tile: add support for _SC_LEVEL*CACHE* sysconf() queries 2014-10-06 11:20:30 -04:00
sysdep-cancel.h Remove NOT_IN_libc 2014-11-24 15:03:45 +05:30
sysdep.c
sysdep.h Remove NOT_IN_libc 2014-11-24 15:03:45 +05:30
ucontext_i.h
Versions tile: add clock_gettime support via vDSO 2014-10-06 11:22:14 -04:00
vfork.S tile: Consolidate NPTL/non versions of vfork 2014-06-11 15:52:53 -04:00
waitpid.S Remove NOT_IN_libc 2014-11-24 15:03:45 +05:30