mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-12 14:20:13 +00:00
78880cc185
After some discussion in libc-alpha about this POSIX compliance fix, I see
that GLIBC should indeed revert back to previous definition of msghdr and
cmsghdr and implementation of sendmsg, recvmsg, sendmmsg, recvmmsg due some
reasons:
* The possible issue where the syscalls wrapper add the compatibility
layer is quite limited in scope and range. And kernel current
also add some limits to the values on the internal msghdr and
cmsghdr fields:
- msghdr::msg_iovlen larger than UIO_MAXIOV (1024) returns
EMSGSIZE.
- msghdr::msg_controllen larger than INT_MAX returns ENOBUFS.
* There is a small performance hit for recvmsg/sendmsg/recmmsg which
is neglectable, but it is a big hit for sendmmsg since now instead
of calling the syscall for the packed structure, GLIBC is calling
multiple sendmsg. This defeat the very existence of the syscall.
* It currently breaks libsanitizer build on GCC [1] (I fixed on compiler-rt).
However the fix is incomplete because it does add any runtime check
since libsanitizer currently does not have any facility to intercept
symbols with multiple version [2].
This, along with incorret dlsym/dlvsym return for versioned symbol due
another bug [3], makes hard to interpose versioned symbols.
Also, current approach of fixing GCC PR#71445 leads to half-baked
solutions without versioned symbol interposing.
This patch basically reverts commits
|
||
|---|---|---|
| .. | ||
| ____longjmp_chk.S | ||
| __longjmp.S | ||
| __start_context.S | ||
| brk.S | ||
| bsd-_setjmp.S | ||
| bsd-setjmp.S | ||
| c++-types.data | ||
| clone.S | ||
| configure | ||
| configure.ac | ||
| dl-brk.S | ||
| dl-cache.h | ||
| dl-fxstatat64.c | ||
| fxstat.c | ||
| fxstatat.c | ||
| get_clockfreq.c | ||
| getcontext.S | ||
| Implies | ||
| kernel_stat.h | ||
| ld.abilist | ||
| libanl.abilist | ||
| libBrokenLocale.abilist | ||
| libc.abilist | ||
| libcrypt.abilist | ||
| libdl.abilist | ||
| libm.abilist | ||
| libnsl.abilist | ||
| libpthread.abilist | ||
| libresolv.abilist | ||
| librt.abilist | ||
| libthread_db.abilist | ||
| libutil.abilist | ||
| localplt.data | ||
| longjmp.S | ||
| lxstat.c | ||
| makecontext.c | ||
| Makefile | ||
| msgrcv.c | ||
| pause.c | ||
| personality.c | ||
| pipe.S | ||
| profil-counter.h | ||
| register-dump.h | ||
| semctl.c | ||
| setcontext.S | ||
| setjmp.S | ||
| shlib-versions | ||
| sigaction.c | ||
| sigcontextinfo.h | ||
| sigjmp.S | ||
| sigpending.c | ||
| sigprocmask.c | ||
| sizes.h | ||
| swapcontext.c | ||
| syscall.S | ||
| syscalls.list | ||
| sysdep-cancel.h | ||
| sysdep.h | ||
| time.c | ||
| timer_create.c | ||
| timer_delete.c | ||
| timer_getoverr.c | ||
| timer_gettime.c | ||
| timer_settime.c | ||
| ucontext_i.h | ||
| Versions | ||
| vfork.S | ||
| wordexp.c | ||
| xstat.c | ||
| xstatconv.c | ||