mirror of
https://sourceware.org/git/glibc.git
synced 2025-01-12 04:00:17 +00:00
7a25d6a84d
The x86-specific versions of both pthread_cond_wait and pthread_cond_timedwait have (in their fall-back-to-futex-wait slow paths) calls to __pthread_mutex_cond_lock_adjust followed by __pthread_mutex_unlock_usercnt, which load the parameters before the first call but then assume that the first parameter, in %eax, will survive unaffected. This happens to have been true before now, but %eax is a call-clobbered register, and this assumption is not safe: it could change at any time, at GCC's whim, and indeed the stack-protector canary checking code clobbers %eax while checking that the canary is uncorrupted. So reload %eax before calling __pthread_mutex_unlock_usercnt. (Do this unconditionally, even when stack-protection is not in use, because it's the right thing to do, it's a slow path, and anything else is dicing with death.) * sysdeps/unix/sysv/linux/i386/pthread_cond_timedwait.S: Reload call-clobbered %eax on retry path. * sysdeps/unix/sysv/linux/i386/pthread_cond_wait.S: Likewise. |
||
---|---|---|
.. | ||
alpha | ||
arm | ||
bsd | ||
i386 | ||
inet | ||
mips | ||
powerpc | ||
sh | ||
sysv/linux | ||
x86_64 | ||
clock_gettime.c | ||
clock_nanosleep.c | ||
clock_settime.c | ||
confstr.h | ||
get_child_max.c | ||
getlogin_r.c | ||
getlogin.c | ||
getpagesize.c | ||
grantpt.c | ||
ifreq.c | ||
Implies | ||
make-syscalls.sh | ||
Makefile | ||
s-proto-cancel.S | ||
s-proto.S | ||
setxid.h | ||
sockatmark.c | ||
stime.c | ||
syscall-template.S | ||
syscall.S | ||
syscalls.list | ||
sysdep.h |