Go to file
Adhemerval Zanella 805334b26c posix: Clear close-on-exec for posix_spawn adddup2 (BZ#23640)
Austin Group issue #411 [1] proposes that posix_spawn file action
posix_spawn_file_actions_adddup2 resets the close-on-exec when
source and destination refer to same file descriptor.

It solves the issue on multi-thread applications which uses
close-on-exec as default, and want to hand-chose specifically
file descriptor to purposefully inherited into a child process.
Current approach to achieve this scenario is to use two adddup2 file
actions and a temporary file description which do not conflict with
any other, coupled with a close file action to avoid leaking the
temporary file descriptor.  This approach, besides being complex,
may fail with EMFILE/ENFILE file descriptor exaustion.

This can be more easily accomplished with an in-place removal of
FD_CLOEXEC.  Although the resulting adddup2 semantic is slight
different than dup2 (equal file descriptors should be handled as
no-op), the proposed possible solution are either more complex
(fcntl action which a limited set of operations) or results in
unrequired operations (dup3 which also returns EINVAL for same
file descriptor).

Checked on aarch64-linux-gnu.

	[BZ #23640]
	* posix/tst-spawn.c (do_prepare, handle_restart, do_test): Add
	posix_spawn_file_actions_adddup2 test to check O_CLOCEXEC reset.
	* sysdeps/unix/sysv/linux/spawni.c (__spawni_child): Add
	close-on-exec reset for adddup2 file action.
	* sysdeps/posix/spawni.c (__spawni_child): Likewise.

[1] http://austingroupbugs.net/view.php?id=411
2019-01-03 14:38:01 -02:00
argp Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
assert Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
benchtests Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
bits Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
catgets Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
ChangeLog.old Add missing reference to bug 21654 2017-10-07 13:14:36 +02:00
conform Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
crypt Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
csu Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
ctype Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
debug Set behavior of sprintf-like functions with overlapping source and destination 2019-01-02 13:53:52 -02:00
dirent Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
dlfcn Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
elf Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
gmon Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
gnulib Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
grp Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
gshadow Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
hesiod Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
htl Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
hurd Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iconv Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
iconvdata Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
include Use C99-compliant scanf under _GNU_SOURCE with modern compilers. 2019-01-03 11:12:39 -05:00
inet Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
intl intl: Do not return NULL on asprintf failure in gettext [BZ #24018] 2019-01-02 16:26:58 +01:00
io Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
libio Use C99-compliant scanf under _GNU_SOURCE with modern compilers. 2019-01-03 11:12:39 -05:00
locale Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
localedata bs_BA: Fix a small typo in comment (bug 24011). 2019-01-02 23:50:49 +01:00
login Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
mach Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
malloc Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
manual Update miscellaneous files from upstream sources. 2019-01-01 00:52:59 +00:00
math Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mathvec Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
misc Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
nis Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
nptl nptl/tst-audit-threads: Switch to <support/test-driver.c> 2019-01-02 16:09:26 +01:00
nptl_db Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
nscd Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
nss Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
po Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
posix posix: Clear close-on-exec for posix_spawn adddup2 (BZ#23640) 2019-01-03 14:38:01 -02:00
pwd Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
resolv Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
resource Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
rt Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
scripts Update miscellaneous files from upstream sources. 2019-01-01 00:52:59 +00:00
setjmp Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
shadow Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
signal Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
socket Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
soft-fp Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
stdio-common Use C99-compliant scanf under _GNU_SOURCE with modern compilers. 2019-01-03 11:12:39 -05:00
stdlib Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
streams Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
string Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sunrpc Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
support Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sysdeps posix: Clear close-on-exec for posix_spawn adddup2 (BZ#23640) 2019-01-03 14:38:01 -02:00
sysvipc Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
termios Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
time Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
timezone Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
wcsmbs Use C99-compliant scanf under _GNU_SOURCE with modern compilers. 2019-01-03 11:12:39 -05:00
wctype Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
.gitattributes Assume __NR_openat is always defined 2016-03-23 23:35:08 +01:00
.gitignore Add *.pyc to .gitignore 2015-05-18 15:26:26 +05:30
abi-tags Remove the bulk of the NaCl port. 2017-05-20 08:09:10 -04:00
aclocal.m4 LIBC_SLIBDIR_RTLDDIR: substitute arguments in single quotes 2018-01-25 17:20:28 +01:00
ChangeLog posix: Clear close-on-exec for posix_spawn adddup2 (BZ#23640) 2019-01-03 14:38:01 -02:00
config.h.in Add C-SKY port 2018-12-21 09:48:04 +08:00
config.make.in Fix ifunc support with DT_TEXTREL segments (BZ#20480) 2018-09-25 16:27:50 -03:00
configure Require GCC 5 or later to build glibc (bug 23993). 2018-12-21 17:53:40 +00:00
configure.ac Require GCC 5 or later to build glibc (bug 23993). 2018-12-21 17:53:40 +00:00
COPYING
COPYING.LIB
extra-lib.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
gen-locales.mk Improve gen-locales.mk and gen-locale.sh to make test files with @ options work 2018-02-27 17:01:57 +01:00
INSTALL Require GCC 5 or later to build glibc (bug 23993). 2018-12-21 17:53:40 +00:00
libc-abis libc-abis: Define ABSOLUTE ABI [BZ #19818][BZ #23307] 2018-07-05 18:06:43 +01:00
libof-iterator.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
LICENSES stdio-common/tst-printf.c: Remove part under a non-free license [BZ #23363] 2018-07-03 18:29:16 +02:00
MAINTAINERS Add MAINTAINERS 2017-05-11 13:38:30 -04:00
Makeconfig Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
Makefile Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
Makefile.in New make target to only build benchmark binaries 2016-04-20 10:23:28 +05:30
Makerules Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
NEWS Use C99-compliant scanf under _GNU_SOURCE with modern compilers. 2019-01-03 11:12:39 -05:00
o-iterator.mk
README Add C-SKY port 2018-12-21 09:48:04 +08:00
Rules Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
shlib-versions Extend NSS test suite 2017-07-17 15:52:44 -04:00
test-skeleton.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
version.h Open master branch for glibc 2.29 development 2018-08-01 01:35:02 -04:00

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arm-*-linux-gnueabi
	csky-*-linux-gnuabiv2
	hppa-*-linux-gnu
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	ia64-*-linux-gnu
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	riscv64-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see http://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at http://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see http://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.