mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-14 07:10:05 +00:00
aaacde11f2
<limits.h> used to be a header file with no declarations. GCC's libgomp includes it in a #pragma GCC visibility hidden block. Including <unistd.h> from <limits.h> (indirectly) declares everything in <unistd.h> with hidden visibility, resulting in linker failures. This commit avoids C declarations in assembler mode and only declares __sysconf in <limits.h> (and not the entire contents of <unistd.h>). The __sysconf symbol is already part of the ABI. PTHREAD_STACK_MIN is no longer defined for __USE_DYNAMIC_STACK_SIZE && __ASSEMBLER__ because there is no possible definition. Additionally, PTHREAD_STACK_MIN is now defined by <pthread.h> for __USE_MISC because this is what developers expect based on the macro name. It also helps to avoid libgomp linker failures in GCC because libgomp includes <pthread.h> before its visibility hacks. Reviewed-by: Carlos O'Donell <carlos@redhat.com>
50 lines
1.6 KiB
C
50 lines
1.6 KiB
C
/* Test that pthread_exit works with the minimum stack size.
|
|
Copyright (C) 2018-2021 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
/* Note: This test is similar to tst-minstack-cancel, but is separate
|
|
to avoid spurious test passes due to warm-up effects. */
|
|
|
|
#include <limits.h>
|
|
#include <unistd.h>
|
|
#include <support/check.h>
|
|
#include <support/xthread.h>
|
|
|
|
_Static_assert (__SC_THREAD_STACK_MIN_VALUE == _SC_THREAD_STACK_MIN,
|
|
"__SC_THREAD_STACK_MIN_VALUE is correct");
|
|
|
|
static void *
|
|
threadfunc (void *closure)
|
|
{
|
|
pthread_exit (threadfunc);
|
|
return NULL;
|
|
}
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
pthread_attr_t attr;
|
|
xpthread_attr_init (&attr);
|
|
xpthread_attr_setstacksize (&attr, PTHREAD_STACK_MIN);
|
|
pthread_t thr = xpthread_create (&attr, threadfunc, NULL);
|
|
TEST_VERIFY (xpthread_join (thr) == threadfunc);
|
|
xpthread_attr_destroy (&attr);
|
|
return 0;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|