mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-23 03:10:05 +00:00
8540f6d2a7
One wart in the original support for test wrappers for cross testing, as noted in <https://sourceware.org/ml/libc-alpha/2012-10/msg00722.html>, is the requirement for test wrappers to pass a poorly-defined set of environment variables from the build system to the system running the glibc under test. Although some variables are passed explicitly via $(test-wrapper-env), including LD_* variables that simply can't be passed implicitly because of the side effects they'd have on the build system's dynamic linker, others are passed implicitly, including variables such as GCONV_PATH and LOCPATH that could potentially affect the build system's libc (so effectively relying on any such effects not breaking the wrappers). In addition, the code in cross-test-ssh.sh for preserving environment variables is fragile (it depends on how bash formats a list of exported variables, and could well break for multi-line variable definitions where the contents contain things looking like other variable definitions). This patch moves to explicitly passing environment variables via $(test-wrapper-env). Makefile variables that previously used $(test-wrapper) are split up into -before-env and -after-env parts that can be passed separately to the various .sh files used in testing, so those files can then insert environment settings between the two parts. The common default environment settings in make-test-out are made into a separate makefile variable that can also be passed to scripts, rather than many scripts duplicating those settings (for testing an installed glibc, it is desirable to have the GCONV_PATH setting on just one place, so just that one place needs to support it pointing to an installed sysroot instead of the build tree). The default settings are included in the variables such as $(test-program-prefix), so that if tests do not need any non-default settings they can continue to use single variables rather than the split-up variables. Although this patch cleans up LC_ALL=C settings (that being part of the common defaults), various LANG=C and LANGUAGE=C settings remain. Those are generally unnecessary and I propose a subsequent cleanup to remove them. LC_ALL takes precedence over LANG, and while LANGUAGE takes precedence over LC_ALL, it only does so for settings other than LC_ALL=C. So LC_ALL=C on its own is sufficient to ensure the C locale, and anything that gets LC_ALL=C does not need the other settings. While preparing this patch I noticed some tests with .sh files that appeared to do nothing beyond what the generic makefile support for tests can do (localedata/tst-wctype.sh - the makefiles support -ENV variables and .input files - and localedata/tst-mbswcs.sh - just runs five tests that could be run individually from the makefile). So I propose another subsequent cleanup to move those to using the generic support instead of special .sh files. Tested x86_64 (native) and powerpc32 (cross). * Makeconfig (run-program-env): New variable. (run-program-prefix-before-env): Likewise. (run-program-prefix-after-env): Likewise. (run-program-prefix): Define in terms of new variables. (built-program-cmd-before-env): New variable. (built-program-cmd-after-env): Likewise. (built-program-cmd): Define in terms of new variables. (test-program-prefix-before-env): New variable. (test-program-prefix-after-env): Likewise. (test-program-prefix): Define in terms of new variables. (test-program-cmd-before-env): New variable. (test-program-cmd-after-env): Likewise. (test-program-cmd): Define in terms of new variables. * Rules (make-test-out): Use $(run-program-env). * scripts/cross-test-ssh.sh (env_blacklist): Remove variable. (help): Do not mention environment variables. Mention --timeoutfactor option. (timeoutfactor): New variable. (blacklist_exports): Remove function. (exports): Remove variable. (command): Do not include ${exports}. * manual/install.texi (Configuring and compiling): Do not mention test wrappers preserving environment variables. Mention that last assignment to a variable must take precedence. * INSTALL: Regenerated. * benchtests/Makefile (run-bench): Use $(run-program-env). * catgets/Makefile ($(objpfx)test1.cat): Use $(built-program-cmd-before-env), $(run-program-env) and $(built-program-cmd-after-env). ($(objpfx)test2.cat): Do not specify environment variables explicitly. ($(objpfx)de/libc.cat): Use $(built-program-cmd-before-env), $(run-program-env) and $(built-program-cmd-after-env). ($(objpfx)test-gencat.out): Use $(test-program-cmd-before-env), $(run-program-env) and $(test-program-cmd-after-env). ($(objpfx)sample.SJIS.cat): Do not specify environment variables explicitly. * catgets/test-gencat.sh: Use test_program_cmd_before_env, run_program_env and test_program_cmd_after_env arguments. * elf/Makefile ($(objpfx)tst-pathopt.out): Use $(run-program-env). * elf/tst-pathopt.sh: Use run_program_env argument. * iconvdata/Makefile ($(objpfx)iconv-test.out): Use $(test-wrapper-env) and $(run-program-env). * iconvdata/run-iconv-test.sh: Use test_wrapper_env and run_program_env arguments. * iconvdata/tst-table.sh: Do not set GCONV_PATH explicitly. * intl/Makefile ($(objpfx)tst-gettext.out): Use $(test-program-prefix-before-env), $(run-program-env) and $(test-program-prefix-after-env). ($(objpfx)tst-gettext2.out): Likewise. * intl/tst-gettext.sh: Use test_program_prefix_before_env, run_program_env and test_program_prefix_after_env arguments. * intl/tst-gettext2.sh: Likewise. * intl/tst-gettext4.sh: Do not set environment variables explicitly. * intl/tst-gettext6.sh: Likewise. * intl/tst-translit.sh: Likewise. * malloc/Makefile ($(objpfx)tst-mtrace.out): Use $(test-program-prefix-before-env), $(run-program-env) and $(test-program-prefix-after-env). * malloc/tst-mtrace.sh: Use test_program_prefix_before_env, run_program_env and test_program_prefix_after_env arguments. * math/Makefile (run-regen-ulps): Use $(run-program-env). * nptl/Makefile ($(objpfx)tst-tls6.out): Use $(run-program-env). * nptl/tst-tls6.sh: Use run_program_env argument. Set LANG=C explicitly with each use of ${test_wrapper_env}. * posix/Makefile ($(objpfx)wordexp-tst.out): Use $(test-program-prefix-before-env), $(run-program-env) and $(test-program-prefix-after-env). * posix/tst-getconf.sh: Do not set environment variables explicitly. * posix/wordexp-tst.sh: Use test_program_prefix_before_env, run_program_env and test_program_prefix_after_env arguments. * stdio-common/tst-printf.sh: Do not set environment variables explicitly. * stdlib/Makefile ($(objpfx)tst-fmtmsg.out): Use $(test-program-prefix-before-env), $(run-program-env) and $(test-program-prefix-after-env). * stdlib/tst-fmtmsg.sh: Use test_program_prefix_before_env, run_program_env and test_program_prefix_after_env arguments. Split $test calls into $test_pre and $test. * timezone/Makefile (build-testdata): Use $(built-program-cmd-before-env), $(run-program-env) and $(built-program-cmd-after-env). localedata/ChangeLog: * Makefile ($(addprefix $(objpfx),$(CTYPE_FILES))): Use $(built-program-cmd-before-env), $(run-program-env) and $(built-program-cmd-after-env). ($(objpfx)sort-test.out): Use $(test-program-prefix-before-env), $(run-program-env) and $(test-program-prefix-after-env). ($(objpfx)tst-fmon.out): Use $(run-program-prefix-before-env), $(run-program-env) and $(run-program-prefix-after-env). ($(objpfx)tst-locale.out): Use $(built-program-cmd-before-env), $(run-program-env) and $(built-program-cmd-after-env). ($(objpfx)tst-trans.out): Use $(run-program-prefix-before-env), $(run-program-env), $(run-program-prefix-after-env), $(test-program-prefix-before-env) and $(test-program-prefix-after-env). ($(objpfx)tst-ctype.out): Use $(test-program-cmd-before-env), $(run-program-env) and $(test-program-cmd-after-env). ($(objpfx)tst-wctype.out): Likewise. ($(objpfx)tst-langinfo.out): Likewise. ($(objpfx)tst-langinfo-static.out): Likewise. * gen-locale.sh: Use localedef_before_env, run_program_env and localedef_after_env arguments. * sort-test.sh: Use test_program_prefix_before_env, run_program_env and test_program_prefix_after_env arguments. * tst-ctype.sh: Use tst_ctype_before_env, run_program_env and tst_ctype_after_env arguments. * tst-fmon.sh: Use run_program_prefix_before_env, run_program_env and run_program_prefix_after_env arguments. * tst-langinfo.sh: Use tst_langinfo_before_env, run_program_env and tst_langinfo_after_env arguments. * tst-locale.sh: Use localedef_before_env, run_program_env and localedef_after_env arguments. * tst-mbswcs.sh: Do not set environment variables explicitly. * tst-numeric.sh: Likewise. * tst-rpmatch.sh: Likewise. * tst-trans.sh: Use run_program_prefix_before_env, run_program_env, run_program_prefix_after_env, test_program_prefix_before_env and test_program_prefix_after_env arguments. * tst-wctype.sh: Use tst_wctype_before_env, run_program_env and tst_wctype_after_env arguments. |
||
|---|---|---|
| .. | ||
| bits | ||
| machine | ||
| atest-exp2.c | ||
| atest-exp.c | ||
| atest-sincos.c | ||
| auto-libm-test-in | ||
| auto-libm-test-out | ||
| basic-test.c | ||
| bug-nextafter.c | ||
| bug-nexttoward.c | ||
| bug-tgmath1.c | ||
| cabs.c | ||
| cabsf.c | ||
| cabsl.c | ||
| carg.c | ||
| cargf.c | ||
| cargl.c | ||
| cimag.c | ||
| cimagf.c | ||
| cimagl.c | ||
| complex.h | ||
| conj.c | ||
| conjf.c | ||
| conjl.c | ||
| creal.c | ||
| crealf.c | ||
| creall.c | ||
| divtc3.c | ||
| e_acoshl.c | ||
| e_acosl.c | ||
| e_asinl.c | ||
| e_atan2l.c | ||
| e_atanhl.c | ||
| e_coshl.c | ||
| e_exp2l.c | ||
| e_exp10.c | ||
| e_exp10f.c | ||
| e_exp10l.c | ||
| e_expl.c | ||
| e_fmodl.c | ||
| e_gammal_r.c | ||
| e_hypotl.c | ||
| e_j0l.c | ||
| e_j1l.c | ||
| e_jnl.c | ||
| e_lgammal_r.c | ||
| e_log2l.c | ||
| e_log10l.c | ||
| e_logl.c | ||
| e_powl.c | ||
| e_rem_pio2l.c | ||
| e_scalb.c | ||
| e_scalbf.c | ||
| e_scalbl.c | ||
| e_sinhl.c | ||
| e_sqrtl.c | ||
| fclrexcpt.c | ||
| fedisblxcpt.c | ||
| feenablxcpt.c | ||
| fegetenv.c | ||
| fegetexcept.c | ||
| fegetround.c | ||
| feholdexcpt.c | ||
| fenv.h | ||
| fesetenv.c | ||
| fesetround.c | ||
| feupdateenv.c | ||
| fgetexcptflg.c | ||
| fpu_control.c | ||
| fraiseexcpt.c | ||
| fsetexcptflg.c | ||
| ftestexcept.c | ||
| gen-auto-libm-tests.c | ||
| gen-libm-test.pl | ||
| ieee-math.c | ||
| k_casinh.c | ||
| k_casinhf.c | ||
| k_casinhl.c | ||
| k_cosl.c | ||
| k_rem_pio2l.c | ||
| k_sincosl.c | ||
| k_sinl.c | ||
| k_tanl.c | ||
| libm-test.inc | ||
| Makefile | ||
| math.h | ||
| multc3.c | ||
| README.libm-test | ||
| s_asinhl.c | ||
| s_atanl.c | ||
| s_cacos.c | ||
| s_cacosf.c | ||
| s_cacosh.c | ||
| s_cacoshf.c | ||
| s_cacoshl.c | ||
| s_cacosl.c | ||
| s_casin.c | ||
| s_casinf.c | ||
| s_casinh.c | ||
| s_casinhf.c | ||
| s_casinhl.c | ||
| s_casinl.c | ||
| s_catan.c | ||
| s_catanf.c | ||
| s_catanh.c | ||
| s_catanhf.c | ||
| s_catanhl.c | ||
| s_catanl.c | ||
| s_cbrtl.c | ||
| s_ccos.c | ||
| s_ccosf.c | ||
| s_ccosh.c | ||
| s_ccoshf.c | ||
| s_ccoshl.c | ||
| s_ccosl.c | ||
| s_cexp.c | ||
| s_cexpf.c | ||
| s_cexpl.c | ||
| s_clog10.c | ||
| s_clog10f.c | ||
| s_clog10l.c | ||
| s_clog.c | ||
| s_clogf.c | ||
| s_clogl.c | ||
| s_cpow.c | ||
| s_cpowf.c | ||
| s_cpowl.c | ||
| s_cproj.c | ||
| s_cprojf.c | ||
| s_cprojl.c | ||
| s_csin.c | ||
| s_csinf.c | ||
| s_csinh.c | ||
| s_csinhf.c | ||
| s_csinhl.c | ||
| s_csinl.c | ||
| s_csqrt.c | ||
| s_csqrtf.c | ||
| s_csqrtl.c | ||
| s_ctan.c | ||
| s_ctanf.c | ||
| s_ctanh.c | ||
| s_ctanhf.c | ||
| s_ctanhl.c | ||
| s_ctanl.c | ||
| s_erfl.c | ||
| s_expm1l.c | ||
| s_fdim.c | ||
| s_fdimf.c | ||
| s_fdiml.c | ||
| s_fma.c | ||
| s_fmaf.c | ||
| s_fmal.c | ||
| s_fmax.c | ||
| s_fmaxf.c | ||
| s_fmaxl.c | ||
| s_fmin.c | ||
| s_fminf.c | ||
| s_fminl.c | ||
| s_ldexp.c | ||
| s_ldexpf.c | ||
| s_ldexpl.c | ||
| s_log1pl.c | ||
| s_nan.c | ||
| s_nanf.c | ||
| s_nanl.c | ||
| s_nextafter.c | ||
| s_nexttowardf.c | ||
| s_nexttowardl.c | ||
| s_significand.c | ||
| s_significandf.c | ||
| s_significandl.c | ||
| s_tanhl.c | ||
| setfpucw.c | ||
| t_sincosl.c | ||
| test-double.c | ||
| test-fenv-preserve.c | ||
| test-fenv-tls.c | ||
| test-fenv.c | ||
| test-float.c | ||
| test-fpucw-ieee-static.c | ||
| test-fpucw-ieee.c | ||
| test-fpucw-static.c | ||
| test-fpucw.c | ||
| test-idouble.c | ||
| test-ifloat.c | ||
| test-ildoubl.c | ||
| test-ldouble.c | ||
| test-matherr.c | ||
| test-misc.c | ||
| test-powl.c | ||
| test-snan.c | ||
| test-tgmath2.c | ||
| test-tgmath-int.c | ||
| test-tgmath-ret.c | ||
| test-tgmath.c | ||
| tgmath.h | ||
| tst-CMPLX2.c | ||
| tst-CMPLX.c | ||
| tst-definitions.c | ||
| Versions | ||
| w_acos.c | ||
| w_acosf.c | ||
| w_acosh.c | ||
| w_acoshf.c | ||
| w_acoshl.c | ||
| w_acosl.c | ||
| w_asin.c | ||
| w_asinf.c | ||
| w_asinl.c | ||
| w_atan2.c | ||
| w_atan2f.c | ||
| w_atan2l.c | ||
| w_atanh.c | ||
| w_atanhf.c | ||
| w_atanhl.c | ||
| w_cosh.c | ||
| w_coshf.c | ||
| w_coshl.c | ||
| w_drem.c | ||
| w_dremf.c | ||
| w_dreml.c | ||
| w_exp2.c | ||
| w_exp2f.c | ||
| w_exp2l.c | ||
| w_exp10.c | ||
| w_exp10f.c | ||
| w_exp10l.c | ||
| w_expl.c | ||
| w_fmod.c | ||
| w_fmodf.c | ||
| w_fmodl.c | ||
| w_hypot.c | ||
| w_hypotf.c | ||
| w_hypotl.c | ||
| w_ilogb.c | ||
| w_ilogbf.c | ||
| w_ilogbl.c | ||
| w_j0.c | ||
| w_j0f.c | ||
| w_j0l.c | ||
| w_j1.c | ||
| w_j1f.c | ||
| w_j1l.c | ||
| w_jn.c | ||
| w_jnf.c | ||
| w_jnl.c | ||
| w_lgamma_r.c | ||
| w_lgamma.c | ||
| w_lgammaf_r.c | ||
| w_lgammaf.c | ||
| w_lgammal_r.c | ||
| w_lgammal.c | ||
| w_log2.c | ||
| w_log2f.c | ||
| w_log2l.c | ||
| w_log10.c | ||
| w_log10f.c | ||
| w_log10l.c | ||
| w_log.c | ||
| w_logf.c | ||
| w_logl.c | ||
| w_pow.c | ||
| w_powf.c | ||
| w_powl.c | ||
| w_remainder.c | ||
| w_remainderf.c | ||
| w_remainderl.c | ||
| w_scalb.c | ||
| w_scalbf.c | ||
| w_scalbl.c | ||
| w_sinh.c | ||
| w_sinhf.c | ||
| w_sinhl.c | ||
| w_sqrt.c | ||
| w_sqrtf.c | ||
| w_sqrtl.c | ||
| w_tgamma.c | ||
| w_tgammaf.c | ||
| w_tgammal.c | ||
README for libm-test math test suite
====================================
The libm-test math test suite tests a number of function points of
math functions in the GNU C library. The following sections contain a
brief overview. Please note that the test drivers and the Perl script
"gen-libm-test.pl" have some options. A full list of options is
available with --help (for the test drivers) and -h for
"gen-libm-test.pl".
What is tested?
===============
The tests just evaluate the functions at specified points and compare
the results with precomputed values and the requirements of the ISO
C99 standard.
Besides testing the special values mandated by IEEE 754 (infinities,
NaNs and minus zero), some more or less random values are tested.
Files that are part of libm-test
================================
The main file is "libm-test.inc". It is platform and floating point
format independent. The file must be preprocessed by the Perl script
"gen-libm-test.pl". The results are "libm-test.c" and a file
"libm-test-ulps.h" with platform specific deltas.
The test drivers test-double.c, test-float.c, test-ldouble.c test the
normal double, float and long double implementation of libm. The test
drivers with an i in it (test-idouble.c, test-ifloat.c,
test-ildoubl.c) test the corresponding inline functions (where
available - otherwise they also test the real functions in libm).
"gen-libm-test.pl" needs a platform specific files with ULPs (Units of
Last Precision). The file is called "libm-test-ulps" and lives in
platform specific sysdep directory.
How can I generate "libm-test-ulps"?
====================================
To automatically generate a new "libm-test-ulps" run "make regen-ulps".
This generates the file "math/NewUlps" in the build directory. The file
contains the sorted results of all the tests. You can use the "NewUlps"
file as the machine's updated "libm-test-ulps" file. Copy "NewUlps" to
"libm-test-ulps" in the appropriate machine sysdep directory. Verify
the changes, post your patch, and check it in after review.
To manually generate a new "libm-test-ulps" file, first remove "ULPs"
file in the current directory, then you can execute for example:
./testrun.sh math/test-double -u --ignore-max-ulp=yes
This generates a file "ULPs" with all double ULPs in it, ignoring any
previously calculated ULPs, and running with the newly built dynamic
loader and math library (assumes you didn't install your build). Now
generate the ULPs for all other formats, the tests will be appending the
data to the "ULPs" file. As final step run "gen-libm-test.pl" with the
file as input and ask to generate a pretty printed output in the file
"NewUlps":
gen-libm-test.pl -u ULPs -n
Copy "NewUlps" to "libm-test-ulps" in the appropriate machine sysdep
directory.
Note that the test drivers have an option "-u" to output an unsorted
list of all epsilons that the functions have. The output can be read
in directly but it's better to pretty print it first.
"gen-libm-test.pl" has an option to generate a pretty-printed and
sorted new ULPs file from the output of the test drivers.
Contents of libm-test-ulps
==========================
Since libm-test-ulps can be generated automatically, just a few notes.
The file contains lines for maximal errors of single functions, like:
Function "yn":
idouble: 6
The keywords are float, ifloat, double, idouble, ldouble and ildouble
(the prefix i stands for inline).
Adding tests to libm-test.inc
=============================
The tests are evaluated by a set of special test macros. The macros
start with "TEST_" followed by a specification the input values, an
underscore and a specification of the output values. As an example,
the test macro for a function with input of type FLOAT (FLOAT is
either float, double, long double) and output of type FLOAT is
"TEST_f_f". The macro's parameter are the name of the function, the
input parameter, output parameter and optionally one exception
parameter.
The accepted parameter types are:
- "f" for FLOAT
- "b" for boolean - just tests if the output parameter evaluates to 0
or 1 (only for output).
- "c" for complex. This parameter needs two values, first the real,
then the imaginary part.
- "i" for int.
- "l" for long int.
- "L" for long long int.
- "F" for the address of a FLOAT (only as input parameter)
- "I" for the address of an int (only as input parameter)