mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-23 11:20:07 +00:00
8540f6d2a7
One wart in the original support for test wrappers for cross testing, as noted in <https://sourceware.org/ml/libc-alpha/2012-10/msg00722.html>, is the requirement for test wrappers to pass a poorly-defined set of environment variables from the build system to the system running the glibc under test. Although some variables are passed explicitly via $(test-wrapper-env), including LD_* variables that simply can't be passed implicitly because of the side effects they'd have on the build system's dynamic linker, others are passed implicitly, including variables such as GCONV_PATH and LOCPATH that could potentially affect the build system's libc (so effectively relying on any such effects not breaking the wrappers). In addition, the code in cross-test-ssh.sh for preserving environment variables is fragile (it depends on how bash formats a list of exported variables, and could well break for multi-line variable definitions where the contents contain things looking like other variable definitions). This patch moves to explicitly passing environment variables via $(test-wrapper-env). Makefile variables that previously used $(test-wrapper) are split up into -before-env and -after-env parts that can be passed separately to the various .sh files used in testing, so those files can then insert environment settings between the two parts. The common default environment settings in make-test-out are made into a separate makefile variable that can also be passed to scripts, rather than many scripts duplicating those settings (for testing an installed glibc, it is desirable to have the GCONV_PATH setting on just one place, so just that one place needs to support it pointing to an installed sysroot instead of the build tree). The default settings are included in the variables such as $(test-program-prefix), so that if tests do not need any non-default settings they can continue to use single variables rather than the split-up variables. Although this patch cleans up LC_ALL=C settings (that being part of the common defaults), various LANG=C and LANGUAGE=C settings remain. Those are generally unnecessary and I propose a subsequent cleanup to remove them. LC_ALL takes precedence over LANG, and while LANGUAGE takes precedence over LC_ALL, it only does so for settings other than LC_ALL=C. So LC_ALL=C on its own is sufficient to ensure the C locale, and anything that gets LC_ALL=C does not need the other settings. While preparing this patch I noticed some tests with .sh files that appeared to do nothing beyond what the generic makefile support for tests can do (localedata/tst-wctype.sh - the makefiles support -ENV variables and .input files - and localedata/tst-mbswcs.sh - just runs five tests that could be run individually from the makefile). So I propose another subsequent cleanup to move those to using the generic support instead of special .sh files. Tested x86_64 (native) and powerpc32 (cross). * Makeconfig (run-program-env): New variable. (run-program-prefix-before-env): Likewise. (run-program-prefix-after-env): Likewise. (run-program-prefix): Define in terms of new variables. (built-program-cmd-before-env): New variable. (built-program-cmd-after-env): Likewise. (built-program-cmd): Define in terms of new variables. (test-program-prefix-before-env): New variable. (test-program-prefix-after-env): Likewise. (test-program-prefix): Define in terms of new variables. (test-program-cmd-before-env): New variable. (test-program-cmd-after-env): Likewise. (test-program-cmd): Define in terms of new variables. * Rules (make-test-out): Use $(run-program-env). * scripts/cross-test-ssh.sh (env_blacklist): Remove variable. (help): Do not mention environment variables. Mention --timeoutfactor option. (timeoutfactor): New variable. (blacklist_exports): Remove function. (exports): Remove variable. (command): Do not include ${exports}. * manual/install.texi (Configuring and compiling): Do not mention test wrappers preserving environment variables. Mention that last assignment to a variable must take precedence. * INSTALL: Regenerated. * benchtests/Makefile (run-bench): Use $(run-program-env). * catgets/Makefile ($(objpfx)test1.cat): Use $(built-program-cmd-before-env), $(run-program-env) and $(built-program-cmd-after-env). ($(objpfx)test2.cat): Do not specify environment variables explicitly. ($(objpfx)de/libc.cat): Use $(built-program-cmd-before-env), $(run-program-env) and $(built-program-cmd-after-env). ($(objpfx)test-gencat.out): Use $(test-program-cmd-before-env), $(run-program-env) and $(test-program-cmd-after-env). ($(objpfx)sample.SJIS.cat): Do not specify environment variables explicitly. * catgets/test-gencat.sh: Use test_program_cmd_before_env, run_program_env and test_program_cmd_after_env arguments. * elf/Makefile ($(objpfx)tst-pathopt.out): Use $(run-program-env). * elf/tst-pathopt.sh: Use run_program_env argument. * iconvdata/Makefile ($(objpfx)iconv-test.out): Use $(test-wrapper-env) and $(run-program-env). * iconvdata/run-iconv-test.sh: Use test_wrapper_env and run_program_env arguments. * iconvdata/tst-table.sh: Do not set GCONV_PATH explicitly. * intl/Makefile ($(objpfx)tst-gettext.out): Use $(test-program-prefix-before-env), $(run-program-env) and $(test-program-prefix-after-env). ($(objpfx)tst-gettext2.out): Likewise. * intl/tst-gettext.sh: Use test_program_prefix_before_env, run_program_env and test_program_prefix_after_env arguments. * intl/tst-gettext2.sh: Likewise. * intl/tst-gettext4.sh: Do not set environment variables explicitly. * intl/tst-gettext6.sh: Likewise. * intl/tst-translit.sh: Likewise. * malloc/Makefile ($(objpfx)tst-mtrace.out): Use $(test-program-prefix-before-env), $(run-program-env) and $(test-program-prefix-after-env). * malloc/tst-mtrace.sh: Use test_program_prefix_before_env, run_program_env and test_program_prefix_after_env arguments. * math/Makefile (run-regen-ulps): Use $(run-program-env). * nptl/Makefile ($(objpfx)tst-tls6.out): Use $(run-program-env). * nptl/tst-tls6.sh: Use run_program_env argument. Set LANG=C explicitly with each use of ${test_wrapper_env}. * posix/Makefile ($(objpfx)wordexp-tst.out): Use $(test-program-prefix-before-env), $(run-program-env) and $(test-program-prefix-after-env). * posix/tst-getconf.sh: Do not set environment variables explicitly. * posix/wordexp-tst.sh: Use test_program_prefix_before_env, run_program_env and test_program_prefix_after_env arguments. * stdio-common/tst-printf.sh: Do not set environment variables explicitly. * stdlib/Makefile ($(objpfx)tst-fmtmsg.out): Use $(test-program-prefix-before-env), $(run-program-env) and $(test-program-prefix-after-env). * stdlib/tst-fmtmsg.sh: Use test_program_prefix_before_env, run_program_env and test_program_prefix_after_env arguments. Split $test calls into $test_pre and $test. * timezone/Makefile (build-testdata): Use $(built-program-cmd-before-env), $(run-program-env) and $(built-program-cmd-after-env). localedata/ChangeLog: * Makefile ($(addprefix $(objpfx),$(CTYPE_FILES))): Use $(built-program-cmd-before-env), $(run-program-env) and $(built-program-cmd-after-env). ($(objpfx)sort-test.out): Use $(test-program-prefix-before-env), $(run-program-env) and $(test-program-prefix-after-env). ($(objpfx)tst-fmon.out): Use $(run-program-prefix-before-env), $(run-program-env) and $(run-program-prefix-after-env). ($(objpfx)tst-locale.out): Use $(built-program-cmd-before-env), $(run-program-env) and $(built-program-cmd-after-env). ($(objpfx)tst-trans.out): Use $(run-program-prefix-before-env), $(run-program-env), $(run-program-prefix-after-env), $(test-program-prefix-before-env) and $(test-program-prefix-after-env). ($(objpfx)tst-ctype.out): Use $(test-program-cmd-before-env), $(run-program-env) and $(test-program-cmd-after-env). ($(objpfx)tst-wctype.out): Likewise. ($(objpfx)tst-langinfo.out): Likewise. ($(objpfx)tst-langinfo-static.out): Likewise. * gen-locale.sh: Use localedef_before_env, run_program_env and localedef_after_env arguments. * sort-test.sh: Use test_program_prefix_before_env, run_program_env and test_program_prefix_after_env arguments. * tst-ctype.sh: Use tst_ctype_before_env, run_program_env and tst_ctype_after_env arguments. * tst-fmon.sh: Use run_program_prefix_before_env, run_program_env and run_program_prefix_after_env arguments. * tst-langinfo.sh: Use tst_langinfo_before_env, run_program_env and tst_langinfo_after_env arguments. * tst-locale.sh: Use localedef_before_env, run_program_env and localedef_after_env arguments. * tst-mbswcs.sh: Do not set environment variables explicitly. * tst-numeric.sh: Likewise. * tst-rpmatch.sh: Likewise. * tst-trans.sh: Use run_program_prefix_before_env, run_program_env, run_program_prefix_after_env, test_program_prefix_before_env and test_program_prefix_after_env arguments. * tst-wctype.sh: Use tst_wctype_before_env, run_program_env and tst_wctype_after_env arguments. |
||
|---|---|---|
| .. | ||
| bits | ||
| sys | ||
| a64l.c | ||
| abort.c | ||
| abs.c | ||
| add_n.c | ||
| addmul_1.c | ||
| alloca.h | ||
| at_quick_exit.c | ||
| atexit.c | ||
| atof.c | ||
| atoi.c | ||
| atol.c | ||
| atoll.c | ||
| bsearch.c | ||
| bug-fmtmsg1.c | ||
| bug-getcontext.c | ||
| bug-strtod2.c | ||
| bug-strtod.c | ||
| canonicalize.c | ||
| cmp.c | ||
| cxa_at_quick_exit.c | ||
| cxa_atexit.c | ||
| cxa_finalize.c | ||
| cxa_thread_atexit_impl.c | ||
| dbl2mpn.c | ||
| Depend | ||
| div.c | ||
| divmod_1.c | ||
| divrem.c | ||
| drand48_r.c | ||
| drand48-iter.c | ||
| drand48.c | ||
| erand48_r.c | ||
| erand48.c | ||
| errno.h | ||
| exit.c | ||
| exit.h | ||
| fmtmsg.c | ||
| fmtmsg.h | ||
| fpioconst.c | ||
| fpioconst.h | ||
| gen-fpioconst.c | ||
| gen-tst-strtod-round.c | ||
| getcontext.c | ||
| getenv.c | ||
| getsubopt.c | ||
| gmp-impl.h | ||
| gmp.h | ||
| grouping.c | ||
| grouping.h | ||
| groupingwc.c | ||
| inlines.c | ||
| isomac.c | ||
| jrand48_r.c | ||
| jrand48.c | ||
| l64a.c | ||
| labs.c | ||
| lcong48_r.c | ||
| lcong48.c | ||
| ldbl2mpn.c | ||
| ldiv.c | ||
| llabs.c | ||
| lldiv.c | ||
| longlong.h | ||
| lrand48_r.c | ||
| lrand48.c | ||
| lshift.c | ||
| makecontext.c | ||
| Makefile | ||
| mblen.c | ||
| mbstowcs.c | ||
| mbtowc.c | ||
| mod_1.c | ||
| monetary.h | ||
| mp_clz_tab.c | ||
| mpn2dbl.c | ||
| mpn2flt.c | ||
| mpn2ldbl.c | ||
| mrand48_r.c | ||
| mrand48.c | ||
| msort.c | ||
| mul_1.c | ||
| mul_n.c | ||
| mul.c | ||
| nrand48_r.c | ||
| nrand48.c | ||
| old_atexit.c | ||
| on_exit.c | ||
| putenv.c | ||
| qsort.c | ||
| quick_exit.c | ||
| rand_r.c | ||
| rand.c | ||
| random_r.c | ||
| random.c | ||
| rpmatch.c | ||
| rshift.c | ||
| secure-getenv.c | ||
| seed48_r.c | ||
| seed48.c | ||
| setcontext.c | ||
| setenv.c | ||
| srand48_r.c | ||
| srand48.c | ||
| stdlib.h | ||
| strfmon_l.c | ||
| strfmon.c | ||
| strtod_l.c | ||
| strtod.c | ||
| strtof_l.c | ||
| strtof.c | ||
| strtoimax.c | ||
| strtol_l.c | ||
| strtol.c | ||
| strtold_l.c | ||
| strtold.c | ||
| strtoll_l.c | ||
| strtoll.c | ||
| strtoul_l.c | ||
| strtoul.c | ||
| strtoull_l.c | ||
| strtoull.c | ||
| strtoumax.c | ||
| sub_n.c | ||
| submul_1.c | ||
| swapcontext.c | ||
| system.c | ||
| tens_in_limb.c | ||
| test-a64l.c | ||
| test-canon2.c | ||
| test-canon.c | ||
| testdiv.c | ||
| testdiv.input | ||
| testmb2.c | ||
| testmb.c | ||
| testrand.c | ||
| testsort.c | ||
| tst-atof1.c | ||
| tst-atof2.c | ||
| tst-bsearch.c | ||
| tst-environ.c | ||
| tst-fmtmsg.c | ||
| tst-fmtmsg.sh | ||
| tst-limits.c | ||
| tst-makecontext2.c | ||
| tst-makecontext3.c | ||
| tst-makecontext.c | ||
| tst-putenv.c | ||
| tst-putenvmod.c | ||
| tst-qsort2.c | ||
| tst-qsort.c | ||
| tst-rand48-2.c | ||
| tst-rand48.c | ||
| tst-random2.c | ||
| tst-random.c | ||
| tst-secure-getenv.c | ||
| tst-setcontext.c | ||
| tst-strtod2.c | ||
| tst-strtod3.c | ||
| tst-strtod4.c | ||
| tst-strtod5.c | ||
| tst-strtod6.c | ||
| tst-strtod-overflow.c | ||
| tst-strtod-round-data | ||
| tst-strtod-round.c | ||
| tst-strtod-underflow.c | ||
| tst-strtod.c | ||
| tst-strtol.c | ||
| tst-strtoll.c | ||
| tst-system.c | ||
| tst-tininess.c | ||
| tst-tls-atexit-lib.c | ||
| tst-tls-atexit.c | ||
| tst-unsetenv1.c | ||
| tst-xpg-basename.c | ||
| ucontext.h | ||
| udiv_qrnnd.c | ||
| Versions | ||
| wcstoimax.c | ||
| wcstombs.c | ||
| wcstoumax.c | ||
| wctomb.c | ||
| xpg_basename.c | ||