glibc/misc/tst-select.c
Adhemerval Zanella 4c3df0eba5 linux: Only use 64-bit syscall if required for select
For !__ASSUME_TIME64_SYSCALLS there is no need to issue a 64-bit syscall
if the provided timeout fits in a 32-bit one.  The 64-bit usage should
be rare since the timeout is a relative one.  This also avoids the need
to use supports_time64() (which breaks the usage case of live migration
like CRIU or similar).

It also fixes an issue on 32-bit select call for !__ASSUME_PSELECT
(microblase with older kernels only) where the expected timeout
is a 'struct timeval' instead of 'struct timespec'.

Checked on i686-linux-gnu on a 4.15 kernel and on a 5.11 kernel
(with and without --enable-kernel=5.1) and on x86_64-linux-gnu.

Reviewed-by: Lukasz Majewski <lukma@denx.de>
2021-06-22 12:09:52 -03:00

153 lines
4.4 KiB
C

/* Test for select timeout.
Copyright (C) 2021 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#include <errno.h>
#include <intprops.h>
#include <support/capture_subprocess.h>
#include <support/check.h>
#include <support/support.h>
#include <support/timespec.h>
#include <support/xunistd.h>
#include <support/xtime.h>
#include <support/xsignal.h>
struct child_args
{
int fds[2][2];
struct timeval tmo;
};
static void
do_test_child (void *clousure)
{
struct child_args *args = (struct child_args *) clousure;
close (args->fds[0][1]);
close (args->fds[1][0]);
fd_set rfds;
FD_ZERO (&rfds);
FD_SET (args->fds[0][0], &rfds);
struct timespec ts = xclock_now (CLOCK_REALTIME);
ts = timespec_add (ts, (struct timespec) { args->tmo.tv_sec, 0 });
int r = select (args->fds[0][0] + 1, &rfds, NULL, NULL, &args->tmo);
TEST_COMPARE (r, 0);
if (support_select_modifies_timeout ())
{
TEST_COMPARE (args->tmo.tv_sec, 0);
TEST_COMPARE (args->tmo.tv_usec, 0);
}
TEST_TIMESPEC_NOW_OR_AFTER (CLOCK_REALTIME, ts);
xwrite (args->fds[1][1], "foo", 3);
}
static void
do_test_child_alarm (void *clousure)
{
struct child_args *args = (struct child_args *) clousure;
support_create_timer (0, 100000000, false, NULL);
struct timeval tv = { .tv_sec = args->tmo.tv_sec, .tv_usec = 0 };
int r = select (0, NULL, NULL, NULL, &tv);
TEST_COMPARE (r, -1);
if (args->tmo.tv_sec > INT_MAX)
TEST_VERIFY (errno == EINTR || errno == EOVERFLOW);
else
{
TEST_COMPARE (errno, EINTR);
if (support_select_modifies_timeout ())
TEST_VERIFY (tv.tv_sec < args->tmo.tv_sec);
}
}
static int
do_test (void)
{
struct child_args args;
xpipe (args.fds[0]);
xpipe (args.fds[1]);
/* The child select should timeout and write on its pipe end. */
args.tmo = (struct timeval) { .tv_sec = 0, .tv_usec = 250000 };
{
struct support_capture_subprocess result;
result = support_capture_subprocess (do_test_child, &args);
support_capture_subprocess_check (&result, "tst-select-child", 0,
sc_allow_none);
}
if (support_select_normalizes_timeout ())
{
/* This is handled as 1 second instead of failing with EINVAL. */
args.tmo = (struct timeval) { .tv_sec = 0, .tv_usec = 1000000 };
struct support_capture_subprocess result;
result = support_capture_subprocess (do_test_child, &args);
support_capture_subprocess_check (&result, "tst-select-child", 0,
sc_allow_none);
}
/* Same as before, but simulating polling. */
args.tmo = (struct timeval) { .tv_sec = 0, .tv_usec = 0 };
{
struct support_capture_subprocess result;
result = support_capture_subprocess (do_test_child, &args);
support_capture_subprocess_check (&result, "tst-select-child", 0,
sc_allow_none);
}
xclose (args.fds[0][0]);
xclose (args.fds[1][1]);
args.tmo = (struct timeval) { .tv_sec = 10, .tv_usec = 0 };
{
struct support_capture_subprocess result;
result = support_capture_subprocess (do_test_child_alarm, &args);
support_capture_subprocess_check (&result, "tst-select-child", 0,
sc_allow_none);
}
args.tmo = (struct timeval) { .tv_sec = TYPE_MAXIMUM (time_t),
.tv_usec = 0 };
{
struct support_capture_subprocess result;
result = support_capture_subprocess (do_test_child_alarm, &args);
support_capture_subprocess_check (&result, "tst-select-child", 0,
sc_allow_none);
}
args.tmo = (struct timeval) { .tv_sec = 0, .tv_usec = 0 };
{
fd_set rfds;
FD_ZERO (&rfds);
FD_SET (args.fds[1][0], &rfds);
int r = select (args.fds[1][0] + 1, &rfds, NULL, NULL, &args.tmo);
TEST_COMPARE (r, 1);
}
return 0;
}
#include <support/test-driver.c>