mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-30 00:31:08 +00:00
a84e78c8b3
This patch fixes incorrect results from catan and catanh of certain special inputs in round-downward mode (bug 16799), and incorrect results of __ieee754_logf (+/-0) in round-downward mode (bug 16800) that show up through catan/catanh when tested in all rounding modes, but not directly in the testing for logf because the bug gets hidden by the wrappers. Both bugs involve a zero that should be +0 being -0 instead: one computed as (1-x)*(1+x) in the catan/catanh case, and one as (x-x) in the logf case. The fixes ensure positive zero is used. Testing of catan and catanh in all rounding modes is duly enabled. I expect there are various other bugs in special cases in __ieee754_* functions that are normally hidden by the wrappers but would show up for testing with -lieee (or in future with -fno-math-errno if we replace -lieee and _LIB_VERSION with compile-time redirection to new *_noerrno symbol names). Tested x86_64 and x86 and ulps updated accordingly. [BZ #16799] [BZ #16800] * math/s_catan.c (__catan): Avoid passing -0 denominator to atan2 with 0 numerator. * math/s_catanf.c (__catanf): Likewise. * math/s_catanh.c (__catanh): Likewise. * math/s_catanhf.c (__catanhf): Likewise. * math/s_catanhl.c (__catanhl): Likewise. * math/s_catanl.c (__catanl): Likewise. * sysdeps/ieee754/flt-32/e_logf.c (__ieee754_logf): Always divide by positive zero when computing -Inf result. * math/libm-test.inc (catan_test): Use ALL_RM_TEST. (catanh_test): Likewise. * sysdeps/i386/fpu/libm-test-ulps: Update. * sysdeps/x86_64/fpu/libm-test-ulps: Likewise.
153 lines
3.9 KiB
C
153 lines
3.9 KiB
C
/* Return arc tangent of complex float value.
|
|
Copyright (C) 1997-2014 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <complex.h>
|
|
#include <math.h>
|
|
#include <math_private.h>
|
|
#include <float.h>
|
|
|
|
__complex__ float
|
|
__catanf (__complex__ float x)
|
|
{
|
|
__complex__ float res;
|
|
int rcls = fpclassify (__real__ x);
|
|
int icls = fpclassify (__imag__ x);
|
|
|
|
if (__glibc_unlikely (rcls <= FP_INFINITE || icls <= FP_INFINITE))
|
|
{
|
|
if (rcls == FP_INFINITE)
|
|
{
|
|
__real__ res = __copysignf (M_PI_2, __real__ x);
|
|
__imag__ res = __copysignf (0.0, __imag__ x);
|
|
}
|
|
else if (icls == FP_INFINITE)
|
|
{
|
|
if (rcls >= FP_ZERO)
|
|
__real__ res = __copysignf (M_PI_2, __real__ x);
|
|
else
|
|
__real__ res = __nanf ("");
|
|
__imag__ res = __copysignf (0.0, __imag__ x);
|
|
}
|
|
else if (icls == FP_ZERO || icls == FP_INFINITE)
|
|
{
|
|
__real__ res = __nanf ("");
|
|
__imag__ res = __copysignf (0.0, __imag__ x);
|
|
}
|
|
else
|
|
{
|
|
__real__ res = __nanf ("");
|
|
__imag__ res = __nanf ("");
|
|
}
|
|
}
|
|
else if (__glibc_unlikely (rcls == FP_ZERO && icls == FP_ZERO))
|
|
{
|
|
res = x;
|
|
}
|
|
else
|
|
{
|
|
if (fabsf (__real__ x) >= 16.0f / FLT_EPSILON
|
|
|| fabsf (__imag__ x) >= 16.0f / FLT_EPSILON)
|
|
{
|
|
__real__ res = __copysignf ((float) M_PI_2, __real__ x);
|
|
if (fabsf (__real__ x) <= 1.0f)
|
|
__imag__ res = 1.0f / __imag__ x;
|
|
else if (fabsf (__imag__ x) <= 1.0f)
|
|
__imag__ res = __imag__ x / __real__ x / __real__ x;
|
|
else
|
|
{
|
|
float h = __ieee754_hypotf (__real__ x / 2.0f,
|
|
__imag__ x / 2.0f);
|
|
__imag__ res = __imag__ x / h / h / 4.0f;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
float den, absx, absy;
|
|
|
|
absx = fabsf (__real__ x);
|
|
absy = fabsf (__imag__ x);
|
|
if (absx < absy)
|
|
{
|
|
float t = absx;
|
|
absx = absy;
|
|
absy = t;
|
|
}
|
|
|
|
if (absy < FLT_EPSILON / 2.0f)
|
|
{
|
|
den = (1.0f - absx) * (1.0f + absx);
|
|
if (den == -0.0f)
|
|
den = 0.0f;
|
|
}
|
|
else if (absx >= 1.0f)
|
|
den = (1.0f - absx) * (1.0f + absx) - absy * absy;
|
|
else if (absx >= 0.75f || absy >= 0.5f)
|
|
den = -__x2y2m1f (absx, absy);
|
|
else
|
|
den = (1.0f - absx) * (1.0f + absx) - absy * absy;
|
|
|
|
__real__ res = 0.5f * __ieee754_atan2f (2.0f * __real__ x, den);
|
|
|
|
if (fabsf (__imag__ x) == 1.0f
|
|
&& fabsf (__real__ x) < FLT_EPSILON * FLT_EPSILON)
|
|
__imag__ res = (__copysignf (0.5f, __imag__ x)
|
|
* ((float) M_LN2
|
|
- __ieee754_logf (fabsf (__real__ x))));
|
|
else
|
|
{
|
|
float r2 = 0.0f, num, f;
|
|
|
|
if (fabsf (__real__ x) >= FLT_EPSILON * FLT_EPSILON)
|
|
r2 = __real__ x * __real__ x;
|
|
|
|
num = __imag__ x + 1.0f;
|
|
num = r2 + num * num;
|
|
|
|
den = __imag__ x - 1.0f;
|
|
den = r2 + den * den;
|
|
|
|
f = num / den;
|
|
if (f < 0.5f)
|
|
__imag__ res = 0.25f * __ieee754_logf (f);
|
|
else
|
|
{
|
|
num = 4.0f * __imag__ x;
|
|
__imag__ res = 0.25f * __log1pf (num / den);
|
|
}
|
|
}
|
|
}
|
|
|
|
if (fabsf (__real__ res) < FLT_MIN)
|
|
{
|
|
volatile float force_underflow = __real__ res * __real__ res;
|
|
(void) force_underflow;
|
|
}
|
|
if (fabsf (__imag__ res) < FLT_MIN)
|
|
{
|
|
volatile float force_underflow = __imag__ res * __imag__ res;
|
|
(void) force_underflow;
|
|
}
|
|
}
|
|
|
|
return res;
|
|
}
|
|
#ifndef __catanf
|
|
weak_alias (__catanf, catanf)
|
|
#endif
|