glibc/math
Joseph Myers a84e78c8b3 Fix catan, catanh, __ieee754_logf in round-downward mode (bug 16799, bug 16800).
This patch fixes incorrect results from catan and catanh of certain
special inputs in round-downward mode (bug 16799), and incorrect
results of __ieee754_logf (+/-0) in round-downward mode (bug 16800)
that show up through catan/catanh when tested in all rounding modes,
but not directly in the testing for logf because the bug gets hidden
by the wrappers.

Both bugs involve a zero that should be +0 being -0 instead: one
computed as (1-x)*(1+x) in the catan/catanh case, and one as (x-x) in
the logf case.  The fixes ensure positive zero is used.  Testing of
catan and catanh in all rounding modes is duly enabled.

I expect there are various other bugs in special cases in __ieee754_*
functions that are normally hidden by the wrappers but would show up
for testing with -lieee (or in future with -fno-math-errno if we
replace -lieee and _LIB_VERSION with compile-time redirection to new
*_noerrno symbol names).

Tested x86_64 and x86 and ulps updated accordingly.

	[BZ #16799]
	[BZ #16800]
	* math/s_catan.c (__catan): Avoid passing -0 denominator to atan2
	with 0 numerator.
	* math/s_catanf.c (__catanf): Likewise.
	* math/s_catanh.c (__catanh): Likewise.
	* math/s_catanhf.c (__catanhf): Likewise.
	* math/s_catanhl.c (__catanhl): Likewise.
	* math/s_catanl.c (__catanl): Likewise.
	* sysdeps/ieee754/flt-32/e_logf.c (__ieee754_logf): Always divide
	by positive zero when computing -Inf result.
	* math/libm-test.inc (catan_test): Use ALL_RM_TEST.
	(catanh_test): Likewise.
	* sysdeps/i386/fpu/libm-test-ulps: Update.
	* sysdeps/x86_64/fpu/libm-test-ulps: Likewise.
2014-04-02 17:41:02 +00:00
..
bits
machine
atest-exp2.c
atest-exp.c
atest-sincos.c
auto-libm-test-in Set errno for atan2 underflow (bug 16349). 2014-03-31 14:56:37 +00:00
auto-libm-test-out Set errno for atan2 underflow (bug 16349). 2014-03-31 14:56:37 +00:00
basic-test.c
bug-nextafter.c
bug-nexttoward.c
bug-tgmath1.c
cabs.c
cabsf.c
cabsl.c
carg.c
cargf.c
cargl.c
cimag.c
cimagf.c
cimagl.c
complex.h
conj.c
conjf.c
conjl.c
creal.c
crealf.c
creall.c
divtc3.c
e_acoshl.c
e_acosl.c
e_asinl.c
e_atan2l.c
e_atanhl.c
e_coshl.c
e_exp2l.c
e_exp10.c
e_exp10f.c
e_exp10l.c
e_expl.c
e_fmodl.c
e_gammal_r.c
e_hypotl.c
e_j0l.c
e_j1l.c
e_jnl.c
e_lgammal_r.c
e_log2l.c
e_log10l.c
e_logl.c
e_powl.c
e_rem_pio2l.c
e_scalb.c
e_scalbf.c
e_scalbl.c
e_sinhl.c
e_sqrtl.c
fclrexcpt.c
fedisblxcpt.c
feenablxcpt.c
fegetenv.c
fegetexcept.c
fegetround.c
feholdexcpt.c
fenv.h
fesetenv.c
fesetround.c
feupdateenv.c
fgetexcptflg.c
fpu_control.c
fraiseexcpt.c
fsetexcptflg.c
ftestexcept.c
gen-auto-libm-tests.c
gen-libm-test.pl Set errno for scalb errors (bug 6803, bug 6804). 2014-03-31 14:57:53 +00:00
ieee-math.c
k_casinh.c
k_casinhf.c
k_casinhl.c
k_cosl.c
k_rem_pio2l.c
k_sincosl.c
k_sinl.c
k_tanl.c
libm-test.inc Fix catan, catanh, __ieee754_logf in round-downward mode (bug 16799, bug 16800). 2014-04-02 17:41:02 +00:00
Makefile
math.h
multc3.c
README.libm-test
s_asinhl.c
s_atanl.c
s_cacos.c
s_cacosf.c
s_cacosh.c
s_cacoshf.c
s_cacoshl.c
s_cacosl.c
s_casin.c
s_casinf.c
s_casinh.c
s_casinhf.c
s_casinhl.c
s_casinl.c
s_catan.c Fix catan, catanh, __ieee754_logf in round-downward mode (bug 16799, bug 16800). 2014-04-02 17:41:02 +00:00
s_catanf.c Fix catan, catanh, __ieee754_logf in round-downward mode (bug 16799, bug 16800). 2014-04-02 17:41:02 +00:00
s_catanh.c Fix catan, catanh, __ieee754_logf in round-downward mode (bug 16799, bug 16800). 2014-04-02 17:41:02 +00:00
s_catanhf.c Fix catan, catanh, __ieee754_logf in round-downward mode (bug 16799, bug 16800). 2014-04-02 17:41:02 +00:00
s_catanhl.c Fix catan, catanh, __ieee754_logf in round-downward mode (bug 16799, bug 16800). 2014-04-02 17:41:02 +00:00
s_catanl.c Fix catan, catanh, __ieee754_logf in round-downward mode (bug 16799, bug 16800). 2014-04-02 17:41:02 +00:00
s_cbrtl.c
s_ccos.c
s_ccosf.c
s_ccosh.c
s_ccoshf.c
s_ccoshl.c
s_ccosl.c
s_cexp.c
s_cexpf.c
s_cexpl.c
s_clog10.c Fix clog / clog10 sign of zero result in round-downward mode (bug 16789). 2014-04-02 13:10:19 +00:00
s_clog10f.c Fix clog / clog10 sign of zero result in round-downward mode (bug 16789). 2014-04-02 13:10:19 +00:00
s_clog10l.c Fix clog / clog10 sign of zero result in round-downward mode (bug 16789). 2014-04-02 13:10:19 +00:00
s_clog.c Fix clog / clog10 sign of zero result in round-downward mode (bug 16789). 2014-04-02 13:10:19 +00:00
s_clogf.c Fix clog / clog10 sign of zero result in round-downward mode (bug 16789). 2014-04-02 13:10:19 +00:00
s_clogl.c Fix clog / clog10 sign of zero result in round-downward mode (bug 16789). 2014-04-02 13:10:19 +00:00
s_cpow.c
s_cpowf.c
s_cpowl.c
s_cproj.c
s_cprojf.c
s_cprojl.c
s_csin.c
s_csinf.c
s_csinh.c
s_csinhf.c
s_csinhl.c
s_csinl.c
s_csqrt.c
s_csqrtf.c
s_csqrtl.c
s_ctan.c
s_ctanf.c
s_ctanh.c
s_ctanhf.c
s_ctanhl.c
s_ctanl.c
s_erfl.c
s_expm1l.c
s_fdim.c
s_fdimf.c
s_fdiml.c
s_fma.c
s_fmaf.c
s_fmal.c
s_fmax.c
s_fmaxf.c
s_fmaxl.c
s_fmin.c
s_fminf.c
s_fminl.c
s_ldexp.c
s_ldexpf.c
s_ldexpl.c
s_log1pl.c
s_nan.c
s_nanf.c
s_nanl.c
s_nextafter.c
s_nexttowardf.c
s_nexttowardl.c
s_significand.c
s_significandf.c
s_significandl.c
s_tanhl.c
setfpucw.c
t_sincosl.c
test-double.c
test-fenv-preserve.c
test-fenv-tls.c
test-fenv.c
test-float.c
test-fpucw-ieee-static.c
test-fpucw-ieee.c
test-fpucw-static.c
test-fpucw.c
test-idouble.c
test-ifloat.c
test-ildoubl.c
test-ldouble.c
test-matherr.c
test-misc.c
test-powl.c
test-snan.c
test-tgmath2.c
test-tgmath-int.c
test-tgmath-ret.c
test-tgmath.c
tgmath.h
tst-CMPLX2.c
tst-CMPLX.c
tst-definitions.c
Versions
w_acos.c
w_acosf.c
w_acosh.c
w_acoshf.c
w_acoshl.c
w_acosl.c
w_asin.c
w_asinf.c
w_asinl.c
w_atan2.c Set errno for atan2 underflow (bug 16349). 2014-03-31 14:56:37 +00:00
w_atan2f.c Set errno for atan2 underflow (bug 16349). 2014-03-31 14:56:37 +00:00
w_atan2l.c Set errno for atan2 underflow (bug 16349). 2014-03-31 14:56:37 +00:00
w_atanh.c
w_atanhf.c
w_atanhl.c
w_cosh.c
w_coshf.c
w_coshl.c
w_drem.c
w_dremf.c
w_dreml.c
w_exp2.c
w_exp2f.c
w_exp2l.c
w_exp10.c
w_exp10f.c
w_exp10l.c
w_expl.c
w_fmod.c
w_fmodf.c
w_fmodl.c
w_hypot.c
w_hypotf.c
w_hypotl.c
w_ilogb.c
w_ilogbf.c
w_ilogbl.c
w_j0.c
w_j0f.c
w_j0l.c
w_j1.c
w_j1f.c
w_j1l.c
w_jn.c
w_jnf.c
w_jnl.c
w_lgamma_r.c
w_lgamma.c
w_lgammaf_r.c
w_lgammaf.c
w_lgammal_r.c
w_lgammal.c
w_log2.c
w_log2f.c
w_log2l.c
w_log10.c
w_log10f.c
w_log10l.c
w_log.c
w_logf.c
w_logl.c
w_pow.c
w_powf.c
w_powl.c
w_remainder.c
w_remainderf.c
w_remainderl.c
w_scalb.c Set errno for scalb errors (bug 6803, bug 6804). 2014-03-31 14:57:53 +00:00
w_scalbf.c Set errno for scalb errors (bug 6803, bug 6804). 2014-03-31 14:57:53 +00:00
w_scalbl.c Set errno for scalb errors (bug 6803, bug 6804). 2014-03-31 14:57:53 +00:00
w_sinh.c
w_sinhf.c
w_sinhl.c
w_sqrt.c
w_sqrtf.c
w_sqrtl.c
w_tgamma.c
w_tgammaf.c
w_tgammal.c

README for libm-test math test suite
====================================

The libm-test math test suite tests a number of function points of
math functions in the GNU C library.  The following sections contain a
brief overview.  Please note that the test drivers and the Perl script
"gen-libm-test.pl" have some options.  A full list of options is
available with --help (for the test drivers) and -h for
"gen-libm-test.pl".


What is tested?
===============
The tests just evaluate the functions at specified points and compare
the results with precomputed values and the requirements of the ISO
C99 standard.

Besides testing the special values mandated by IEEE 754 (infinities,
NaNs and minus zero), some more or less random values are tested.

Files that are part of libm-test
================================

The main file is "libm-test.inc".  It is platform and floating point
format independent.  The file must be preprocessed by the Perl script
"gen-libm-test.pl".  The results are "libm-test.c" and a file
"libm-test-ulps.h" with platform specific deltas.

The test drivers test-double.c, test-float.c, test-ldouble.c test the
normal double, float and long double implementation of libm.  The test
drivers with an i in it (test-idouble.c, test-ifloat.c,
test-ildoubl.c) test the corresponding inline functions (where
available - otherwise they also test the real functions in libm).

"gen-libm-test.pl" needs a platform specific files with ULPs (Units of
Last Precision).  The file is called "libm-test-ulps" and lives in
platform specific sysdep directory.

How can I generate "libm-test-ulps"?
====================================

To automatically generate a new "libm-test-ulps" run "make regen-ulps".
This generates the file "math/NewUlps" in the build directory.  The file
contains the sorted results of all the tests.  You can use the "NewUlps"
file as the machine's updated "libm-test-ulps" file.  Copy "NewUlps" to
"libm-test-ulps" in the appropriate machine sysdep directory.  Verify
the changes, post your patch, and check it in after review.

To manually generate a new "libm-test-ulps" file, first remove "ULPs"
file in the current directory, then you can execute for example:
    ./testrun.sh math/test-double -u --ignore-max-ulp=yes
This generates a file "ULPs" with all double ULPs in it, ignoring any
previously calculated ULPs, and running with the newly built dynamic
loader and math library (assumes you didn't install your build).  Now
generate the ULPs for all other formats, the tests will be appending the
data to the "ULPs" file.  As final step run "gen-libm-test.pl" with the
file as input and ask to generate a pretty printed output in the file
"NewUlps":
  gen-libm-test.pl -u ULPs -n
Copy "NewUlps" to "libm-test-ulps" in the appropriate machine sysdep
directory.

Note that the test drivers have an option "-u" to output an unsorted
list of all epsilons that the functions have.  The output can be read
in directly but it's better to pretty print it first.
"gen-libm-test.pl" has an option to generate a pretty-printed and
sorted new ULPs file from the output of the test drivers.

Contents of libm-test-ulps
==========================

Since libm-test-ulps can be generated automatically, just a few notes.
The file contains lines for maximal errors of single functions, like:

Function "yn":
idouble: 6

The keywords are float, ifloat, double, idouble, ldouble and ildouble
(the prefix i stands for inline).

Adding tests to libm-test.inc
=============================

The tests are evaluated by a set of special test macros.  The macros
start with "TEST_" followed by a specification the input values, an
underscore and a specification of the output values.  As an example,
the test macro for a function with input of type FLOAT (FLOAT is
either float, double, long double) and output of type FLOAT is
"TEST_f_f".  The macro's parameter are the name of the function, the
input parameter, output parameter and optionally one exception
parameter.

The accepted parameter types are:
- "f" for FLOAT
- "b" for boolean - just tests if the output parameter evaluates to 0
  or 1 (only for output).
- "c" for complex.  This parameter needs two values, first the real,
  then the imaginary part.
- "i" for int.
- "l" for long int.
- "L" for long long int.
- "F" for the address of a FLOAT (only as input parameter)
- "I" for the address of an int (only as input parameter)