mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-30 00:31:08 +00:00
0292b0dd6c
invalid length [Coverity CID 106]. * nss/nss_files/files-key.c (search): Close stream before successful return [Coverity CID 107]. * io/fts.c (fts_open): Don't allocate parent if *argv==NULL [Coverity CID 108]. * sunrpc/rpc_cout.c (inline_struct): Free sizestr after use [Coverity CID 110, 109]. * sunrpc/rpc_scan.c (docppline): Free file string if it is not going to be used [Coverity CID 111]. * sysdeps/unix/sysv/linux/getsourcefilter.c (getsourcefilter): Free memory if socket level value cannot be retrieved [Coverity CID 112]. * nis/nis_clone_dir.c (nis_clone_directory): Free all memory in error case [Coverity CID 114]. * nis/nis_clone_res.c (nis_clone_result): Free all memory in the error cases [Coverity CID 115]. * sunrpc/rpc_parse.c (get_definition): Free defp if tok == TOK_EOF [Coverity CID 116]. * sysdeps/unix/sysv/linux/setsourcefilter.c (setsourcefilter): Free memory if socket level value cannot be retrieved [Coverity CID 117]. * elf/cache.c (save_cache): Initialize pad to avoid writing uninitialized data to disk. * elf/cache.c (save_cache): Free file_entries_new [Coverity CID 118]. * intl/finddomain.c (_nl_find_domain): Avoid strdup of expand locale name, use strdupa. Remove free call [Coverity CID 119]. * sunrpc/rpc_main.c (generate_guard): Avoid extra allocation and the resulting leak [Coverity CID 121]. * sunrpc/rpc_main.c (mkfile_output): Free all allocated memory [Coverity CID 122]. * sunrpc/rpc_main.c (h_output): Free guard after we are done [Coverity CID 123]. * sunrpc/svc_udp.c (cache_set): Free victim if newbuf allocation fails [Coverity CID 126]. * sunrpc/svc_udp.c (svcudp_enablecache): Free memory in error cases [Coverity CID 127]. * nis/nis_table.c (__create_ib_request): Free ibreq in case strdup fails [Coverity CID 128]. * nis/nis_getservlist.c (nis_getservlist): Free all memory in case of an error [Coverity CID 130, 129]. * nis/nis_print_group_entry.c (nis_print_group_entry): If nis_lookup call failed, return. Free lookup result in error cases [Coverity CID 131]. * nis/nis_removemember.c (nis_removemember): Free all memory in error cases [Coverity CID 132]. * nis/nss_nisplus/nisplus-alias.c (_nss_nisplus_getaliasbyname_r): Always free lookup result [Coverity CID 134]. * nis/nss_nisplus/nisplus-ethers.c (_nss_nisplus_gethostton_r): Always free lookup result [Coverity CID 135]. * nis/nss_nisplus/nisplus-ethers.c (_nss_nisplus_getntohost_r): Always free lookup result [Coverity CID 136]. * nis/nss_nisplus/nisplus-network.c (_nss_nisplus_getnetbyaddr_r): Before retrying, free old result [Coverity CID 137]. * nis/nss_nisplus/nisplus-publickey.c (_nss_nisplus_netname2user): Free res in case UID is zero [Coverity CID 138]. * nis/ypclnt.c (yp_update): Always free master string [Coverity CID 140]. * nis/nis_creategroup.c (nis_creategroup): Free all memory in error cases [Coverity CID 143, 142, 141]. * nis/nss_nis/nis-publickey.c (_nss_nis_getpublickey): Free result if yp_match call succeeded [Coverity CID 155]. * nis/nss_nis/nis-publickey.c (_nss_nis_getsecretkey): Free string allocated in yp_match at all times [Coverity CID 157, 156]. * nscd/nscd.c (write_pid): Close stream also if writing failed [Coverity CID 165]. * nis/nis_table.c (nis_add_entry): Move test for NULL parameter ahead of first use [Coverity CID 167]. * nis/nss_nis/nis-alias.c (_nss_nis_getaliasbyname_r): Move test for NULL parameter ahead of first use [Coverity CID 168]. * intl/finddomain.c (_nl_find_domain): We never return NULL if we found the locale [Coverity CID 169]. * inet/getnameinfo.c (getnameinfo): __getservbyport_r does not set herrno [Coverity CID 178]. * nis/nis_checkpoint.c (nis_checkpoint): Don't access and returned freed object [Coverity CID 182].
258 lines
5.7 KiB
C
258 lines
5.7 KiB
C
/* Fmemopen implementation.
|
|
Copyright (C) 2000, 2002, 2005, 2006 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Hanno Mueller, kontakt@hanno.de, 2000.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, write to the Free
|
|
Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
|
|
02111-1307 USA. */
|
|
|
|
/*
|
|
* fmemopen() - "my" version of a string stream
|
|
* Hanno Mueller, kontakt@hanno.de
|
|
*
|
|
*
|
|
* I needed fmemopen() for an application that I currently work on,
|
|
* but couldn't find it in libio. The following snippet of code is an
|
|
* attempt to implement what glibc's documentation describes.
|
|
*
|
|
*
|
|
*
|
|
* I already see some potential problems:
|
|
*
|
|
* - I never used the "original" fmemopen(). I am sure that "my"
|
|
* fmemopen() behaves differently than the original version.
|
|
*
|
|
* - The documentation doesn't say wether a string stream allows
|
|
* seeks. I checked the old fmemopen implementation in glibc's stdio
|
|
* directory, wasn't quite able to see what is going on in that
|
|
* source, but as far as I understand there was no seek there. For
|
|
* my application, I needed fseek() and ftell(), so it's here.
|
|
*
|
|
* - "append" mode and fseek(p, SEEK_END) have two different ideas
|
|
* about the "end" of the stream.
|
|
*
|
|
* As described in the documentation, when opening the file in
|
|
* "append" mode, the position pointer will be set to the first null
|
|
* character of the string buffer (yet the buffer may already
|
|
* contain more data). For fseek(), the last byte of the buffer is
|
|
* used as the end of the stream.
|
|
*
|
|
* - It is unclear to me what the documentation tries to say when it
|
|
* explains what happens when you use fmemopen with a NULL
|
|
* buffer.
|
|
*
|
|
* Quote: "fmemopen [then] allocates an array SIZE bytes long. This
|
|
* is really only useful if you are going to write things to the
|
|
* buffer and then read them back in again."
|
|
*
|
|
* What does that mean if the original fmemopen() did not allow
|
|
* seeking? How do you read what you just wrote without seeking back
|
|
* to the beginning of the stream?
|
|
*
|
|
* - I think there should be a second version of fmemopen() that does
|
|
* not add null characters for each write. (At least in my
|
|
* application, I am not actually using strings but binary data and
|
|
* so I don't need the stream to add null characters on its own.)
|
|
*/
|
|
|
|
#include <errno.h>
|
|
#include <libio.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <stdint.h>
|
|
#include <string.h>
|
|
#include <sys/types.h>
|
|
#include "libioP.h"
|
|
|
|
|
|
typedef struct fmemopen_cookie_struct fmemopen_cookie_t;
|
|
struct fmemopen_cookie_struct
|
|
{
|
|
char *buffer;
|
|
int mybuffer;
|
|
size_t size;
|
|
_IO_off64_t pos;
|
|
size_t maxpos;
|
|
};
|
|
|
|
|
|
static ssize_t
|
|
fmemopen_read (void *cookie, char *b, size_t s)
|
|
{
|
|
fmemopen_cookie_t *c;
|
|
|
|
c = (fmemopen_cookie_t *) cookie;
|
|
|
|
if (c->pos + s > c->size)
|
|
{
|
|
if ((size_t) c->pos == c->size)
|
|
return 0;
|
|
s = c->size - c->pos;
|
|
}
|
|
|
|
memcpy (b, &(c->buffer[c->pos]), s);
|
|
|
|
c->pos += s;
|
|
if ((size_t) c->pos > c->maxpos)
|
|
c->maxpos = c->pos;
|
|
|
|
return s;
|
|
}
|
|
|
|
|
|
static ssize_t
|
|
fmemopen_write (void *cookie, const char *b, size_t s)
|
|
{
|
|
fmemopen_cookie_t *c;
|
|
int addnullc;
|
|
|
|
c = (fmemopen_cookie_t *) cookie;
|
|
|
|
addnullc = s == 0 || b[s - 1] != '\0';
|
|
|
|
if (c->pos + s + addnullc > c->size)
|
|
{
|
|
if ((size_t) (c->pos + addnullc) == c->size)
|
|
{
|
|
__set_errno (ENOSPC);
|
|
return 0;
|
|
}
|
|
s = c->size - c->pos - addnullc;
|
|
}
|
|
|
|
memcpy (&(c->buffer[c->pos]), b, s);
|
|
|
|
c->pos += s;
|
|
if ((size_t) c->pos > c->maxpos)
|
|
{
|
|
c->maxpos = c->pos;
|
|
if (addnullc)
|
|
c->buffer[c->maxpos] = '\0';
|
|
}
|
|
|
|
return s;
|
|
}
|
|
|
|
|
|
static int
|
|
fmemopen_seek (void *cookie, _IO_off64_t *p, int w)
|
|
{
|
|
_IO_off64_t np;
|
|
fmemopen_cookie_t *c;
|
|
|
|
c = (fmemopen_cookie_t *) cookie;
|
|
|
|
switch (w)
|
|
{
|
|
case SEEK_SET:
|
|
np = *p;
|
|
break;
|
|
|
|
case SEEK_CUR:
|
|
np = c->pos + *p;
|
|
break;
|
|
|
|
case SEEK_END:
|
|
np = c->maxpos - *p;
|
|
break;
|
|
|
|
default:
|
|
return -1;
|
|
}
|
|
|
|
if (np < 0 || (size_t) np > c->size)
|
|
return -1;
|
|
|
|
*p = c->pos = np;
|
|
|
|
return 0;
|
|
}
|
|
|
|
|
|
static int
|
|
fmemopen_close (void *cookie)
|
|
{
|
|
fmemopen_cookie_t *c;
|
|
|
|
c = (fmemopen_cookie_t *) cookie;
|
|
|
|
if (c->mybuffer)
|
|
free (c->buffer);
|
|
free (c);
|
|
|
|
return 0;
|
|
}
|
|
|
|
|
|
FILE *
|
|
fmemopen (void *buf, size_t len, const char *mode)
|
|
{
|
|
cookie_io_functions_t iof;
|
|
fmemopen_cookie_t *c;
|
|
|
|
if (__builtin_expect (len == 0, 0))
|
|
{
|
|
einval:
|
|
__set_errno (EINVAL);
|
|
return NULL;
|
|
}
|
|
|
|
c = (fmemopen_cookie_t *) malloc (sizeof (fmemopen_cookie_t));
|
|
if (c == NULL)
|
|
return NULL;
|
|
|
|
c->mybuffer = (buf == NULL);
|
|
|
|
if (c->mybuffer)
|
|
{
|
|
c->buffer = (char *) malloc (len);
|
|
if (c->buffer == NULL)
|
|
{
|
|
free (c);
|
|
return NULL;
|
|
}
|
|
c->buffer[0] = '\0';
|
|
}
|
|
else
|
|
{
|
|
if (__builtin_expect ((uintptr_t) len > -(uintptr_t) buf, 0))
|
|
{
|
|
free (c);
|
|
goto einval;
|
|
}
|
|
|
|
c->buffer = buf;
|
|
}
|
|
|
|
c->size = len;
|
|
|
|
if (mode[0] == 'w')
|
|
c->buffer[0] = '\0';
|
|
|
|
c->maxpos = strlen (c->buffer);
|
|
|
|
if (mode[0] == 'a')
|
|
c->pos = c->maxpos;
|
|
else
|
|
c->pos = 0;
|
|
|
|
iof.read = fmemopen_read;
|
|
iof.write = fmemopen_write;
|
|
iof.seek = fmemopen_seek;
|
|
iof.close = fmemopen_close;
|
|
|
|
return _IO_fopencookie (c, mode, iof);
|
|
}
|