mirror of
https://sourceware.org/git/glibc.git
synced 2024-09-20 08:30:00 +00:00
5c112f1b62
Various glibc testcases use tmpnam in ways subject to race conditions (generate a temporary file name, then later open that file without O_EXCL). This patch fixes those tests to use mkstemp - generally a minimal local fix to use mkstemp instead of tmpnam, rather than a larger fix to use other testsuite infrastructure for temporary files. The unchanged use of tmpnam in posix/wordexp-test.c would fail safe in the event of a race (it's generating a name for use with mkdir rather than for a file to be opened for writing). Tested for x86_64. * grp/tst_fgetgrent.c: Include <unistd.h>. (main): Use mkstemp instead of tmpnam. * io/test-utime.c (main): Likewise. * posix/annexc.c (macrofile): Change to modifiable array. (get_null_defines): Use mkstemp instead of tmpnam. Do not remove macrofile here. * posix/bug-getopt1.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt2.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt3.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt4.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt5.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * stdio-common/bug7.c: Include <stdlib.h> and <unistd.h>. (main): Use mkstemp instead of tmpnam. * stdio-common/tst-fdopen.c: Include <stdlib.h>. (main): Use mkstemp instead of tmpnam. * stdio-common/tst-ungetc.c: Include <stdlib.h>. (main): use mkstemp instead of tmpnam. * stdlib/isomac.c (macrofile): Change to modifiable array. (get_null_defines): Use mkstemp instead of tmpnam. Do not remove macrofile here.
136 lines
3.1 KiB
C
136 lines
3.1 KiB
C
/* Copyright (C) 1994-2018 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <fcntl.h>
|
|
#include <stdint.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <sys/stat.h>
|
|
#include <unistd.h>
|
|
#include <utime.h>
|
|
#include <time.h>
|
|
|
|
int
|
|
main (int argc, char *argv[])
|
|
{
|
|
char file[] = "/tmp/test-utime.XXXXXX";
|
|
struct utimbuf ut;
|
|
struct stat st;
|
|
struct stat stnow;
|
|
time_t now1, now2;
|
|
int fd;
|
|
|
|
fd = mkstemp (file);
|
|
if (fd < 0)
|
|
{
|
|
perror ("mkstemp");
|
|
return 1;
|
|
}
|
|
close (fd);
|
|
|
|
/* Test utime with arg */
|
|
ut.actime = 500000000;
|
|
ut.modtime = 500000001;
|
|
if (utime (file, &ut))
|
|
{
|
|
perror ("utime");
|
|
remove (file);
|
|
return 1;
|
|
}
|
|
|
|
if (stat (file, &st))
|
|
{
|
|
perror ("stat");
|
|
remove (file);
|
|
return 1;
|
|
}
|
|
|
|
/* Test utime with NULL.
|
|
Since there's a race condition possible here, we check
|
|
the time before and after the call to utime. */
|
|
now1 = time (NULL);
|
|
if (now1 == (time_t)-1)
|
|
{
|
|
perror ("time");
|
|
remove (file);
|
|
return 1;
|
|
}
|
|
|
|
/* The clocks used to set the modification time and that used in the
|
|
time() call need not be the same. They need not have the same
|
|
precision. Therefore we delay the following operation by one
|
|
second which makes sure we can compare with second precision. */
|
|
sleep (1);
|
|
|
|
if (utime (file, NULL))
|
|
{
|
|
perror ("utime NULL");
|
|
remove (file);
|
|
return 1;
|
|
}
|
|
|
|
sleep (1);
|
|
|
|
now2 = time (NULL);
|
|
if (now2 == (time_t)-1)
|
|
{
|
|
perror ("time");
|
|
remove (file);
|
|
return 1;
|
|
}
|
|
|
|
if (stat (file, &stnow))
|
|
{
|
|
perror ("stat");
|
|
remove (file);
|
|
return 1;
|
|
}
|
|
|
|
remove (file);
|
|
|
|
if (st.st_mtime != ut.modtime)
|
|
{
|
|
printf ("modtime %jd != %jd\n",
|
|
(intmax_t) st.st_mtime, (intmax_t) ut.modtime);
|
|
return 1;
|
|
}
|
|
|
|
if (st.st_atime != ut.actime)
|
|
{
|
|
printf ("actime %jd != %jd\n",
|
|
(intmax_t) st.st_atime, (intmax_t) ut.actime);
|
|
return 1;
|
|
}
|
|
|
|
if (stnow.st_mtime < now1 || stnow.st_mtime > now2)
|
|
{
|
|
printf ("modtime %jd <%jd >%jd\n",
|
|
(intmax_t) stnow.st_mtime, (intmax_t) now1, (intmax_t) now2);
|
|
return 1;
|
|
}
|
|
|
|
if (stnow.st_atime < now1 || stnow.st_atime > now2)
|
|
{
|
|
printf ("actime %jd <%jd >%jd\n",
|
|
(intmax_t) stnow.st_atime, (intmax_t) now1, (intmax_t) now2);
|
|
return 1;
|
|
}
|
|
|
|
puts ("Test succeeded.");
|
|
return 0;
|
|
}
|