mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-26 04:31:03 +00:00
c579f48edb
This patch remove the PID cache and usage in current GLIBC code. Current usage is mainly used a performance optimization to avoid the syscall, however it adds some issues: - The exposed clone syscall will try to set pid/tid to make the new thread somewhat compatible with current GLIBC assumptions. This cause a set of issue with new workloads and usecases (such as BZ#17214 and [1]) as well for new internal usage of clone to optimize other algorithms (such as clone plus CLONE_VM for posix_spawn, BZ#19957). - The caching complexity also added some bugs in the past [2] [3] and requires more effort of each port to handle such requirements (for both clone and vfork implementation). - Caching performance gain in mainly on getpid and some specific code paths. The getpid performance leverage is questionable [4], either by the idea of getpid being a hotspot as for the getpid implementation itself (if it is indeed a justifiable hotspot a vDSO symbol could let to a much more simpler solution). Other usage is mainly for non usual code paths, such as pthread cancellation signal and handling. For thread creation (on stack allocation) the code simplification in fact adds some performance gain due the no need of transverse the stack cache and invalidate each element pid. Other thread usages will require a direct getpid syscall, such as cancellation/setxid signal, thread cancellation, thread fail path (at create_thread), and thread signal (pthread_kill and pthread_sigqueue). However these are hardly usual hotspots and I think adding a syscall is justifiable. It also simplifies both the clone and vfork arch-specific implementation. And by review each fork implementation there are some discrepancies that this patch also solves: - microblaze clone/vfork does not set/reset the pid/tid field - hppa uses the default vfork implementation that fallback to fork. Since vfork is deprecated I do not think we should bother with it. The patch also removes the TID caching in clone. My understanding for such semantic is try provide some pthread usage after a user program issue clone directly (as done by thread creation with CLONE_PARENT_SETTID and pthread tid member). However, as stated before in multiple discussions threads, GLIBC provides clone syscalls without further supporting all this semantics. I ran a full make check on x86_64, x32, i686, armhf, aarch64, and powerpc64le. For sparc32, sparc64, and mips I ran the basic fork and vfork tests from posix/ folder (on a qemu system). So it would require further testing on alpha, hppa, ia64, m68k, nios2, s390, sh, and tile (I excluded microblaze because it is already implementing the patch semantic regarding clone/vfork). [1] https://codereview.chromium.org/800183004/ [2] https://sourceware.org/ml/libc-alpha/2006-07/msg00123.html [3] https://sourceware.org/bugzilla/show_bug.cgi?id=15368 [4] http://yarchive.net/comp/linux/getpid_caching.html * sysdeps/nptl/fork.c (__libc_fork): Remove pid cache setting. * nptl/allocatestack.c (allocate_stack): Likewise. (__reclaim_stacks): Likewise. (setxid_signal_thread): Obtain pid through syscall. * nptl/nptl-init.c (sigcancel_handler): Likewise. (sighandle_setxid): Likewise. * nptl/pthread_cancel.c (pthread_cancel): Likewise. * sysdeps/unix/sysv/linux/pthread_kill.c (__pthread_kill): Likewise. * sysdeps/unix/sysv/linux/pthread_sigqueue.c (pthread_sigqueue): Likewise. * sysdeps/unix/sysv/linux/createthread.c (create_thread): Likewise. * sysdeps/unix/sysv/linux/getpid.c: Remove file. * nptl/descr.h (struct pthread): Change comment about pid value. * nptl/pthread_getattr_np.c (pthread_getattr_np): Remove thread pid assert. * sysdeps/unix/sysv/linux/pthread-pids.h (__pthread_initialize_pids): Do not set pid value. * nptl_db/td_ta_thr_iter.c (iterate_thread_list): Remove thread pid cache check. * nptl_db/td_thr_validate.c (td_thr_validate): Likewise. * sysdeps/aarch64/nptl/tcb-offsets.sym: Remove pid offset. * sysdeps/alpha/nptl/tcb-offsets.sym: Likewise. * sysdeps/arm/nptl/tcb-offsets.sym: Likewise. * sysdeps/hppa/nptl/tcb-offsets.sym: Likewise. * sysdeps/i386/nptl/tcb-offsets.sym: Likewise. * sysdeps/ia64/nptl/tcb-offsets.sym: Likewise. * sysdeps/m68k/nptl/tcb-offsets.sym: Likewise. * sysdeps/microblaze/nptl/tcb-offsets.sym: Likewise. * sysdeps/mips/nptl/tcb-offsets.sym: Likewise. * sysdeps/nios2/nptl/tcb-offsets.sym: Likewise. * sysdeps/powerpc/nptl/tcb-offsets.sym: Likewise. * sysdeps/s390/nptl/tcb-offsets.sym: Likewise. * sysdeps/sh/nptl/tcb-offsets.sym: Likewise. * sysdeps/sparc/nptl/tcb-offsets.sym: Likewise. * sysdeps/tile/nptl/tcb-offsets.sym: Likewise. * sysdeps/x86_64/nptl/tcb-offsets.sym: Likewise. * sysdeps/unix/sysv/linux/aarch64/clone.S: Remove pid and tid caching. * sysdeps/unix/sysv/linux/alpha/clone.S: Likewise. * sysdeps/unix/sysv/linux/arm/clone.S: Likewise. * sysdeps/unix/sysv/linux/hppa/clone.S: Likewise. * sysdeps/unix/sysv/linux/i386/clone.S: Likewise. * sysdeps/unix/sysv/linux/ia64/clone2.S: Likewise. * sysdeps/unix/sysv/linux/mips/clone.S: Likewise. * sysdeps/unix/sysv/linux/nios2/clone.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/clone.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/clone.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/clone.S: Likewise. * sysdeps/unix/sysv/linux/sh/clone.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/clone.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/clone.S: Likewise. * sysdeps/unix/sysv/linux/tile/clone.S: Likewise. * sysdeps/unix/sysv/linux/x86_64/clone.S: Likewise. * sysdeps/unix/sysv/linux/aarch64/vfork.S: Remove pid set and reset. * sysdeps/unix/sysv/linux/alpha/vfork.S: Likewise. * sysdeps/unix/sysv/linux/arm/vfork.S: Likewise. * sysdeps/unix/sysv/linux/i386/vfork.S: Likewise. * sysdeps/unix/sysv/linux/ia64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/m68k/clone.S: Likewise. * sysdeps/unix/sysv/linux/m68k/vfork.S: Likewise. * sysdeps/unix/sysv/linux/mips/vfork.S: Likewise. * sysdeps/unix/sysv/linux/nios2/vfork.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/vfork.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/vfork.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/sh/vfork.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/vfork.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/tile/vfork.S: Likewise. * sysdeps/unix/sysv/linux/x86_64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/tst-clone2.c (f): Remove direct pthread struct access. (clone_test): Remove function. (do_test): Rewrite to take in consideration pid is not cached anymore.
256 lines
7.6 KiB
C
256 lines
7.6 KiB
C
/* Copyright (C) 2002-2016 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Ulrich Drepper <drepper@redhat.com>, 2002.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <assert.h>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
#include <sys/types.h>
|
|
#include <sysdep.h>
|
|
#include <libio/libioP.h>
|
|
#include <tls.h>
|
|
#include <hp-timing.h>
|
|
#include <ldsodefs.h>
|
|
#include <stdio-lock.h>
|
|
#include <atomic.h>
|
|
#include <nptl/pthreadP.h>
|
|
#include <fork.h>
|
|
#include <arch-fork.h>
|
|
#include <futex-internal.h>
|
|
#include <malloc/malloc-internal.h>
|
|
|
|
static void
|
|
fresetlockfiles (void)
|
|
{
|
|
_IO_ITER i;
|
|
|
|
for (i = _IO_iter_begin(); i != _IO_iter_end(); i = _IO_iter_next(i))
|
|
if ((_IO_iter_file (i)->_flags & _IO_USER_LOCK) == 0)
|
|
_IO_lock_init (*((_IO_lock_t *) _IO_iter_file(i)->_lock));
|
|
}
|
|
|
|
|
|
pid_t
|
|
__libc_fork (void)
|
|
{
|
|
pid_t pid;
|
|
struct used_handler
|
|
{
|
|
struct fork_handler *handler;
|
|
struct used_handler *next;
|
|
} *allp = NULL;
|
|
|
|
/* Determine if we are running multiple threads. We skip some fork
|
|
handlers in the single-thread case, to make fork safer to use in
|
|
signal handlers. POSIX requires that fork is async-signal-safe,
|
|
but our current fork implementation is not. */
|
|
bool multiple_threads = THREAD_GETMEM (THREAD_SELF, header.multiple_threads);
|
|
|
|
/* Run all the registered preparation handlers. In reverse order.
|
|
While doing this we build up a list of all the entries. */
|
|
struct fork_handler *runp;
|
|
while ((runp = __fork_handlers) != NULL)
|
|
{
|
|
/* Make sure we read from the current RUNP pointer. */
|
|
atomic_full_barrier ();
|
|
|
|
unsigned int oldval = runp->refcntr;
|
|
|
|
if (oldval == 0)
|
|
/* This means some other thread removed the list just after
|
|
the pointer has been loaded. Try again. Either the list
|
|
is empty or we can retry it. */
|
|
continue;
|
|
|
|
/* Bump the reference counter. */
|
|
if (atomic_compare_and_exchange_bool_acq (&__fork_handlers->refcntr,
|
|
oldval + 1, oldval))
|
|
/* The value changed, try again. */
|
|
continue;
|
|
|
|
/* We bumped the reference counter for the first entry in the
|
|
list. That means that none of the following entries will
|
|
just go away. The unloading code works in the order of the
|
|
list.
|
|
|
|
While executing the registered handlers we are building a
|
|
list of all the entries so that we can go backward later on. */
|
|
while (1)
|
|
{
|
|
/* Execute the handler if there is one. */
|
|
if (runp->prepare_handler != NULL)
|
|
runp->prepare_handler ();
|
|
|
|
/* Create a new element for the list. */
|
|
struct used_handler *newp
|
|
= (struct used_handler *) alloca (sizeof (*newp));
|
|
newp->handler = runp;
|
|
newp->next = allp;
|
|
allp = newp;
|
|
|
|
/* Advance to the next handler. */
|
|
runp = runp->next;
|
|
if (runp == NULL)
|
|
break;
|
|
|
|
/* Bump the reference counter for the next entry. */
|
|
atomic_increment (&runp->refcntr);
|
|
}
|
|
|
|
/* We are done. */
|
|
break;
|
|
}
|
|
|
|
/* If we are not running multiple threads, we do not have to
|
|
preserve lock state. If fork runs from a signal handler, only
|
|
async-signal-safe functions can be used in the child. These data
|
|
structures are only used by unsafe functions, so their state does
|
|
not matter if fork was called from a signal handler. */
|
|
if (multiple_threads)
|
|
{
|
|
_IO_list_lock ();
|
|
|
|
/* Acquire malloc locks. This needs to come last because fork
|
|
handlers may use malloc, and the libio list lock has an
|
|
indirect malloc dependency as well (via the getdelim
|
|
function). */
|
|
call_function_static_weak (__malloc_fork_lock_parent);
|
|
}
|
|
|
|
#ifndef NDEBUG
|
|
pid_t ppid = THREAD_GETMEM (THREAD_SELF, tid);
|
|
#endif
|
|
|
|
#ifdef ARCH_FORK
|
|
pid = ARCH_FORK ();
|
|
#else
|
|
# error "ARCH_FORK must be defined so that the CLONE_SETTID flag is used"
|
|
pid = INLINE_SYSCALL (fork, 0);
|
|
#endif
|
|
|
|
|
|
if (pid == 0)
|
|
{
|
|
struct pthread *self = THREAD_SELF;
|
|
|
|
assert (THREAD_GETMEM (self, tid) != ppid);
|
|
|
|
/* See __pthread_once. */
|
|
if (__fork_generation_pointer != NULL)
|
|
*__fork_generation_pointer += __PTHREAD_ONCE_FORK_GEN_INCR;
|
|
|
|
#if HP_TIMING_AVAIL
|
|
/* The CPU clock of the thread and process have to be set to zero. */
|
|
hp_timing_t now;
|
|
HP_TIMING_NOW (now);
|
|
THREAD_SETMEM (self, cpuclock_offset, now);
|
|
GL(dl_cpuclock_offset) = now;
|
|
#endif
|
|
|
|
#ifdef __NR_set_robust_list
|
|
/* Initialize the robust mutex list which has been reset during
|
|
the fork. We do not check for errors since if it fails here
|
|
it failed at process start as well and noone could have used
|
|
robust mutexes. We also do not have to set
|
|
self->robust_head.futex_offset since we inherit the correct
|
|
value from the parent. */
|
|
# ifdef SHARED
|
|
if (__builtin_expect (__libc_pthread_functions_init, 0))
|
|
PTHFCT_CALL (ptr_set_robust, (self));
|
|
# else
|
|
extern __typeof (__nptl_set_robust) __nptl_set_robust
|
|
__attribute__((weak));
|
|
if (__builtin_expect (__nptl_set_robust != NULL, 0))
|
|
__nptl_set_robust (self);
|
|
# endif
|
|
#endif
|
|
|
|
/* Reset the lock state in the multi-threaded case. */
|
|
if (multiple_threads)
|
|
{
|
|
/* Release malloc locks. */
|
|
call_function_static_weak (__malloc_fork_unlock_child);
|
|
|
|
/* Reset the file list. These are recursive mutexes. */
|
|
fresetlockfiles ();
|
|
|
|
/* Reset locks in the I/O code. */
|
|
_IO_list_resetlock ();
|
|
}
|
|
|
|
/* Reset the lock the dynamic loader uses to protect its data. */
|
|
__rtld_lock_initialize (GL(dl_load_lock));
|
|
|
|
/* Run the handlers registered for the child. */
|
|
while (allp != NULL)
|
|
{
|
|
if (allp->handler->child_handler != NULL)
|
|
allp->handler->child_handler ();
|
|
|
|
/* Note that we do not have to wake any possible waiter.
|
|
This is the only thread in the new process. The count
|
|
may have been bumped up by other threads doing a fork.
|
|
We reset it to 1, to avoid waiting for non-existing
|
|
thread(s) to release the count. */
|
|
allp->handler->refcntr = 1;
|
|
|
|
/* XXX We could at this point look through the object pool
|
|
and mark all objects not on the __fork_handlers list as
|
|
unused. This is necessary in case the fork() happened
|
|
while another thread called dlclose() and that call had
|
|
to create a new list. */
|
|
|
|
allp = allp->next;
|
|
}
|
|
|
|
/* Initialize the fork lock. */
|
|
__fork_lock = LLL_LOCK_INITIALIZER;
|
|
}
|
|
else
|
|
{
|
|
assert (THREAD_GETMEM (THREAD_SELF, tid) == ppid);
|
|
|
|
/* Release acquired locks in the multi-threaded case. */
|
|
if (multiple_threads)
|
|
{
|
|
/* Release malloc locks, parent process variant. */
|
|
call_function_static_weak (__malloc_fork_unlock_parent);
|
|
|
|
/* We execute this even if the 'fork' call failed. */
|
|
_IO_list_unlock ();
|
|
}
|
|
|
|
/* Run the handlers registered for the parent. */
|
|
while (allp != NULL)
|
|
{
|
|
if (allp->handler->parent_handler != NULL)
|
|
allp->handler->parent_handler ();
|
|
|
|
if (atomic_decrement_and_test (&allp->handler->refcntr)
|
|
&& allp->handler->need_signal)
|
|
futex_wake (&allp->handler->refcntr, 1, FUTEX_PRIVATE);
|
|
|
|
allp = allp->next;
|
|
}
|
|
}
|
|
|
|
return pid;
|
|
}
|
|
weak_alias (__libc_fork, __fork)
|
|
libc_hidden_def (__fork)
|
|
weak_alias (__libc_fork, fork)
|