mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-23 11:20:07 +00:00
9fe3c80c7c
sys/socket.h includes sys/uio.h to get the definition of the iovec
structure.
POSIX allows sys/socket.h to make all sys/uio.h symbols visible.
However, all of sys/uio.h is XSI-shaded, so for non-XSI POSIX this
results in conformtest failures (for sys/socket.h and other headers
that include it):
Namespace violation: "UIO_MAXIOV"
Namespace violation: "readv"
Namespace violation: "writev"
Now, there is some ambiguity in POSIX about what namespace
reservations apply in this case - see
http://austingroupbugs.net/view.php?id=1127 - but glibc convention
would still avoid declaring readv and writev, for example, for feature
test macros that don't include them (if only headers from the relevant
standard are included), even if such declarations are permitted, so
there is a bug here according to glibc conventions.
This patch moves the struct iovec definition to a new
bits/types/struct_iovec.h header and includes that from sys/socket.h
instead of including the whole of sys/uio.h. This fixes the namespace
issue; however, three files in glibc that were relying on the implicit
inclusion needed to be updated to include sys/uio.h explicitly. So
there is a question of whether sys/socket.h should continue to include
sys/uio.h under some conditions, such as __USE_XOPEN or __USE_MISC or
__USE_XOPEN || __USE_MISC, for greater compatibility with code that
(wrongly) expects this optional inclusion to be present there. (I
think the three affected files in glibc should still have explicit
sys/uio.h inclusions added in any case, however.)
Tested for x86_64.
[BZ #21426]
* misc/bits/types/struct_iovec.h: New file.
* misc/Makefile (headers): Add bits/types/struct_iovec.h.
* include/bits/types/struct_iovec.h: New file.
* bits/uio.h (struct iovec): Replace by inclusion of
<bits/types/struct_iovec.h>.
* sysdeps/unix/sysv/linux/bits/uio.h (struct iovec): Likewise.
* socket/sys/socket.h: Include <bits/types/struct_iovec.h> instead
of <sys/uio.h>.
* nptl/tst-cancel4.c: Include <sys/uio.h>
* posix/test-errno.c: Likewise.
* support/resolv_test.c: Likewise.
* conform/Makefile (test-xfail-POSIX2008/arpa/inet.h/conform):
Remove.
(test-xfail-POSIX2008/netdb.h/conform): Likewise.
(test-xfail-POSIX2008/netinet/in.h/conform): Likewise.
(test-xfail-POSIX2008/sys/socket.h/conform): Likewise.
267 lines
11 KiB
Makefile
267 lines
11 KiB
Makefile
# Copyright (C) 1999-2017 Free Software Foundation, Inc.
|
|
# This file is part of the GNU C Library.
|
|
|
|
# The GNU C Library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2.1 of the License, or (at your option) any later version.
|
|
|
|
# The GNU C Library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with the GNU C Library; if not, see
|
|
# <http://www.gnu.org/licenses/>.
|
|
|
|
#
|
|
# Sub-makefile for conform portion of the library.
|
|
#
|
|
subdir := conform
|
|
|
|
include ../Makeconfig
|
|
|
|
conformtest-headers-data := $(wildcard data/*.h-data) \
|
|
$(wildcard data/*/*.h-data)
|
|
|
|
conformtest-standards := ISO ISO99 ISO11 POSIX XPG3 XPG4 UNIX98 XOPEN2K \
|
|
POSIX2008 XOPEN2K8
|
|
|
|
conformtest-headers-ISO := assert.h ctype.h errno.h float.h limits.h locale.h \
|
|
math.h setjmp.h signal.h stdarg.h stddef.h stdio.h \
|
|
stdlib.h string.h time.h
|
|
conformtest-headers-ISO99 := $(conformtest-headers-ISO) complex.h fenv.h \
|
|
inttypes.h iso646.h stdbool.h stdint.h tgmath.h \
|
|
wchar.h wctype.h
|
|
# Missing ISO11 expectations for: stdatomic.h threads.h.
|
|
conformtest-headers-ISO11 := $(conformtest-headers-ISO99) stdalign.h \
|
|
stdnoreturn.h uchar.h
|
|
conformtest-headers-POSIX := $(conformtest-headers-ISO) aio.h dirent.h \
|
|
fcntl.h fnmatch.h glob.h grp.h mqueue.h \
|
|
pthread.h pwd.h regex.h sched.h semaphore.h \
|
|
sys/mman.h sys/stat.h sys/times.h sys/types.h \
|
|
sys/utsname.h sys/wait.h tar.h termios.h \
|
|
unistd.h utime.h wordexp.h
|
|
# Missing XPG3 expectations for: regexp.h wchar.h.
|
|
conformtest-headers-XPG3 := $(conformtest-headers-ISO) cpio.h dirent.h \
|
|
fcntl.h fnmatch.h ftw.h glob.h grp.h iconv.h \
|
|
langinfo.h monetary.h nl_types.h pwd.h regex.h \
|
|
search.h sys/ipc.h sys/msg.h sys/sem.h sys/shm.h \
|
|
sys/stat.h sys/times.h sys/types.h sys/utsname.h \
|
|
sys/wait.h tar.h termios.h ulimit.h unistd.h \
|
|
utime.h varargs.h wordexp.h
|
|
# Missing XPG4 expectations for: re_comp.h regexp.h wchar.h.
|
|
# XPG4 includes XTI, but xti.h is outside the scope of these tests.
|
|
conformtest-headers-XPG4 := $(conformtest-headers-XPG3) arpa/inet.h fmtmsg.h \
|
|
libgen.h ndbm.h netdb.h netinet/in.h poll.h \
|
|
strings.h stropts.h sys/mman.h sys/resource.h \
|
|
sys/socket.h sys/statvfs.h sys/time.h sys/timeb.h \
|
|
sys/uio.h sys/un.h syslog.h ucontext.h utmpx.h
|
|
# Missing UNIX98 expectations for: inttypes.h re_comp.h regexp.h.
|
|
# The online UNIX98 includes XCURSES, but curses.h, term.h and
|
|
# unctrl.h are outside the scope of these tests. It also includes
|
|
# XTI, but xti.h is outside the scope of these tests.
|
|
conformtest-headers-UNIX98 := $(conformtest-headers-POSIX) arpa/inet.h cpio.h \
|
|
dlfcn.h fmtmsg.h ftw.h iconv.h iso646.h \
|
|
langinfo.h libgen.h monetary.h ndbm.h netdb.h \
|
|
netinet/in.h nl_types.h poll.h search.h \
|
|
strings.h stropts.h sys/ipc.h sys/msg.h \
|
|
sys/resource.h sys/sem.h sys/shm.h sys/socket.h \
|
|
sys/statvfs.h sys/time.h sys/timeb.h sys/uio.h \
|
|
sys/un.h syslog.h ucontext.h ulimit.h utmpx.h \
|
|
varargs.h wchar.h wctype.h
|
|
# Missing XOPEN2K expectations for: trace.h.
|
|
conformtest-headers-XOPEN2K := $(conformtest-headers-POSIX) arpa/inet.h \
|
|
complex.h cpio.h dlfcn.h fenv.h fmtmsg.h ftw.h \
|
|
iconv.h inttypes.h iso646.h langinfo.h \
|
|
libgen.h monetary.h ndbm.h net/if.h netdb.h \
|
|
netinet/in.h netinet/tcp.h nl_types.h poll.h \
|
|
search.h spawn.h stdbool.h stdint.h strings.h \
|
|
stropts.h sys/ipc.h sys/msg.h sys/resource.h \
|
|
sys/select.h sys/sem.h sys/shm.h sys/socket.h \
|
|
sys/statvfs.h sys/time.h sys/timeb.h sys/uio.h \
|
|
sys/un.h syslog.h tgmath.h ucontext.h ulimit.h \
|
|
utmpx.h wchar.h wctype.h
|
|
# Missing POSIX2008 expectations for: trace.h.
|
|
conformtest-headers-POSIX2008 := $(conformtest-headers-POSIX) arpa/inet.h \
|
|
complex.h cpio.h dlfcn.h fenv.h iconv.h \
|
|
inttypes.h iso646.h langinfo.h monetary.h \
|
|
net/if.h netdb.h netinet/in.h netinet/tcp.h \
|
|
nl_types.h poll.h spawn.h stdbool.h stdint.h \
|
|
strings.h stropts.h sys/select.h \
|
|
sys/socket.h sys/statvfs.h sys/un.h tgmath.h \
|
|
wchar.h wctype.h
|
|
# Missing XOPEN2K8 expectations for: trace.h.
|
|
conformtest-headers-XOPEN2K8 := $(conformtest-headers-POSIX2008) fmtmsg.h \
|
|
ftw.h libgen.h ndbm.h search.h sys/ipc.h \
|
|
sys/msg.h sys/resource.h sys/sem.h sys/shm.h \
|
|
sys/time.h sys/uio.h syslog.h ulimit.h utmpx.h
|
|
|
|
conformtest-header-list-base := $(foreach std,$(conformtest-standards),\
|
|
header-list-$(std).out)
|
|
conformtest-header-list-tests := $(addprefix $(objpfx),\
|
|
$(conformtest-header-list-base))
|
|
tests-special += $(conformtest-header-list-tests)
|
|
generated += $(conformtest-header-list-base)
|
|
|
|
conformtest-header-base := $(foreach std,\
|
|
$(conformtest-standards),\
|
|
$(foreach h,\
|
|
$(conformtest-headers-$(std)),\
|
|
$(std)/$(h)/conform.out))
|
|
conformtest-header-tests := $(addprefix $(objpfx),$(conformtest-header-base))
|
|
ifneq (yes,$(fast-check))
|
|
tests-special += $(conformtest-header-tests)
|
|
generated += $(conformtest-header-base)
|
|
endif
|
|
|
|
linknamespace-symlists-base := $(foreach std,$(conformtest-standards),\
|
|
symlist-$(std))
|
|
linknamespace-symlists-tests := $(addprefix $(objpfx),\
|
|
$(linknamespace-symlists-base))
|
|
tests-special += $(linknamespace-symlists-tests)
|
|
|
|
linknamespace-symlist-stdlibs-base := $(foreach std,$(conformtest-standards),\
|
|
symlist-stdlibs-$(std))
|
|
linknamespace-symlist-stdlibs-tests := \
|
|
$(addprefix $(objpfx),\
|
|
$(linknamespace-symlist-stdlibs-base))
|
|
|
|
tests-special += $(linknamespace-symlist-stdlibs-tests)
|
|
|
|
linknamespace-header-base := $(foreach std,\
|
|
$(conformtest-standards),\
|
|
$(foreach h,\
|
|
$(conformtest-headers-$(std)),\
|
|
$(std)/$(h)/linknamespace.out))
|
|
linknamespace-header-tests := $(addprefix $(objpfx),\
|
|
$(linknamespace-header-base))
|
|
tests-special += $(linknamespace-header-tests)
|
|
|
|
include ../Rules
|
|
|
|
$(conformtest-header-list-tests): $(objpfx)header-list-%.out: \
|
|
check-header-lists.sh \
|
|
$(conformtest-headers-data)
|
|
$(SHELL) $< "$*" "$(CC)" "$(strip $(conformtest-headers-$*))" \
|
|
"$(conformtest-headers-data)" > $@; \
|
|
$(evaluate-test)
|
|
|
|
# Pre-standard C feature no longer supported by GCC (obsoleted in
|
|
# newer POSIX standards).
|
|
test-xfail-XPG3/varargs.h/conform = yes
|
|
test-xfail-XPG4/varargs.h/conform = yes
|
|
test-xfail-UNIX98/varargs.h/conform = yes
|
|
|
|
# Header not provided by glibc.
|
|
test-xfail-XPG4/ndbm.h/conform = yes
|
|
test-xfail-UNIX98/ndbm.h/conform = yes
|
|
test-xfail-XOPEN2K/ndbm.h/conform = yes
|
|
test-xfail-XOPEN2K8/ndbm.h/conform = yes
|
|
|
|
# Unsorted expected failures.
|
|
test-xfail-XPG3/signal.h/conform = yes
|
|
test-xfail-XPG3/sys/wait.h/conform = yes
|
|
test-xfail-XPG4/arpa/inet.h/conform = yes
|
|
test-xfail-XPG4/netdb.h/conform = yes
|
|
test-xfail-XPG4/netinet/in.h/conform = yes
|
|
test-xfail-XPG4/signal.h/conform = yes
|
|
test-xfail-XPG4/sys/wait.h/conform = yes
|
|
test-xfail-XPG4/ucontext.h/conform = yes
|
|
test-xfail-POSIX/sys/wait.h/conform = yes
|
|
test-xfail-UNIX98/arpa/inet.h/conform = yes
|
|
test-xfail-UNIX98/netdb.h/conform = yes
|
|
test-xfail-UNIX98/netinet/in.h/conform = yes
|
|
test-xfail-UNIX98/signal.h/conform = yes
|
|
test-xfail-UNIX98/sys/wait.h/conform = yes
|
|
test-xfail-UNIX98/ucontext.h/conform = yes
|
|
test-xfail-XOPEN2K/semaphore.h/conform = yes
|
|
test-xfail-XOPEN2K/signal.h/conform = yes
|
|
test-xfail-XOPEN2K/sys/wait.h/conform = yes
|
|
test-xfail-XOPEN2K/ucontext.h/conform = yes
|
|
test-xfail-POSIX2008/signal.h/conform = yes
|
|
test-xfail-POSIX2008/sys/wait.h/conform = yes
|
|
test-xfail-XOPEN2K8/signal.h/conform = yes
|
|
test-xfail-XOPEN2K8/sys/wait.h/conform = yes
|
|
|
|
conformtest-cc-flags = -I../include $(+sysdep-includes) $(sysincludes) -I..
|
|
# conformtest-xfail-conds may be set by a sysdeps Makefile fragment to
|
|
# a list of conditions that are considered to be true when encountered
|
|
# in xfail[cond]- lines in test expectations.
|
|
conformtest-xfail = $(if $(conformtest-xfail-conds),\
|
|
--xfail='$(conformtest-xfail-conds)')
|
|
ifeq (no,$(cross-compiling))
|
|
conformtest-cross =
|
|
else
|
|
conformtest-cross = --cross
|
|
endif
|
|
$(conformtest-header-tests): $(objpfx)%/conform.out: \
|
|
conformtest.pl $(conformtest-headers-data)
|
|
(set -e; std_hdr=$*; std=$${std_hdr%%/*}; hdr=$${std_hdr#*/}; \
|
|
mkdir -p $(@D)/scratch; \
|
|
$(PERL) -I. conformtest.pl --tmpdir=$(@D)/scratch --cc='$(CC)' \
|
|
--flags='$(conformtest-cc-flags)' --standard=$$std \
|
|
--headers=$$hdr $(conformtest-xfail) $(conformtest-cross) \
|
|
> $@); \
|
|
$(evaluate-test)
|
|
|
|
$(linknamespace-symlists-tests): $(objpfx)symlist-%: list-header-symbols.pl
|
|
$(PERL) -I. -w $< --tmpdir=$(objpfx) --cc='$(CC)' \
|
|
--flags='$(conformtest-cc-flags)' --standard=$* \
|
|
--headers="$(strip $(conformtest-headers-$*))" \
|
|
> $@ 2> $@.err; \
|
|
$(evaluate-test)
|
|
|
|
linknamespace-libs-isoc = $(common-objpfx)libc.a $(common-objpfx)math/libm.a
|
|
linknamespace-libs-thr = $(linknamespace-libs-isoc) \
|
|
$(common-objpfx)rt/librt.a $(static-thread-library)
|
|
linknamespace-libs-posix = $(linknamespace-libs-thr) \
|
|
$(common-objpfx)dlfcn/libdl.a
|
|
linknamespace-libs-xsi = $(linknamespace-libs-posix) \
|
|
$(common-objpfx)crypt/libcrypt.a
|
|
linknamespace-libs-ISO = $(linknamespace-libs-isoc)
|
|
linknamespace-libs-ISO99 = $(linknamespace-libs-isoc)
|
|
linknamespace-libs-ISO11 = $(linknamespace-libs-isoc)
|
|
linknamespace-libs-XPG3 = $(linknamespace-libs-isoc) \
|
|
$(common-objpfx)crypt/libcrypt.a
|
|
linknamespace-libs-XPG4 = $(linknamespace-libs-XPG3)
|
|
linknamespace-libs-POSIX = $(linknamespace-libs-thr)
|
|
linknamespace-libs-UNIX98 = $(linknamespace-libs-xsi)
|
|
linknamespace-libs-XOPEN2K = $(linknamespace-libs-xsi)
|
|
linknamespace-libs-POSIX2008 = $(linknamespace-libs-posix)
|
|
linknamespace-libs-XOPEN2K8 = $(linknamespace-libs-xsi)
|
|
linknamespace-libs = $(foreach std,$(conformtest-standards),\
|
|
$(linknamespace-libs-$(std)))
|
|
|
|
$(linknamespace-symlist-stdlibs-tests): $(objpfx)symlist-stdlibs-%: \
|
|
$(linknamespace-libs)
|
|
LC_ALL=C $(READELF) -W -s $(linknamespace-libs-$*) > $@; \
|
|
$(evaluate-test)
|
|
|
|
$(linknamespace-header-tests): $(objpfx)%/linknamespace.out: \
|
|
linknamespace.pl \
|
|
$(linknamespace-symlists-tests) \
|
|
$(linknamespace-symlist-stdlibs-tests)
|
|
(set -e; std_hdr=$*; std=$${std_hdr%%/*}; hdr=$${std_hdr#*/}; \
|
|
mkdir -p $(@D)/scratch; \
|
|
$(PERL) -I. -w $< --tmpdir=$(@D)/scratch --cc='$(CC)' \
|
|
--flags='$(conformtest-cc-flags)' --standard=$$std \
|
|
--stdsyms=$(objpfx)symlist-$$std --header=$$hdr \
|
|
--libsyms=$(objpfx)symlist-stdlibs-$$std \
|
|
--readelf='$(READELF)' \
|
|
> $@ 2>&1); \
|
|
$(evaluate-test)
|
|
|
|
# Pre-standard C feature no longer supported by GCC (obsoleted in
|
|
# newer POSIX standards).
|
|
test-xfail-XPG3/varargs.h/linknamespace = yes
|
|
test-xfail-XPG4/varargs.h/linknamespace = yes
|
|
test-xfail-UNIX98/varargs.h/linknamespace = yes
|
|
|
|
# Header not provided by glibc.
|
|
test-xfail-XPG4/ndbm.h/linknamespace = yes
|
|
test-xfail-UNIX98/ndbm.h/linknamespace = yes
|
|
test-xfail-XOPEN2K/ndbm.h/linknamespace = yes
|
|
test-xfail-XOPEN2K8/ndbm.h/linknamespace = yes
|