glibc/support
Joseph Myers 9fe3c80c7c Fix sys/socket.h namespace issues from sys/uio.h inclusion (bug 21426).
sys/socket.h includes sys/uio.h to get the definition of the iovec
structure.

POSIX allows sys/socket.h to make all sys/uio.h symbols visible.
However, all of sys/uio.h is XSI-shaded, so for non-XSI POSIX this
results in conformtest failures (for sys/socket.h and other headers
that include it):

    Namespace violation: "UIO_MAXIOV"
    Namespace violation: "readv"
    Namespace violation: "writev"

Now, there is some ambiguity in POSIX about what namespace
reservations apply in this case - see
http://austingroupbugs.net/view.php?id=1127 - but glibc convention
would still avoid declaring readv and writev, for example, for feature
test macros that don't include them (if only headers from the relevant
standard are included), even if such declarations are permitted, so
there is a bug here according to glibc conventions.

This patch moves the struct iovec definition to a new
bits/types/struct_iovec.h header and includes that from sys/socket.h
instead of including the whole of sys/uio.h.  This fixes the namespace
issue; however, three files in glibc that were relying on the implicit
inclusion needed to be updated to include sys/uio.h explicitly.  So
there is a question of whether sys/socket.h should continue to include
sys/uio.h under some conditions, such as __USE_XOPEN or __USE_MISC or
__USE_XOPEN || __USE_MISC, for greater compatibility with code that
(wrongly) expects this optional inclusion to be present there.  (I
think the three affected files in glibc should still have explicit
sys/uio.h inclusions added in any case, however.)

Tested for x86_64.

	[BZ #21426]
	* misc/bits/types/struct_iovec.h: New file.
	* misc/Makefile (headers): Add bits/types/struct_iovec.h.
	* include/bits/types/struct_iovec.h: New file.
	* bits/uio.h (struct iovec): Replace by inclusion of
	<bits/types/struct_iovec.h>.
	* sysdeps/unix/sysv/linux/bits/uio.h (struct iovec): Likewise.
	* socket/sys/socket.h: Include <bits/types/struct_iovec.h> instead
	of <sys/uio.h>.
	* nptl/tst-cancel4.c: Include <sys/uio.h>
	* posix/test-errno.c: Likewise.
	* support/resolv_test.c: Likewise.
	* conform/Makefile (test-xfail-POSIX2008/arpa/inet.h/conform):
	Remove.
	(test-xfail-POSIX2008/netdb.h/conform): Likewise.
	(test-xfail-POSIX2008/netinet/in.h/conform): Likewise.
	(test-xfail-POSIX2008/sys/socket.h/conform): Likewise.
2017-04-25 17:52:47 +00:00
..
check_addrinfo.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
check_dns_packet.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
check_hostent.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
check_netent.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
check_nss.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
check.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
check.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
delayed_exit.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
format_nss.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
ignore_stderr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
Makefile Assume that accept4 is always available and works 2017-04-19 07:44:48 +02:00
namespace.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
oom_error.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
README support: Introduce new subdirectory for test infrastructure 2016-12-09 08:18:27 +01:00
README-testing.c support: Introduce new subdirectory for test infrastructure 2016-12-09 08:18:27 +01:00
resolv_test.c Fix sys/socket.h namespace issues from sys/uio.h inclusion (bug 21426). 2017-04-25 17:52:47 +00:00
resolv_test.h resolv: Reduce EDNS payload size to 1200 bytes [BZ #21361] 2017-04-13 13:09:38 +02:00
run_diff.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
set_fortify_handler.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
support_become_root.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
support_enter_network_namespace.c support: Add error checking to close system calls [BZ #21244] 2017-03-15 13:33:40 +01:00
support_format_address_family.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
support_format_addrinfo.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
support_format_dns_packet.c support_format_dns_packet: Fix CNAME and multiple RR handling 2017-03-15 13:33:40 +01:00
support_format_herrno.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
support_format_hostent.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
support_format_netent.c support: struct netent portability fix for support_format_netent 2017-01-01 09:35:45 +01:00
support_record_failure.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
support_run_diff.c support: Add error checking to close system calls [BZ #21244] 2017-03-15 13:33:40 +01:00
support_test_main.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
support_test_verify_impl.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
support.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
temp_file-internal.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
temp_file.c support: Explain ignored failures of temporary file removal [BZ #21243] 2017-03-15 13:33:40 +01:00
temp_file.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
test-driver.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
test-driver.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
tst-support_format_dns_packet.c Another round of inclusion fixes for _ISOMAC testsuite. 2017-03-22 08:44:32 -04:00
tst-support_record_failure-2.sh Another round of inclusion fixes for _ISOMAC testsuite. 2017-03-22 08:44:32 -04:00
tst-support_record_failure.c Another round of inclusion fixes for _ISOMAC testsuite. 2017-03-22 08:44:32 -04:00
tst-support-namespace.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
write_message.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xaccept4.c Assume that accept4 is always available and works 2017-04-19 07:44:48 +02:00
xaccept.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xasprintf.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xbind.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xcalloc.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xclose.c support: Add error checking to close system calls [BZ #21244] 2017-03-15 13:33:40 +01:00
xconnect.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xfclose.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xfopen.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xfork.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xgetsockname.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xlisten.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xmalloc.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xmemstream.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xmemstream.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xmmap.c nptl: Add tst-robust-fork 2017-01-27 06:53:20 +01:00
xmunmap.c nptl: Add tst-robust-fork 2017-01-27 06:53:20 +01:00
xpoll.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_attr_destroy.c Bug 20116: Fix use after free in pthread_create() 2017-01-28 19:21:44 -05:00
xpthread_attr_init.c Bug 20116: Fix use after free in pthread_create() 2017-01-28 19:21:44 -05:00
xpthread_attr_setdetachstate.c Bug 20116: Fix use after free in pthread_create() 2017-01-28 19:21:44 -05:00
xpthread_attr_setstacksize.c Bug 20116: Fix use after free in pthread_create() 2017-01-28 19:21:44 -05:00
xpthread_barrier_destroy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_barrier_init.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_barrier_wait.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_cancel.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_check_return.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_cond_wait.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_create.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_detach.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_join.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_mutex_consistent.c nptl: Add tst-robust-fork 2017-01-27 06:53:20 +01:00
xpthread_mutex_destroy.c nptl: Add tst-robust-fork 2017-01-27 06:53:20 +01:00
xpthread_mutex_init.c nptl: Add tst-robust-fork 2017-01-27 06:53:20 +01:00
xpthread_mutex_lock.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_mutex_unlock.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_mutexattr_destroy.c nptl: Add tst-robust-fork 2017-01-27 06:53:20 +01:00
xpthread_mutexattr_init.c nptl: Add tst-robust-fork 2017-01-27 06:53:20 +01:00
xpthread_mutexattr_setprotocol.c nptl: Add tst-robust-fork 2017-01-27 06:53:20 +01:00
xpthread_mutexattr_setpshared.c nptl: Add tst-robust-fork 2017-01-27 06:53:20 +01:00
xpthread_mutexattr_setrobust.c nptl: Add tst-robust-fork 2017-01-27 06:53:20 +01:00
xpthread_mutexattr_settype.c nptl: Add tst-robust-fork 2017-01-27 06:53:20 +01:00
xpthread_once.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_sigmask.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_spin_lock.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xpthread_spin_unlock.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xrealloc.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xrecvfrom.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xsendto.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xsetsockopt.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xsignal.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xsocket.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xsocket.h Assume that accept4 is always available and works 2017-04-19 07:44:48 +02:00
xstdio.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xstrdup.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xthread.h Bug 20116: Fix use after free in pthread_create() 2017-01-28 19:21:44 -05:00
xunistd.h support: Add error checking to close system calls [BZ #21244] 2017-03-15 13:33:40 +01:00
xwaitpid.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
xwrite.c support: Use %td for pointer difference in xwrite 2017-01-01 09:27:54 +01:00

This subdirectory contains infrastructure which is not put into
installed libraries, but may be linked into programs (installed or
not) and tests.

# Error-checking wrappers

These wrappers test for error return codes an terminate the process on
error.  They are declared in these header files:

* support.h
* xsignal.h
* xthread.h

In general, new wrappers should be added to support.h if possible.
However, support.h must remain fully compatible with C90 and therefore
cannot include headers which use identifers not reserved in C90.  If
the wrappers need additional types, additional headers such as
signal.h need to be introduced.

# Test framework

The test framework provides a main program for tests, including a
timeout for hanging tests.  See README-testing.c for a minimal
example, and test-driver.c for details how to use it.  The following
header files provide related declarations:

* check.h
* temp_file.h
* test-driver.h