mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-26 23:10:06 +00:00
e02920bc02
In non-default rounding modes, tgamma can be slightly less accurate than permitted by glibc's accuracy goals. Part of the problem is error accumulation, addressed in this patch by setting round-to-nearest for internal computations. However, there was also a bug in the code dealing with computing pow (x + n, x + n) where x + n is not exactly representable, providing another source of error even in round-to-nearest mode; it was necessary to address both bugs to get errors for all testcases within glibc's accuracy goals. Given this second fix, accuracy in round-to-nearest mode is also improved (hence regeneration of ulps for tgamma should be from scratch - truncate libm-test-ulps or at least remove existing tgamma entries - so that the expected ulps can be reduced). Some additional complications also arose. Certain tgamma tests should strictly, according to IEEE semantics, overflow or not depending on the rounding mode; this is beyond the scope of glibc's accuracy goals for any function without exactly-determined results, but gen-auto-libm-tests doesn't handle being lax there as it does for underflow. (libm-test.inc also doesn't handle being lax about whether the result in cases very close to the overflow threshold is infinity or a finite value close to overflow, but that doesn't cause problems in this case though I've seen it cause problems with random test generation for some functions.) Thus, spurious-overflow markings, with a comment, are added to auto-libm-test-in (no bug in Bugzilla because the issue is with the testsuite, not a user-visible bug in glibc). And on x86, after the patch I saw ERANGE issues as previously reported by Carlos (see my commentary in <https://sourceware.org/ml/libc-alpha/2015-01/msg00485.html>), which needed addressing by ensuring excess range and precision were eliminated at various points if FLT_EVAL_METHOD != 0. I also noticed and fixed a cosmetic issue where 1.0f was used in long double functions and should have been 1.0L. This completes the move of all functions to testing in all rounding modes with ALL_RM_TEST, so gen-libm-have-vector-test.sh is updated to remove the workaround for some functions not using ALL_RM_TEST. Tested for x86_64, x86, mips64 and powerpc. [BZ #18613] * sysdeps/ieee754/dbl-64/e_gamma_r.c (gamma_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gamma_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. * sysdeps/ieee754/flt-32/e_gammaf_r.c (gammaf_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammaf_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. * sysdeps/ieee754/ldbl-128/e_gammal_r.c (gammal_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammal_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. Use 1.0L not 1.0f as numerator of division. * sysdeps/ieee754/ldbl-128ibm/e_gammal_r.c (gammal_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammal_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. Use 1.0L not 1.0f as numerator of division. * sysdeps/ieee754/ldbl-96/e_gammal_r.c (gammal_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammal_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. Use 1.0L not 1.0f as numerator of division. * math/libm-test.inc (tgamma_test_data): Remove one test. Moved to auto-libm-test-in. (tgamma_test): Use ALL_RM_TEST. * math/auto-libm-test-in: Add one test of tgamma. Mark some other tests of tgamma with spurious-overflow. * math/auto-libm-test-out: Regenerated. * math/gen-libm-have-vector-test.sh: Do not check for START. * sysdeps/i386/fpu/libm-test-ulps: Update. * sysdeps/x86_64/fpu/libm-test-ulps: Likewise. |
||
|---|---|---|
| .. | ||
| wordsize-64 | ||
| asincos.tbl | ||
| atnat2.h | ||
| atnat.h | ||
| branred.c | ||
| branred.h | ||
| dbl2mpn.c | ||
| dla.h | ||
| doasin.c | ||
| doasin.h | ||
| dosincos.c | ||
| dosincos.h | ||
| e_acos.c | ||
| e_acosh.c | ||
| e_asin.c | ||
| e_atan2.c | ||
| e_atanh.c | ||
| e_cosh.c | ||
| e_exp2.c | ||
| e_exp10.c | ||
| e_exp.c | ||
| e_fmod.c | ||
| e_gamma_r.c | ||
| e_hypot.c | ||
| e_ilogb.c | ||
| e_j0.c | ||
| e_j1.c | ||
| e_jn.c | ||
| e_lgamma_r.c | ||
| e_log2.c | ||
| e_log10.c | ||
| e_log.c | ||
| e_pow.c | ||
| e_rem_pio2.c | ||
| e_remainder.c | ||
| e_sinh.c | ||
| e_sqrt.c | ||
| gamma_product.c | ||
| gamma_productf.c | ||
| halfulp.c | ||
| k_cos.c | ||
| k_rem_pio2.c | ||
| k_sin.c | ||
| k_tan.c | ||
| Makefile | ||
| MathLib.h | ||
| mpa-arch.h | ||
| mpa.c | ||
| mpa.h | ||
| mpatan2.c | ||
| mpatan.c | ||
| mpatan.h | ||
| mpexp.c | ||
| mplog.c | ||
| mpn2dbl.c | ||
| mpsqrt.c | ||
| mpsqrt.h | ||
| mptan.c | ||
| mydefs.h | ||
| powtwo.tbl | ||
| root.tbl | ||
| s_asinh.c | ||
| s_atan.c | ||
| s_cbrt.c | ||
| s_ceil.c | ||
| s_copysign.c | ||
| s_cos.c | ||
| s_erf.c | ||
| s_expm1.c | ||
| s_fabs.c | ||
| s_finite.c | ||
| s_floor.c | ||
| s_fma.c | ||
| s_fmaf.c | ||
| s_fpclassify.c | ||
| s_frexp.c | ||
| s_isinf_ns.c | ||
| s_isinf.c | ||
| s_isnan.c | ||
| s_issignaling.c | ||
| s_llrint.c | ||
| s_llround.c | ||
| s_log1p.c | ||
| s_logb.c | ||
| s_lrint.c | ||
| s_lround.c | ||
| s_modf.c | ||
| s_nearbyint.c | ||
| s_nexttoward.c | ||
| s_remquo.c | ||
| s_rint.c | ||
| s_round.c | ||
| s_scalbln.c | ||
| s_scalbn.c | ||
| s_signbit.c | ||
| s_sin.c | ||
| s_sincos.c | ||
| s_tan.c | ||
| s_tanh.c | ||
| s_trunc.c | ||
| sincos32.c | ||
| sincos32.h | ||
| sincostab.c | ||
| slowexp.c | ||
| slowpow.c | ||
| t_exp2.h | ||
| t_exp.c | ||
| uasncs.h | ||
| uatan.tbl | ||
| uexp.h | ||
| uexp.tbl | ||
| ulog.h | ||
| ulog.tbl | ||
| upow.h | ||
| upow.tbl | ||
| urem.h | ||
| uroot.h | ||
| usncs.h | ||
| utan.h | ||
| utan.tbl | ||
| w_exp.c | ||
| x2y2m1.c | ||
| x2y2m1f.c | ||